Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

["Laszlo Ersek" <lersek@redhat.com>]

On 04/04/19 01:42, Michael D Kinney wrote:

> 17a33094a9 edk2: Add License-History.txt

I have a minuscule comment for this patch.

In the "Key Dates" section, you list two dates:
- July 18, 2017
- April 9, 2019

The 2nd date refers to a commit (that is, not patch authorship) date. I
think that's fine.

The first date however refers to a patch authorship date, not a commit
date. I don't feel too strongly about this, but I think the consistency
could be improved.

In particular, from the commits listed in
<https://bugzilla.tianocore.org/show_bug.cgi?id=629#c3>, the most
relevant seems to be b6538c118ae8. The authorship date on that patch is
indeed 2017-07-18; however its commit date is 2017-08-03.

If, for one of the "key dates" above, we use a "commit date" (and not an
"authorship date"), then we might want to do the same for the other "key
date" (i.e., we might want to replace "July 18, 2017" with "August 3,
2017").

Anyway, I'll leave it up to you; I'm fine with the patch as-is.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD to BSD+Patent

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> bc61733285 edk2: Replace BSD License with BSD+Patent License

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> eece5f8a6e edk2: Remove Contributions.txt and update Readme.md

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo