Re: [PATCH] OvmfPkg: Remove superfluous return statements.

[Laszlo Ersek <lersek@redhat.com>]

On 01/19/17 10:17, Thomas Huth wrote:
> If the code eventually returns "Status" anyway, it does not make
> sense to explicitely return "Status" in case of an error, too.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 3 ---
>  OvmfPkg/XenBusDxe/XenStore.c             | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
> index 826901f..cd0bfff 100644
> --- a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
> +++ b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
> @@ -77,9 +77,6 @@ GetNvVarsFile (
>                       ),
>                     0
>                     );
> -  if (EFI_ERROR (Status)) {
> -    return Status;
> -  }
>  
>    return Status;
>  }
> diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
> index 1666c4b..76b6e29 100644
> --- a/OvmfPkg/XenBusDxe/XenStore.c
> +++ b/OvmfPkg/XenBusDxe/XenStore.c
> @@ -1075,9 +1075,6 @@ XenStoreInit (
>  
>    /* Initialize the shared memory rings to talk to xenstored */
>    Status = XenStoreInitComms (&xs);
> -  if (EFI_ERROR (Status)) {
> -    return Status;
> -  }
>  
>    return Status;
>  }
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Pushed as commit 19ca06bb84ca.

Thanks!
Laszlo