* [PATCH] OvmfPkg: Remove superfluous return statements.
@ 2017-01-19 9:17 Thomas Huth
2017-01-19 9:41 ` Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2017-01-19 9:17 UTC (permalink / raw)
To: edk2-devel; +Cc: Laszlo Ersek, Jordan Justen
If the code eventually returns "Status" anyway, it does not make
sense to explicitely return "Status" in case of an error, too.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 3 ---
OvmfPkg/XenBusDxe/XenStore.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
index 826901f..cd0bfff 100644
--- a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
+++ b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
@@ -77,9 +77,6 @@ GetNvVarsFile (
),
0
);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
index 1666c4b..76b6e29 100644
--- a/OvmfPkg/XenBusDxe/XenStore.c
+++ b/OvmfPkg/XenBusDxe/XenStore.c
@@ -1075,9 +1075,6 @@ XenStoreInit (
/* Initialize the shared memory rings to talk to xenstored */
Status = XenStoreInitComms (&xs);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] OvmfPkg: Remove superfluous return statements.
2017-01-19 9:17 [PATCH] OvmfPkg: Remove superfluous return statements Thomas Huth
@ 2017-01-19 9:41 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2017-01-19 9:41 UTC (permalink / raw)
To: Thomas Huth, edk2-devel; +Cc: Jordan Justen
On 01/19/17 10:17, Thomas Huth wrote:
> If the code eventually returns "Status" anyway, it does not make
> sense to explicitely return "Status" in case of an error, too.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 3 ---
> OvmfPkg/XenBusDxe/XenStore.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
> index 826901f..cd0bfff 100644
> --- a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
> +++ b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
> @@ -77,9 +77,6 @@ GetNvVarsFile (
> ),
> 0
> );
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
> index 1666c4b..76b6e29 100644
> --- a/OvmfPkg/XenBusDxe/XenStore.c
> +++ b/OvmfPkg/XenBusDxe/XenStore.c
> @@ -1075,9 +1075,6 @@ XenStoreInit (
>
> /* Initialize the shared memory rings to talk to xenstored */
> Status = XenStoreInitComms (&xs);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Pushed as commit 19ca06bb84ca.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-19 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 9:17 [PATCH] OvmfPkg: Remove superfluous return statements Thomas Huth
2017-01-19 9:41 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox