From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8F90174004E for ; Thu, 2 Nov 2023 10:20:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9jSQFKLOseEa57hSn1td/Vx6K6SbjOIn/ED57KX+iOU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:From:Subject:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698920410; v=1; b=HxToXN7mkmV7adgIvUbA8A+QpEWYgnAB3prf7+YTdULB5rmx87wOJaFWt+/8y9Hu/nDP8+s1 GuqsdH2C7aH5lfLKFXSjU8iy69cCfSAmg40Ou4wpZxxAVf6pBVfYUXYbabSzy5S/EdGfF3LLQBs RoSr+av/AL9LRdDzrQpH/aPQ= X-Received: by 127.0.0.2 with SMTP id bkneYY7687511x7AdsT7pGfe; Thu, 02 Nov 2023 03:20:10 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.27685.1698920409626158627 for ; Thu, 02 Nov 2023 03:20:09 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61D9C2F4; Thu, 2 Nov 2023 03:20:51 -0700 (PDT) X-Received: from [10.34.100.114] (e126645.nice.arm.com [10.34.100.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5600A3F67D; Thu, 2 Nov 2023 03:20:08 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 11:20:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "PierreGondois" Subject: Re: [edk2-devel] [PATCH v2 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION To: Leif Lindholm Cc: devel@edk2.groups.io, Sami Mujawar , Ard Biesheuvel , Michael D Kinney , Liming Gao References: <20231025112540.1654844-1-pierre.gondois@arm.com> <20231025112540.1654844-2-pierre.gondois@arm.com> In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DKUBPxTfHaMVw67LHjegYWvax7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HxToXN7m; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Leif, Thanks for the review, On 10/26/23 12:05, Leif Lindholm wrote: > On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gondois@arm.com wrote: >> From: Pierre Gondois >> >> Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different >> versions of the protocol. The macro is neither used in edk2 nor >> in edk2-platforms. >=20 > OK, so slight nitpick, but mainly because it parses a bit weirdly... > *Will* it be used after this series is merged, or is this an update > for completeness? The 'fast channels' were added in the v2.0 SCMI specification. This patch-s= et relies on this feature, so it is checked in: [PATCH v2 10/11] DynamicTablesPkg: Add ArmScmiInfoLib that the underlying SCP is at least at this version. ``` // FastChannels were added in SCMI v2.0 spec. if (Version < PERFORMANCE_PROTOCOL_VERSION_V2) { DEBUG ((DEBUG_ERROR, "ArmScmiInfoLib requires SCMI version > 2.0\n"))= ; return EFI_UNSUPPORTED; } ``` >=20 >> Signed-off-by: Pierre Gondois >> --- >> ArmPkg/Include/Library/ArmLib.h | 1 + >> .../Include/Protocol/ArmScmiPerformanceProtocol.h | 13 ++++++++----- >> 2 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/Ar= mLib.h >> index 0169dbc1092c..7b2b2238fed9 100644 >> --- a/ArmPkg/Include/Library/ArmLib.h >> +++ b/ArmPkg/Include/Library/ArmLib.h >> @@ -780,6 +780,7 @@ EFIAPI >> ArmHasVhe ( >> VOID >> ); >> + >> #endif // MDE_CPU_AARCH64 >> =20 >> #ifdef MDE_CPU_ARM >> diff --git a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h b/ArmP= kg/Include/Protocol/ArmScmiPerformanceProtocol.h >> index 7e548e4765c2..8e8e05d5a5f6 100644 >> --- a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h >> +++ b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h >> @@ -1,12 +1,12 @@ >> /** @file >> =20 >> - Copyright (c) 2017-2021, Arm Limited. All rights reserved. >> + Copyright (c) 2017-2023, Arm Limited. All rights reserved. >> =20 >> SPDX-License-Identifier: BSD-2-Clause-Patent >> =20 >> - System Control and Management Interface V1.0 >> - http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/ >> - DEN0056A_System_Control_and_Management_Interface.pdf >> + System Control and Management Interface, latest version: >=20 > I see this as a pattern throughout the series. > But this statement will at some point become untrue; this > implementation is written against a specific version. I think this > version shold be reflected in the comment. (And that applies > throughout the series.) >=20 >> + - https://developer.arm.com/documentation/den0056/latest/ >=20 > But I think the above is the most useful link. I am not sure I understand completely. Do you mean that the SCMI structures/interfaces defined in: ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h and that were written against the SCMI v1.0 specification should not be used as such for other SCMI specification version ? I.e. the same process as for the AcpiXX.h files (MdePkg/Include/IndustryStandard/Acpi65.h) should be used ? Or do you mean that the _CPC object generation implies that the SCP should comply to the v2.0 version at least and this should be reflected in the commit messages ? Regards, Pierre >=20 > / > Leif >=20 >> + >> **/ >> =20 >> #ifndef ARM_SCMI_PERFORMANCE_PROTOCOL_H_ >> @@ -14,7 +14,10 @@ >> =20 >> #include >> =20 >> -#define PERFORMANCE_PROTOCOL_VERSION 0x10000 >> +/// Arm Scmi performance protocol versions. >> +#define PERFORMANCE_PROTOCOL_VERSION_V1 0x10000 >> +#define PERFORMANCE_PROTOCOL_VERSION_V2 0x20000 >> +#define PERFORMANCE_PROTOCOL_VERSION_V3 0x30000 >> =20 >> #define ARM_SCMI_PERFORMANCE_PROTOCOL_GUID { \ >> 0x9b8ba84, 0x3dd3, 0x49a6, {0xa0, 0x5a, 0x31, 0x34, 0xa5, 0xf0, 0x7b= , 0xad} \ >> --=20 >> 2.25.1 >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110515): https://edk2.groups.io/g/devel/message/110515 Mute This Topic: https://groups.io/mt/102175810/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-