From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.76.1571664009430466322 for ; Mon, 21 Oct 2019 06:20:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DFFjoHeH; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571664005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4xtTzmVIHh9z5b0LfK17Q7CdvftmWBWEINpIk53kXSc=; b=DFFjoHeH5V6j/bkGUTq++w3uHRfmaSIwfBkfgnNVseAFbG4tW8t3W/8AOqKzHyDV54tVE9 gabY3XNGJ/7UR7iAH9wkEZPSMKegWZHpBuN/NESy0EimPf1FT2nEULBCvHgXh6UcLhdej+ u5pArMwe7U5st4jZUBPuv7SwGX/PRJc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-JhkxCdxUOF6Fuyq0PQzFEA-1; Mon, 21 Oct 2019 09:20:03 -0400 Received: by mail-wm1-f69.google.com with SMTP id z5so3108210wma.5 for ; Mon, 21 Oct 2019 06:20:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KQSFFsbeBOyc4izzN5sz9jSxZQ1kSIrommzrhRnVtus=; b=IW145uS51NxTqKQE5Cg+dpQX/VUxs5lPktcYZnFslJvbyEwy2lvD46CJOKfBu3xJkP gy4lKZS+v1S+OAN5252qOrZhGCSb/2+7LNUWoMw4xBu2jEoqgi5i/XdrgCr7bFrv96h6 vEdOOymSbiiq96zssGDLqNkUUiscnWaAhBK3DZjAEiJaXIju3cYxdhMcXrMW3jyxzd6c Vy5FfaKNpn9G6M8i1q1rHstZADOa9U+dcbs5X2G4MbR+rV9csMRy8Mn4J9Aiqj784cX+ AQvRm2dEJn2Tbs2iEd3MCfKFNhVMQPzTUaNRSonimApSBZJdL49jBkZSUWLwpP/vCj57 XEUg== X-Gm-Message-State: APjAAAUjhUAgPuaj7UUbD6YORr/eq8taVzoS/LVn25WLlX2sov0EqqTM CbZ6l6EecxlvJhCcjkc5dsQc6yV1ajhTjye3/l5JghTDduifVc0nxqpGYh5uAL3C1IPT1OA72Tc SHAveHlGYg9rexw== X-Received: by 2002:a5d:6b03:: with SMTP id v3mr20698308wrw.182.1571664002019; Mon, 21 Oct 2019 06:20:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDz6orhEyh0uEzV72Is/knR5n2rdBNYkIwRfWMwnTvpipUjZBkuk7ixSmeP0f8BlUFv3XrOA== X-Received: by 2002:a5d:6b03:: with SMTP id v3mr20698268wrw.182.1571664001585; Mon, 21 Oct 2019 06:20:01 -0700 (PDT) Return-Path: Received: from [192.168.1.41] (129.red-83-57-174.dynamicip.rima-tde.net. [83.57.174.129]) by smtp.gmail.com with ESMTPSA id t13sm21046318wra.70.2019.10.21.06.20.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2019 06:20:01 -0700 (PDT) Subject: Re: [edk2-devel] [Patch] PcAtChipsetPkg: Fix spelling errors To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Ray Ni References: <20191018193437.3100-1-michael.d.kinney@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Mon, 21 Oct 2019 15:20:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191018193437.3100-1-michael.d.kinney@intel.com> X-MC-Unique: JhkxCdxUOF6Fuyq0PQzFEA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10/18/19 9:34 PM, Michael D Kinney wrote: > From: Sean Brogan >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2263 >=20 > Cc: Ray Ni > Signed-off-by: Michael D Kinney > --- > PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c | 12 ++++++------ > PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf | 2 +- > PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni | 2 +- > PcAtChipsetPkg/Include/Library/IoApicLib.h | 2 +- > PcAtChipsetPkg/Include/Register/Hpet.h | 6 +++--- > PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c | 2 +- > PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 8 ++++---- > PcAtChipsetPkg/PcAtChipsetPkg.dec | 2 +- > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 4 ++-- > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.h | 8 ++++---- > .../PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 2 +- > 11 files changed, 25 insertions(+), 25 deletions(-) >=20 > diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c b/PcAtChipsetPkg/Hpe= tTimerDxe/HpetTimer.c > index ded3b53619..cbe986ebfd 100644 > --- a/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c > +++ b/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c > @@ -1,5 +1,5 @@ > /** @file > - Timer Architectural Protocol module using High Precesion Event Timer (= HPET) > + Timer Architectural Protocol module using High Precision Event Timer (= HPET) > =20 > Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -246,7 +246,7 @@ HpetRead ( > /** > Write a 64-bit HPET register. > =20 > - @param Offset Specifies the ofsfert of the HPET register to write. > + @param Offset Specifies the offset of the HPET register to write. > @param Value Specifies the value to write to the HPET register spe= cified by Offset. > =20 > @return The 64-bit value written to HPET register specified by Offse= t. > @@ -530,7 +530,7 @@ TimerDriverSetTimerPeriod ( > // If TimerPeriod is 0, then mask HPET Timer interrupts > // > =20 > - if (mTimerConfiguration.Bits.MsiInterruptCapablity !=3D 0 && Feature= PcdGet (PcdHpetMsiEnable)) { > + if (mTimerConfiguration.Bits.MsiInterruptCapability !=3D 0 && Featur= ePcdGet (PcdHpetMsiEnable)) { Ah, this changes are not present in the previous patch version=20 (https://edk2.groups.io/g/devel/message/43354) so I now realize we had 2=20 person doing the same work, and failed at noticing because we kinda=20 ignored the previous patches :| > // > // Disable HPET MSI interrupt generation > // > @@ -576,7 +576,7 @@ TimerDriverSetTimerPeriod ( > // > // Enable HPET Timer interrupt generation > // > - if (mTimerConfiguration.Bits.MsiInterruptCapablity !=3D 0 && Feature= PcdGet (PcdHpetMsiEnable)) { > + if (mTimerConfiguration.Bits.MsiInterruptCapability !=3D 0 && Featur= ePcdGet (PcdHpetMsiEnable)) { > // > // Program MSI Address and MSI Data values in the selected HPET T= imer > // Program HPET register with APIC ID of current BSP in case BSP = has been switched > @@ -834,7 +834,7 @@ TimerDriverInitialize ( > // > // Check to see if this HPET Timer supports MSI > // > - if (mTimerConfiguration.Bits.MsiInterruptCapablity !=3D 0) { > + if (mTimerConfiguration.Bits.MsiInterruptCapability !=3D 0) { > // > // Save the index of the first HPET Timer that supports MSI inter= rupts > // > @@ -959,7 +959,7 @@ TimerDriverInitialize ( > // Show state of enabled HPET timer > // > DEBUG_CODE ( > - if (mTimerConfiguration.Bits.MsiInterruptCapablity !=3D 0 && Feature= PcdGet (PcdHpetMsiEnable)) { > + if (mTimerConfiguration.Bits.MsiInterruptCapability !=3D 0 && Featur= ePcdGet (PcdHpetMsiEnable)) { > DEBUG ((DEBUG_INFO, "HPET Interrupt Mode MSI\n")); > } else { > DEBUG ((DEBUG_INFO, "HPET Interrupt Mode I/O APIC\n")); > diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf b/PcAtChipsetPk= g/HpetTimerDxe/HpetTimerDxe.inf > index ba2e075118..125eea0aab 100644 > --- a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf > +++ b/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf > @@ -1,5 +1,5 @@ > ## @file > -# Timer Architectural Protocol module using High Precesion Event Timer (= HPET). > +# Timer Architectural Protocol module using High Precision Event Timer (= HPET). > # > # Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni b/PcAtChipsetPk= g/HpetTimerDxe/HpetTimerDxe.uni > index e2320653b6..7d1797b1df 100644 > --- a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni > +++ b/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni > @@ -1,5 +1,5 @@ > // /** @file > -// Timer Architectural Protocol module using High Precesion Event Timer = (HPET). > +// Timer Architectural Protocol module using High Precision Event Timer = (HPET). > // > // Timer Architectural Protocol module using High Precision Event Timer= (HPET). > // > diff --git a/PcAtChipsetPkg/Include/Library/IoApicLib.h b/PcAtChipsetPkg/= Include/Library/IoApicLib.h > index 200ef731fb..4ee092c0f2 100644 > --- a/PcAtChipsetPkg/Include/Library/IoApicLib.h > +++ b/PcAtChipsetPkg/Include/Library/IoApicLib.h > @@ -63,7 +63,7 @@ IoApicEnableInterrupt ( > Configures an I/O APIC interrupt. > =20 > Configure an I/O APIC Redirection Table Entry to deliver an interrupt= in physical > - mode to the Local APIC of the currntly executing CPU. The default sta= te of the > + mode to the Local APIC of the currently executing CPU. The default st= ate of the > entry is for the interrupt to be disabled (masked). IoApicEnableInte= rrupts() must > be used to enable(unmask) the I/O APIC Interrupt. > =20 > diff --git a/PcAtChipsetPkg/Include/Register/Hpet.h b/PcAtChipsetPkg/Incl= ude/Register/Hpet.h > index f7c0174e14..8437ec1f2d 100644 > --- a/PcAtChipsetPkg/Include/Register/Hpet.h > +++ b/PcAtChipsetPkg/Include/Register/Hpet.h > @@ -70,14 +70,14 @@ typedef union { > UINT32 LevelTriggeredInterrupt:1; > UINT32 InterruptEnable:1; > UINT32 PeriodicInterruptEnable:1; > - UINT32 PeriodicInterruptCapablity:1; > - UINT32 CounterSizeCapablity:1; > + UINT32 PeriodicInterruptCapability:1; > + UINT32 CounterSizeCapability:1; > UINT32 ValueSetEnable:1; > UINT32 Reserved1:1; > UINT32 CounterSizeEnable:1; > UINT32 InterruptRoute:5; > UINT32 MsiInterruptEnable:1; > - UINT32 MsiInterruptCapablity:1; > + UINT32 MsiInterruptCapability:1; > UINT32 Reserved2:16; > UINT32 InterruptRouteCapability; > } Bits; > diff --git a/PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c b/PcAtChips= etPkg/Library/BaseIoApicLib/IoApicLib.c > index 7a3c9aca8d..9e4a58049e 100644 > --- a/PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c > +++ b/PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c > @@ -94,7 +94,7 @@ IoApicEnableInterrupt ( > Configures an I/O APIC interrupt. > =20 > Configure an I/O APIC Redirection Table Entry to deliver an interrupt= in physical > - mode to the Local APIC of the currntly executing CPU. The default sta= te of the > + mode to the Local APIC of the currently executing CPU. The default st= ate of the > entry is for the interrupt to be disabled (masked). IoApicEnableInte= rrupts() must > be used to enable(unmask) the I/O APIC Interrupt. > =20 > diff --git a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c b/PcAtChi= psetPkg/Library/SerialIoLib/SerialPortLib.c > index 93affe151e..25c4cefc13 100644 > --- a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c > +++ b/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c > @@ -195,7 +195,7 @@ SerialPortRead ( > /** > Polls a serial device to see if there is any data waiting to be read. > =20 > - Polls aserial device to see if there is any data waiting to be read. > + Polls a serial device to see if there is any data waiting to be read. > If there is data waiting to be read from the serial device, then TRUE= is returned. > If there is no data waiting to be read from the serial device, then F= ALSE is returned. > =20 > @@ -339,13 +339,13 @@ SerialPortGetControl ( > } > =20 > /** > - Sets the baud rate, receive FIFO depth, transmit/receice time out, par= ity, > + Sets the baud rate, receive FIFO depth, transmit/receive time out, par= ity, > data bits, and stop bits on a serial device. > =20 > @param BaudRate The requested baud rate. A BaudRate value o= f 0 will use the > device's default interface speed. > On output, the value actually set. > - @param ReveiveFifoDepth The requested depth of the FIFO on the recei= ve side of the > + @param ReceiveFifoDepth The requested depth of the FIFO on the recei= ve side of the > serial interface. A ReceiveFifoDepth value = of 0 will use > the device's default FIFO depth. > On output, the value actually set. > @@ -358,7 +358,7 @@ SerialPortGetControl ( > DefaultParity will use the device's default= parity value. > On output, the value actually set. > @param DataBits The number of data bits to use on the seria= l device. A DataBits > - vaule of 0 will use the device's default dat= a bit setting. > + value of 0 will use the device's default dat= a bit setting. > On output, the value actually set. > @param StopBits The number of stop bits to use on this seri= al device. A StopBits > value of DefaultStopBits will use the devic= e's default number of > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec b/PcAtChipsetPkg/PcAtChips= etPkg.dec > index aad53b07c8..88de5cceea 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > @@ -50,7 +50,7 @@ [PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx, PcdsPatc= hableInModule] > # @Prompt HPET local APIC vector. > gPcAtChipsetPkgTokenSpaceGuid.PcdHpetLocalApicVector|0x40|UINT8|0x000= 0000A > =20 > - ## This PCD specifies the defaut period of the HPET Timer in 100 ns un= its. > + ## This PCD specifies the default period of the HPET Timer in 100 ns u= nits. > # The default value of 100000 100 ns units is the same as 10 ms. > # @Prompt Default period of HPET timer. > gPcAtChipsetPkgTokenSpaceGuid.PcdHpetDefaultTimerPeriod|100000|UINT64= |0x0000000B > diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c b/PcAtChi= psetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > index 8b68b0f192..52af179417 100644 > --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > @@ -1051,9 +1051,9 @@ IsLeapYear ( > } > =20 > /** > - Converts time from EFI_TIME format defined by UEFI spec to RTC's. > + Converts time from EFI_TIME format defined by UEFI spec to RTC format. > =20 > - This function converts time from EFI_TIME format defined by UEFI spec = to RTC's. > + This function converts time from EFI_TIME format defined by UEFI spec = to RTC format. > If data mode of RTC is BCD, then converts EFI_TIME to it. > If RTC is in 12-hour format, then converts EFI_TIME to it. > =20 > diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.h b/PcAtChi= psetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.h > index 038482d04d..47293ce44c 100644 > --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.h > +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.h > @@ -110,7 +110,7 @@ typedef struct { > UINT8 Uf : 1; // Update End Interrupt Flag > UINT8 Af : 1; // Alarm Interrupt Flag > UINT8 Pf : 1; // Periodic Interrupt Flag > - UINT8 Irqf : 1; // Iterrupt Request Flag =3D PF & PIE | AF & AIE |= UF & UIE > + UINT8 Irqf : 1; // Interrupt Request Flag =3D PF & PIE | AF & AIE = | UF & UIE > } RTC_REGISTER_C_BITS; > =20 > typedef union { > @@ -234,7 +234,7 @@ PcRtcGetWakeupTime ( > /** > The user Entry Point for PcRTC module. > =20 > - This is the entrhy point for PcRTC module. It installs the UEFI runtim= e service > + This is the entry point for PcRTC module. It installs the UEFI runtime= service > including GetTime(),SetTime(),GetWakeupTime(),and SetWakeupTime(). > =20 > @param ImageHandle The firmware allocated handle for the EFI imag= e. > @@ -266,9 +266,9 @@ RtcTimeFieldsValid ( > ); > =20 > /** > - Converts time from EFI_TIME format defined by UEFI spec to RTC's. > + Converts time from EFI_TIME format defined by UEFI spec to RTC format. > =20 > - This function converts time from EFI_TIME format defined by UEFI spec = to RTC's. > + This function converts time from EFI_TIME format defined by UEFI spec = to RTC format. > If data mode of RTC is BCD, then converts EFI_TIME to it. > If RTC is in 12-hour format, then converts EFI_TIME to it. > =20 > diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c b/Pc= AtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > index dca3b8d9ff..ccda633137 100644 > --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > @@ -108,7 +108,7 @@ PcRtcEfiSetWakeupTime ( > /** > The user Entry Point for PcRTC module. > =20 > - This is the entrhy point for PcRTC module. It installs the UEFI runtim= e service > + This is the entry point for PcRTC module. It installs the UEFI runtime= service > including GetTime(),SetTime(),GetWakeupTime(),and SetWakeupTime(). > =20 > @param ImageHandle The firmware allocated handle for the EFI imag= e. >=20