From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D0B4678003C for ; Mon, 8 Apr 2024 09:48:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LpLux0opSb4DY2kPBqlzkV+VeUSBJBBI4123Zgxo/1Y=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1712569700; v=1; b=uNI5qtQugLYRjQ4PZk1+A1StEQJUVkXjxy5i6YqfM02plpX+WpEAPTRrIEWNmS3Gr4f1EZ34 euHnlvnCPk76pvog4Am+xf5lV5C/zbWw+Llry5puJA9UVrWFuNP8cSp6iMrZEc6c4dgAt3gIr99 PXZGCCyIQ7oE4PMGlPBsDVgJcA2XGgIN6tuvVGTnPZ+BHauQCEoLYhVz583juryAiFHNA7N4TBG z0k5kdo2v25daSmhL3hbRNt3CPWQHq1lUcHJmc7olq0th6avkwnU5TVaXyAude1OSsmg7luaVi3 mU3Bd+NeMVHJ8ox2uIg5Cgi9R8AHkpmfRmUOwWHhUjQ6Q== X-Received: by 127.0.0.2 with SMTP id l92IYY7687511xqpmNdt5kF6; Mon, 08 Apr 2024 02:48:20 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mx.groups.io with SMTP id smtpd.web11.102702.1712569697803691102 for ; Mon, 08 Apr 2024 02:48:20 -0700 X-CSE-ConnectionGUID: 9e6LLlX+S8u2PSv3GR5BEg== X-CSE-MsgGUID: OwtM6fjxQ428ggkegeK//w== X-IronPort-AV: E=McAfee;i="6600,9927,11037"; a="7704337" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="7704337" X-Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 02:48:20 -0700 X-CSE-ConnectionGUID: VlYmwJNwQJCsgwbZFw1iXw== X-CSE-MsgGUID: Kp/S51RfTSmKnVtB8TtDrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="19700718" X-Received: from qingyush-mobl.ccr.corp.intel.com ([10.238.10.240]) by orviesa010.jf.intel.com with ESMTP; 08 Apr 2024 02:48:19 -0700 From: "Qingyu" To: devel@edk2.groups.io Cc: Marcin Wojtas , Gahan Saraiya Subject: [edk2-devel] [PATCH 3/3] Silicon/Marvell: Update the comments of GetInformation function Date: Mon, 8 Apr 2024 17:47:23 +0800 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 08 Apr 2024 02:48:20 -0700 Resent-From: qingyu.shang@intel.com Reply-To: devel@edk2.groups.io,qingyu.shang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YOn4mphxFOlBJSa9AyVWFip0x7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=uNI5qtQu; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data. Cc: Marcin Wojtas Signed-off-by: Qingyu Signed-off-by: Gahan Saraiya Reviewed-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c index 5e463ac932..c0073daa8e 100644 --- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c +++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c @@ -1384,7 +1384,9 @@ Pp2DxeSnpInstall ( This function returns information of type InformationType from the adapter. If an adapter does not support the requested informational type, then - EFI_UNSUPPORTED is returned. + EFI_UNSUPPORTED is returned. If an adapter does not contain Information for + the requested InformationType, it fills InformationBlockSize with 0 and + returns EFI_NOT_FOUND. @param[in] This A pointer to the EFI_ADAPTER_INFORMATION_PROTOCOL instance. @param[in] InformationType A pointer to an EFI_GUID that defines the contents of InformationBlock. @@ -1394,6 +1396,7 @@ Pp2DxeSnpInstall ( @retval EFI_SUCCESS The InformationType information was retrieved. @retval EFI_UNSUPPORTED The InformationType is not known. + @retval EFI_NOT_FOUND Information is not available for the requested information type. @retval EFI_DEVICE_ERROR The device reported an error. @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources. @retval EFI_INVALID_PARAMETER This is NULL. -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117499): https://edk2.groups.io/g/devel/message/117499 Mute This Topic: https://groups.io/mt/105398063/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-