From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 26 Apr 2019 11:22:35 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA6801244D8; Fri, 26 Apr 2019 18:22:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-104.rdu2.redhat.com [10.10.121.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E9895DED8; Fri, 26 Apr 2019 18:22:31 +0000 (UTC) Subject: Re: [edk2-devel] [edk2] Request to add new edk2-libc repository To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Carsey, Jaben" , "Daryl McDaniel (edk2-lists@mc2research.org)" , "leif.lindholm@linaro.org" , "Andrew Fish (afish@apple.com)" References: <8c6e03ea-a928-48f0-4e4f-3bb021ea6e40@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 26 Apr 2019 20:22:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 26 Apr 2019 18:22:35 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/25/19 22:52, Kinney, Michael D wrote: > SafeIntLib demonstrates a unit test that runs without any > user input and verifies the result of each unit test and > provides test results in a standard format. > > The OrderedCollectionLibTest provides a way for a developer > to manually test that lib class or generate a file from a > Linux specific script with a set of commands to run from > an input file. However, I do not see any functionality in > this test app to verify the results. It appears to depend > on a developer manually inspecting the output. > > Given that OrderedCollectionLibTest appears to be a manual > test requiring interaction, and since effort was made to > implement this interactive utility, I would recommend this > remain in AppPkg in the edk2-libc repo so it is still > available for that use case. OK. > As we enable automated unit tests in edk2, we can implement > a new automated unit test for the OrderedCollectionLib class. > > Please see the following thread and branch for some ideas on > unit tests: > > https://edk2.groups.io/g/devel/message/39439 > > https://github.com/tengfens/edk2-staging/tree/HBFA > > I agree that writing unit tests must be made as simple as > possible for developers to encourage everyone to implement > and submit unit tests for new content. I look forward to > your feedback on that thread. I have to be honest here: I've skimmed the above references, and I won't be able to give them the attention they deserve. :( Thanks, Laszlo