From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4543EAC0DD8 for ; Tue, 16 Jan 2024 06:34:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ui6xRyD0ivmyiiM99lr643t7dkXoko46TePEbnew68E=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705386894; v=1; b=XqqsNc+wjqZJkdOCf+wiEOvj4myD5J/lONIxSj4xWnLFrBpNfVJ+60IHZexo+ZJsW/prsQ6B cIm0Xxj0Th3zrUItBiihjySc/wVreZ4GYHF2judsPgal4myktAe9cDV4uc1h5PK0jFKqysegS/U 3JovkAMqlonOxImtM5ztunxw= X-Received: by 127.0.0.2 with SMTP id gzHmYY7687511xRqrnBYOmny; Mon, 15 Jan 2024 22:34:54 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.73114.1705308493995144200 for ; Mon, 15 Jan 2024 00:48:14 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-RAERjEngOEul-Fh-YCUnOg-1; Mon, 15 Jan 2024 03:48:09 -0500 X-MC-Unique: RAERjEngOEul-Fh-YCUnOg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 228E4185A781; Mon, 15 Jan 2024 08:48:09 +0000 (UTC) X-Received: from [10.39.193.170] (unknown [10.39.193.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 262161C060B2; Mon, 15 Jan 2024 08:48:08 +0000 (UTC) Message-ID: Date: Mon, 15 Jan 2024 09:48:07 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg To: Sunil V L , "Ni, Ray" Cc: "devel@edk2.groups.io" , "lichao@loongson.cn" , "Kinney, Michael D" , Gerd Hoffmann References: From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EVgFEPmxRzn75K4jtAoow7ufx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XqqsNc+w; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/12/24 11:19, Sunil V L wrote: > Hi Ray, >=20 > On Fri, Jan 12, 2024 at 09:12:34AM +0000, Ni, Ray wrote: >> Sunil, >> I would like to hear your feedback regarding locations of following Risc= V64 components in UefiCpuPkg: >> * UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/ >> * UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/ >> * UefiCpuPkg/CpuDxeRiscV64/ >> * UefiCpuPkg/CpuTimerDxeRiscV64/ >> >> I would like to move them to the following new locations accordingly: >> * UefiCpuPkg/Library/CpuExceptionHandlerLib/RiscV64/ >> * UefiCpuPkg/Library/CpuTimerLib/RiscV64/ >> * UefiCpuPkg/CpuDxe/RiscV64/ >> * UefiCpuPkg/CpuTimerDxe/RiscV64/ >> >> >> I want to avoid too many similar drivers in root folder, and too many li= braries in Library folder. >> >> Movement of the first 3 ones put the RiscV components under existing fol= ders. >> Movement of the last one creates the UefiCpuPkg/CpuTimerDxe folder, that= could be potentially shared by other archs as well. >> >> I raised similar comments to Chao Li who is working on LoongArch upstrea= m. >> >> The location movement follows the 2nd pattern defined by edk2 coding sta= ndard: >> Driver's location could be: >> [[]] >> or >> [/[/]] >> >> Library's location could be: >> >> [[]][] >> >> or >> >> []/[[/]] >> >> > Your proposal looks good to me except better to keep directory name as > RiscV as in other packages. no objections from me -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113810): https://edk2.groups.io/g/devel/message/113810 Mute This Topic: https://groups.io/mt/103679850/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-