From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 23 Sep 2019 02:58:45 -0700 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C815E88309 for ; Mon, 23 Sep 2019 09:58:44 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id n6so4601966wrm.20 for ; Mon, 23 Sep 2019 02:58:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4ghFdMnnB1+Aq+um/sRkZbdb4tbB3SwI8CnkTBHwGsE=; b=rO1ORjCCxSitWRiZK/U2duujF2W4V8ne3irAuOWcEjV4JvdoK7yCfdvSWVcsVKHAmT Aj8t2tHI41C1cjAg+FcyO63VXOHiqdk18bmnFbbqupkZqSGVuj0LUmLiMcSul5ESpNWA 4DtLSOW5/kiVb6EQrhrytun+7IzZktEOizRZ2sapVPAa3fCkHPzi9nxmd0G2mBo97SDb Qflw+1NFmF3fXnnr5YBJzck5rxI2dmOr6o2/4etEMJFRhQkgYZcHpJ+cpLNPjQVQlMBg A+rCcEaHe7bi7JM4NBx/VnxWjjYXfdhOv5XDbb7/sl2OOHyJKaUYTS1Mcir7n2ivXW0k 6r6w== X-Gm-Message-State: APjAAAVpu13o5DWneHoO2xD1/IhaB79DEaHjL0w+jAEIjPWZ+6BsQSyS NbmfJ7hCPiDhIr56apsZXRiC8gR77IrvfLOoHeiPHDcXG7yfwsW1jSRhTr8rPoO/E10Ub1wghEr 3ObSJyNoQ/FqOEw== X-Received: by 2002:a1c:a8cb:: with SMTP id r194mr12683471wme.156.1569232723573; Mon, 23 Sep 2019 02:58:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPBTyn8NtbxTP/iElejzTSFak+qVokRMHrG+fSpglboKJlg78XgU1MCbZEhScMtwvoOMe8rg== X-Received: by 2002:a1c:a8cb:: with SMTP id r194mr12683451wme.156.1569232723376; Mon, 23 Sep 2019 02:58:43 -0700 (PDT) Received: from [192.168.1.40] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id i1sm17777623wmb.19.2019.09.23.02.58.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 02:58:42 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE To: devel@edk2.groups.io, lersek@redhat.com Cc: Jaben Carsey , Ray Ni , Zhichao Gao References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-31-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 23 Sep 2019 11:58:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-31-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The TouchFileByHandle() and IsDirectoryEmpty() functions are passed > SHELL_FILE_HANDLE parameters, and they use those parameters correctly. > However, their parameter lists say EFI_HANDLE. > > Spell out the right type in the parameter lists. > > In practice, this change is a no-op (because, quite regrettably, both > EFI_HANDLE and SHELL_FILE_HANDLE are specified to be typedefs of (VOID*)). > > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Laszlo Ersek > --- > > Notes: > tested: rm, touch > > ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 2 +- > ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c > index 3a1196f1529e..59f7eec376f2 100644 > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c > @@ -24,7 +24,7 @@ STATIC CONST SHELL_PARAM_ITEM ParamList[] = { > **/ > BOOLEAN > IsDirectoryEmpty ( > - IN EFI_HANDLE FileHandle > + IN SHELL_FILE_HANDLE FileHandle > ) > { > EFI_STATUS Status; > diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c b/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c > index 0f00344c815e..a215f5774c69 100644 > --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c > +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c > @@ -21,7 +21,7 @@ > **/ > EFI_STATUS > TouchFileByHandle ( > - IN EFI_HANDLE Handle > + IN SHELL_FILE_HANDLE Handle > ) > { > EFI_STATUS Status; > Reviewed-by: Philippe Mathieu-Daude