From: Laszlo Ersek <lersek@redhat.com>
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH] IntelFrameworkModulePkg: Remove redundant definitions and functions
Date: Mon, 6 Aug 2018 15:29:21 +0200 [thread overview]
Message-ID: <aba33218-701b-bbc5-ae20-3f790d3ceaea@redhat.com> (raw)
In-Reply-To: <20180806025401.26344-1-shenglei.zhang@intel.com>
On 08/06/18 04:54, shenglei wrote:
> Some dead code functions and redundant definitions
> have been removed in inf, .c and .h files.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1063
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> .../Bus/Isa/IsaIoDxe/IsaDriver.h | 1 -
> .../Bus/Isa/IsaIoDxe/IsaIoDxe.inf | 1 -
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 18 --
> .../Bus/Pci/IdeBusDxe/Ata.c | 105 ------------
> .../Bus/Pci/IdeBusDxe/DriverConfiguration.c | 156 ------------------
> .../Csm/BiosThunk/Snp16Dxe/PxeUndi.c | 66 +-------
> .../Csm/LegacyBiosDxe/LegacyBiosDxe.inf | 2 -
> .../Csm/LegacyBiosDxe/LegacyBiosInterface.h | 2 -
> .../Universal/BdsDxe/BootMaint/BmLib.c | 24 ---
> .../Universal/BdsDxe/BootMaint/BootOption.c | 52 ------
> .../Universal/BdsDxe/BootMaint/Variable.c | 58 -------
> .../Universal/BdsDxe/FrontPage.c | 18 --
> 12 files changed, 1 insertion(+), 502 deletions(-)
Please split this patch to a series as well (see
<https://lists.01.org/pipermail/edk2-devel/2018-August/028059.html> for
my reasoning).
Thanks
Laszlo
prev parent reply other threads:[~2018-08-06 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 2:54 [PATCH] IntelFrameworkModulePkg: Remove redundant definitions and functions shenglei
2018-08-06 13:29 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aba33218-701b-bbc5-ae20-3f790d3ceaea@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox