From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 0B465210DA78F
 for <edk2-devel@lists.01.org>; Mon,  6 Aug 2018 06:29:24 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 5F12440201A0;
 Mon,  6 Aug 2018 13:29:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-82.rdu2.redhat.com
 [10.10.121.82])
 by smtp.corp.redhat.com (Postfix) with ESMTP id C16A179DE;
 Mon,  6 Aug 2018 13:29:22 +0000 (UTC)
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>
References: <20180806025401.26344-1-shenglei.zhang@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <aba33218-701b-bbc5-ae20-3f790d3ceaea@redhat.com>
Date: Mon, 6 Aug 2018 15:29:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180806025401.26344-1-shenglei.zhang@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.6]); Mon, 06 Aug 2018 13:29:23 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]);
 Mon, 06 Aug 2018 13:29:23 +0000 (UTC) for IP:'10.11.54.5'
 DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH] IntelFrameworkModulePkg: Remove redundant definitions and functions
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2018 13:29:24 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/06/18 04:54, shenglei wrote:
> Some dead code functions and redundant definitions
> have been removed in inf, .c and .h files.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1063
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
>  .../Bus/Isa/IsaIoDxe/IsaDriver.h              |   1 -
>  .../Bus/Isa/IsaIoDxe/IsaIoDxe.inf             |   1 -
>  .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c    |  18 --
>  .../Bus/Pci/IdeBusDxe/Ata.c                   | 105 ------------
>  .../Bus/Pci/IdeBusDxe/DriverConfiguration.c   | 156 ------------------
>  .../Csm/BiosThunk/Snp16Dxe/PxeUndi.c          |  66 +-------
>  .../Csm/LegacyBiosDxe/LegacyBiosDxe.inf       |   2 -
>  .../Csm/LegacyBiosDxe/LegacyBiosInterface.h   |   2 -
>  .../Universal/BdsDxe/BootMaint/BmLib.c        |  24 ---
>  .../Universal/BdsDxe/BootMaint/BootOption.c   |  52 ------
>  .../Universal/BdsDxe/BootMaint/Variable.c     |  58 -------
>  .../Universal/BdsDxe/FrontPage.c              |  18 --
>  12 files changed, 1 insertion(+), 502 deletions(-)

Please split this patch to a series as well (see
<https://lists.01.org/pipermail/edk2-devel/2018-August/028059.html> for
my reasoning).

Thanks
Laszlo