public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [edk2-FdfSpecification PATCH] Amend the OptionROM spec to allow multiple PCI_DEVICE_IDs
Date: Wed, 24 Oct 2018 12:42:17 +0100	[thread overview]
Message-ID: <aba7dd71-a353-61d5-be42-ad0a55e2c47c@solarflare.com> (raw)

The BaseTools are updated to allow multiple PCI_DEVICE_ID fields following
the Device List introduced in the PCI Spec rev 3.0. This commit documents the
amended syntax.

Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 3_edk_ii_fdf_file_format/311_pci_optionrom_section.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
index 08f50e7..046eacf 100644
--- a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
+++ b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md
@@ -58,7 +58,7 @@ Conditional statements may be used anywhere within this section.
 <Overrides>    ::= <MTS> "{" <EOL>
                    [<TS> "PCI_VENDOR_ID" <Eq> <UINT16> <EOL>]
                    [<TS> "PCI_CLASS_CODE" <Eq> <UINT8> <EOL>]
-                   [<TS> "PCI_DEVICE_ID" <Eq> <UINT16> <EOL>]
+                   [<TS> "PCI_DEVICE_ID" <Eq> <UINT16>+ <EOL>]
                    [<TS> "PCI_REVISION" <Eq> <UINT8> <EOL>]
                    [<TS> "PCI_COMPRESS" <Eq> <TrueFalse> <EOL>]
                    <TS> "}" <EOL>
@@ -108,6 +108,7 @@ for the .efi extension in the ENBF above.
 [OptionRom.AtapiPassThru]
   INF USE = IA32 OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf {
     PCI_REVISION = 0x0020
+    PCI_DEVICE_ID = 0x0A03 0x0B03
   }
   INF USE = EBC OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf
 ```
-- 
2.17.2



                 reply	other threads:[~2018-10-24 11:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aba7dd71-a353-61d5-be42-ad0a55e2c47c@solarflare.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox