* [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: @ 2022-09-06 16:55 Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron ` (3 more replies) 0 siblings, 4 replies; 7+ messages in thread From: Benjamin Doron @ 2022-09-06 16:55 UTC (permalink / raw) To: devel BoardAcpiDxe is derived from AcpiPlatformDxe, but only the silicon/platform DSDT is installed. However, boards can have tables that must be installed too. For instance, laptops often have an EC ACPI device. Therefore, implement support for installing the generic PcdAcpiTableStorageFile too. Tested with KabylakeOpenBoardPkg, the Aspire VN7-572G's BoardAcpiTables are successfully installed. Benjamin Doron (4): KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ .../Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 10 ++++++++++ .../Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 3 +++ .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 8 files changed, 61 insertions(+), 3 deletions(-) -- 2.37.2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [edk2-devel][edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile 2022-09-06 16:55 [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: Benjamin Doron @ 2022-09-06 16:55 ` Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron ` (2 subsequent siblings) 3 siblings, 0 replies; 7+ messages in thread From: Benjamin Doron @ 2022-09-06 16:55 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c index 0361ffc2fbf9..c6df1714af9a 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c @@ -288,7 +288,20 @@ InstallAcpiBoard ( // // Platform ACPI Tables // - PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status)); + } + Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } // // This protocol publish must be done after PublishAcpiTablesFromFv. diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf index 5d3d4c3a2b33..7b400cf967f3 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf @@ -67,6 +67,8 @@ gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND -- 2.37.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile 2022-09-06 16:55 [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron @ 2022-09-06 16:55 ` Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron 3 siblings, 0 replies; 7+ messages in thread From: Benjamin Doron @ 2022-09-06 16:55 UTC (permalink / raw) To: devel Cc: Chasel Chiu, Nate DeSimone, Rangasai V Chaganty, Deepika Kethi Reddy, Kathappan Esakkithevar Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c index 7fc71bca644a..ba59c84fd4ba 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c +++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c @@ -270,7 +270,20 @@ InstallAcpiBoard ( // // Platform ACPI Tables // - PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status)); + } + Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } // // This protocol publish must be done after PublishAcpiTablesFromFv. diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf index 09b67376fbc1..e201964a6896 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf +++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf @@ -62,6 +62,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND -- 2.37.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-devel][edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile 2022-09-06 16:55 [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron @ 2022-09-06 16:55 ` Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron 3 siblings, 0 replies; 7+ messages in thread From: Benjamin Doron @ 2022-09-06 16:55 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 10 ++++++++++ Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 3 +++ 2 files changed, 13 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc222453857..ac343afca7d4 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -227,6 +227,16 @@ InstallMinDsdt ( Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ERROR (Status); + Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } return EFI_SUCCESS; } diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf index 3437bc489cd3..dc32186eb361 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -21,6 +21,7 @@ [Packages] MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec MinPlatformPkg/MinPlatformPkg.dec [LibraryClasses] @@ -41,6 +42,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid -- 2.37.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-devel][edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile 2022-09-06 16:55 [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: Benjamin Doron ` (2 preceding siblings ...) 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron @ 2022-09-06 16:55 ` Benjamin Doron 3 siblings, 0 replies; 7+ messages in thread From: Benjamin Doron @ 2022-09-06 16:55 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c index cb5f328a3909..c8c1e0cc2cf2 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c @@ -270,7 +270,20 @@ InstallAcpiBoard ( // // Platform ACPI Tables // - PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status)); + } + Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } // // This protocol publish must be done after PublishAcpiTablesFromFv. diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf index af5c8f1c0609..f17fb588ddb8 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf @@ -60,6 +60,8 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND -- 2.37.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile @ 2021-08-04 19:58 Benjamin Doron 2021-08-04 19:58 ` [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron 0 siblings, 1 reply; 7+ messages in thread From: Benjamin Doron @ 2021-08-04 19:58 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 1 + Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c index 0361ffc2fbf9..fd227d9b410e 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c @@ -289,6 +289,7 @@ InstallAcpiBoard ( // Platform ACPI Tables // PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); // // This protocol publish must be done after PublishAcpiTablesFromFv. diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf index 7d2e105e5447..4d7f5cdb3eeb 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf @@ -59,6 +59,8 @@ gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND -- 2.31.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile 2021-08-04 19:58 [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: " Benjamin Doron @ 2021-08-04 19:58 ` Benjamin Doron 2021-08-13 7:04 ` [edk2-devel] " Nate DeSimone 2021-08-26 2:52 ` Nate DeSimone 0 siblings, 2 replies; 7+ messages in thread From: Benjamin Doron @ 2021-08-04 19:58 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc222453857..417cccc18b5a 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -227,6 +227,7 @@ InstallMinDsdt ( Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ERROR (Status); + PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); return EFI_SUCCESS; } diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf index 3437bc489cd3..3e14c4e9a65d 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -41,6 +41,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid -- 2.31.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile 2021-08-04 19:58 ` [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron @ 2021-08-13 7:04 ` Nate DeSimone 2021-08-26 2:52 ` Nate DeSimone 1 sibling, 0 replies; 7+ messages in thread From: Nate DeSimone @ 2021-08-13 7:04 UTC (permalink / raw) To: devel@edk2.groups.io, benjamin.doron00@gmail.com Cc: Chiu, Chasel, Liming Gao, Dong, Eric Hi Benjamin, It would be good to add a check on the status code returned from PublishAcpiTablesFromFv() to the debug log. Something like this: Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status)); } Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); if (EFI_ERROR (Status)) { DEBUG (( DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", PcdGetPtr (PcdAcpiTableStorageFile), Status )); } I know the original code doesn't do it, but I imagine this will be helpful to some poor soul who is trying to debug issues with this later on. Thanks, Nate -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron Sent: Wednesday, August 4, 2021 12:59 PM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc222453857..417cccc18b5a 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -227,6 +227,7 @@ InstallMinDsdt ( Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ERROR (Status);+ PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); return EFI_SUCCESS; }diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf index 3437bc489cd3..3e14c4e9a65d 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -41,6 +41,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile+ [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid-- 2.31.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78665): https://edk2.groups.io/g/devel/message/78665 Mute This Topic: https://groups.io/mt/84670596/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@intel.com] -=-=-=-=-=-= ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile 2021-08-04 19:58 ` [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron 2021-08-13 7:04 ` [edk2-devel] " Nate DeSimone @ 2021-08-26 2:52 ` Nate DeSimone 1 sibling, 0 replies; 7+ messages in thread From: Nate DeSimone @ 2021-08-26 2:52 UTC (permalink / raw) To: devel@edk2.groups.io, benjamin.doron00@gmail.com Cc: Chiu, Chasel, Liming Gao, Dong, Eric Hi Benjamin, This is a compilation error in this patch. You have added the usage of gEfiMdeModulePkgTokenSpaceGuid to MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf but that GUID technically does not exist when this .inf is being compiled since the .inf only references the following DEC files: MdePkg/MdePkg.dec MinPlatformPkg/MinPlatformPkg.dec You need to add MdeModulePkg/MdeModulePkg.dec I suspect you missed this error because all the currently existing OpenBoardPkgs do not use MinDsdt thus far. Thanks, Nate -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron Sent: Wednesday, August 4, 2021 12:59 PM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc222453857..417cccc18b5a 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -227,6 +227,7 @@ InstallMinDsdt ( Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ERROR (Status);+ PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); return EFI_SUCCESS; }diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf index 3437bc489cd3..3e14c4e9a65d 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -41,6 +41,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile+ [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid-- 2.31.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78665): https://edk2.groups.io/g/devel/message/78665 Mute This Topic: https://groups.io/mt/84670596/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@intel.com] -=-=-=-=-=-= ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-06 16:56 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-06 16:55 [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron 2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron -- strict thread matches above, loose matches on Subject: below -- 2021-08-04 19:58 [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: " Benjamin Doron 2021-08-04 19:58 ` [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron 2021-08-13 7:04 ` [edk2-devel] " Nate DeSimone 2021-08-26 2:52 ` Nate DeSimone
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox