Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX=

["Rebecca Cran" <rebecca@bsdio.com>]

Sorry, I don't think I saw a suggestion from you to not set CC - though 
I may have missed emails since this patch series was sent from the email 
of my former employer.

Marvin did suggest that though, so I can certainly add another patch to 
the series to do that.


-- 

Rebecca Cran


On 3/20/23 3:35 AM, Gerd Hoffmann wrote:
> On Fri, Mar 17, 2023 at 04:43:24AM -0600, Rebecca Cran wrote:
>> On 3/15/23 4:07 AM, Gerd Hoffmann wrote:
>>>> Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC
>>>> and BUILD_CXX) and using the standard name 'LDFLAGS' instead of
>>>> 'LFLAGS'. This allows clang to be used by running
>>>> 'make -C BaseTools CC=clang CXX=clang++'.
>>> Hmm, not sure this is a good idea.  I suspect there was some reason to
>>> use BUILD_CC instead of CC in the first place ...
>> It looks like the change to use BUILD_CC was introduced by Liming in:
>>
>>
>>      BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_
>> prefix
>>
>>      To avoid the conflict with the default GCC flag name, BUILD_ prefix is
>> added.
>>
>>      Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
>>      Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>>      Contributed-under: TianoCore Contribution Agreement 1.0
>>      Signed-off-by: Liming Gao <liming.gao@intel.com>
>>      Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
>>      Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
>>
>>
>> I don't understand how that would help, and I'm wondering if it was perhaps
>> the result of a misunderstanding.
> Hmm, neither the commit message nor the patch itself have any hints of
> actual problems fixed.  The "conflict" notion indeed hints this might
> have been a misunderstanding.
>
> So, going back to just use CC + CFLAGS + friends looks fine to me.
>
> The suggestion to simply not set CC stands stands.
>
> take care,
>    Gerd
>