From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web11.13532.1679318006169983423 for ; Mon, 20 Mar 2023 06:13:26 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=M0BB4qUP; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5EA9B5C0117; Mon, 20 Mar 2023 09:13:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 20 Mar 2023 09:13:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679318005; x=1679404405; bh=QDznM6W1hvH9fFwmL/Bwasz/+yssu/UI2x+ VOclWULA=; b=M0BB4qUP7IHUiKnI89h2qJ5s7TRPmARcH8eG7blhO9Er/Z+d51/ enH3DVo3k41BzhwRJ25YCX7U0U6uvmbjYCGzLAo6o4qsrqygpvAdWW5O6gwTVJZ7 jXrnMvUQUyNfGBsNIDZSggxz72NnGkIq4aVa88xupsVYtQqxh0riXkyEWt1qyzhO F1704kQwv/uuRxRAw1myJvFrBymbgRRyAwOQZ6oamndkQ+4N3oS9rXwlySOcxNsi o9w8Mx5ehF82wJ/RIGMgiK1o/ga4nQhCoiIyVnzp6j9pFYZlT/qV8HCwPy+/jUsr 7yfBlqGnTWx2KfHSaf9Y2FFq5mkOwcUc2ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679318005; x=1679404405; bh=QDznM6W1hvH9fFwmL/Bwasz/+yssu/UI2x+ VOclWULA=; b=RI1WrhDQ6IPqzvDon0AhEjyXJFH0F6enwzl3AI8Arm+hKAfK13b dFgR5tuR+HuW6m+NVcqy2oyzusywrdrDblvgteJPiT0GnJh6SZbyinOQo3BMeJwt dBWvpK4GT5zp5u1bzMOWe4ofKsAdVTa8Af/8rVr0htQFzScvn9rAU8pVV5Nxo58Z E7LacdKixJFyilvV9UubGAcn3UpQ1OYeVbibXkxHX7g5MIzz11gBDbtGnPG7jHjs 6Fk34CI+dsqGkk0DGLmXEjGJ5Q1bVmLM+ZdjvTrk2JP6TPD3UwchqIYabHjqzY5L lIgok3CGKffrCrq4tLDNgFrrLvztq1NcDtw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefkedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegfeegveduheejgfduffefhfehleehiefghfetvdejvdelhfeukefhhfdv geehveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Mar 2023 09:13:23 -0400 (EDT) Message-ID: Date: Mon, 20 Mar 2023 07:13:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX= To: Gerd Hoffmann Cc: devel@edk2.groups.io, Andrew Fish , Leif Lindholm , Michael D Kinney , Bob Feng , Liming Gao , Yuwei Chen References: <20230217035101.880854-1-rebecca@quicinc.com> <20230217035101.880854-2-rebecca@quicinc.com> <20230315100742.umho6xek26kv5t6i@sirius.home.kraxel.org> <602780c3-7915-2fb0-177c-9d6dacad22a3@bsdio.com> <20230320093504.fgwcnencpk7a6ehx@sirius.home.kraxel.org> From: "Rebecca Cran" In-Reply-To: <20230320093504.fgwcnencpk7a6ehx@sirius.home.kraxel.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sorry, I don't think I saw a suggestion from you to not set CC - though I may have missed emails since this patch series was sent from the email of my former employer. Marvin did suggest that though, so I can certainly add another patch to the series to do that. -- Rebecca Cran On 3/20/23 3:35 AM, Gerd Hoffmann wrote: > On Fri, Mar 17, 2023 at 04:43:24AM -0600, Rebecca Cran wrote: >> On 3/15/23 4:07 AM, Gerd Hoffmann wrote: >>>> Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC >>>> and BUILD_CXX) and using the standard name 'LDFLAGS' instead of >>>> 'LFLAGS'. This allows clang to be used by running >>>> 'make -C BaseTools CC=clang CXX=clang++'. >>> Hmm, not sure this is a good idea. I suspect there was some reason to >>> use BUILD_CC instead of CC in the first place ... >> It looks like the change to use BUILD_CC was introduced by Liming in: >> >> >>     BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ >> prefix >> >>     To avoid the conflict with the default GCC flag name, BUILD_ prefix is >> added. >> >>     Cc: Giri P Mudusuru >>     Cc: Yonghong Zhu >>     Contributed-under: TianoCore Contribution Agreement 1.0 >>     Signed-off-by: Liming Gao >>     Reviewed-by: Yonghong Zhu >>     Reviewed-by: Giri P Mudusuru >> >> >> I don't understand how that would help, and I'm wondering if it was perhaps >> the result of a misunderstanding. > Hmm, neither the commit message nor the patch itself have any hints of > actual problems fixed. The "conflict" notion indeed hints this might > have been a misunderstanding. > > So, going back to just use CC + CFLAGS + friends looks fine to me. > > The suggestion to simply not set CC stands stands. > > take care, > Gerd >