From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5629422492738 for ; Fri, 2 Mar 2018 02:45:34 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2B7908182D0C; Fri, 2 Mar 2018 10:51:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-104.rdu2.redhat.com [10.10.120.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 275FF10FFE6B; Fri, 2 Mar 2018 10:51:40 +0000 (UTC) To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: edk2-devel@lists.01.org, Peter Jones , Jiewen Yao , QEMU , Javier Martinez Canillas References: <20180223132311.26555-1-marcandre.lureau@redhat.com> <20180223132311.26555-5-marcandre.lureau@redhat.com> From: Laszlo Ersek Message-ID: Date: Fri, 2 Mar 2018 11:51:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 02 Mar 2018 10:51:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 02 Mar 2018 10:51:43 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 4/7] ovmf: link with Tcg2Pei module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 10:45:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/01/18 16:08, Marc-André Lureau wrote: > Hi > > On Mon, Feb 26, 2018 at 10:38 AM, Laszlo Ersek wrote: >> On 02/23/18 14:23, marcandre.lureau@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> This module will initialize TPM device, measure reported FVs and BIOS >>> version. >>> >>> CC: Laszlo Ersek >>> CC: Stefan Berger >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Marc-André Lureau >>> --- >>> OvmfPkg/OvmfPkgX64.dsc | 7 +++++++ >>> OvmfPkg/OvmfPkgX64.fdf | 1 + >>> 2 files changed, 8 insertions(+) >>> >>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >>> index b5cbe8430f..34a7c2778e 100644 >>> --- a/OvmfPkg/OvmfPkgX64.dsc >>> +++ b/OvmfPkg/OvmfPkgX64.dsc >>> @@ -279,6 +279,8 @@ >>> PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf >>> QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf >>> !if $(TPM2_ENABLE) >>> + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf >>> + HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf >>> Tpm12DeviceLib|SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12DeviceLibDTpm.inf >>> Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf >>> !endif >>> @@ -647,6 +649,11 @@ >>> >>> !if $(TPM2_ENABLE) == TRUE >>> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf >>> + SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf { >>> + >>> + NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf >>> + NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf >>> + } >>> !endif >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf >>> index dc35d0a1f7..9558142a42 100644 >>> --- a/OvmfPkg/OvmfPkgX64.fdf >>> +++ b/OvmfPkg/OvmfPkgX64.fdf >>> @@ -170,6 +170,7 @@ INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf >>> !endif >>> !if $(TPM2_ENABLE) == TRUE >>> INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf >>> +INF SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >>> !endif >>> >>> ################################################################################ >>> >> >> Would it be possible to drop SHA1 (include SHA256 only) by setting >> PcdTpm2HashMask to value 2? Or SHA1 required for some other reason? (If >> so please mention it in the commit message.) >> > > afaik, it's not strictly required, and apparently the support is being > dropped. I'll remove it. > > btw, now I understand your comment about read-only variable not being > used by PEI module. I'll add a preliminary patch dropping it from > depex ;) OK, thanks :) Laszlo