From: boonewang@zhaoxin.com
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "dandan.bi@intel.com" <dandan.bi@intel.com>
Subject: Re: [edk2] [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table
Date: Tue, 28 Apr 2020 09:48:52 +0000 [thread overview]
Message-ID: <abc26c8d51d9452bbdaa576942b8947f@zhaoxin.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
Hi,
I have seen an email named " [edk2] [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table " in mail-archive" and I know there is an update of Dp.
But I feel uncertain that:
- // Determine in which direction the performance counter counts.
- TimerInfo.CountUp = (BOOLEAN) (TimerInfo.EndCount >= TimerInfo.StartCount);
+ TimerInfo.StartCount = 0;
+ TimerInfo.EndCount = 0xFFFF;
+ TimerInfo.CountUp = TRUE;
So it looks like we would not use timer count down feature, does it mean we should use count up timer such as TSC or ACPI Timer? Maybe is there any other cause?
Best Regards!
Boone Wang
?????
?????????????????????????????????????????????????????
CONFIDENTIAL NOTE:
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.
[-- Attachment #2: Type: text/html, Size: 5118 bytes --]
reply other threads:[~2020-04-28 9:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc26c8d51d9452bbdaa576942b8947f@zhaoxin.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox