Re: [edk2] [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table

Re: [edk2] [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table

[boonewang]

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

Hi,
I have seen an email named " [edk2] [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table " in mail-archive" and I know there is an update of Dp.
But I feel uncertain that:

-  // Determine in which direction the performance counter counts.

-  TimerInfo.CountUp = (BOOLEAN) (TimerInfo.EndCount >= TimerInfo.StartCount);

+  TimerInfo.StartCount = 0;

+  TimerInfo.EndCount   = 0xFFFF;

+  TimerInfo.CountUp = TRUE;
So it looks like we would not use timer count down feature, does it mean we should use count up timer such as TSC or ACPI Timer? Maybe is there any other cause?


Best Regards!
Boone Wang



?????
?????????????????????????????????????????????????????
CONFIDENTIAL NOTE:
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.

[-- Attachment #2: Type: text/html, Size: 5118 bytes --]