From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from blyat.fensystems.co.uk (blyat.fensystems.co.uk [54.246.183.96])
 by mx.groups.io with SMTP id smtpd.web12.11045.1636458987736426619
 for <devel@edk2.groups.io>;
 Tue, 09 Nov 2021 03:56:29 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: ipxe.org, ip: 54.246.183.96, mailfrom: mcb30@ipxe.org)
Received: from pudding.home (unknown [188.94.42.109])
	by blyat.fensystems.co.uk (Postfix) with ESMTPSA id 0C83444AB3;
	Tue,  9 Nov 2021 11:56:23 +0000 (UTC)
Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?
To: devel@edk2.groups.io, kraxel@redhat.com, michael.d.kinney@intel.com
Cc: Andrew Fish <afish@apple.com>, =?UTF-8?Q?Marvin_H=c3=a4user?=
 <mhaeuser@posteo.de>, Michael Kubacki <Michael.Kubacki@microsoft.com>,
 Leif Lindholm <leif@nuviainc.com>,
 "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
 "rebecca@nuviainc.com" <rebecca@nuviainc.com>,
 Bret Barkelew <Bret.Barkelew@microsoft.com>
References: <07a6ecff-f7bf-083a-f24d-246ca6c7988b@nuviainc.com>
 <2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de>
 <9fe0f984-db9d-9aec-0b44-5d30791a2855@linux.microsoft.com>
 <20211007104813.wa4rmfsqgcpvnzwt@leviathan>
 <07d5c8bc-40b2-4e99-3b3d-4c8ac4e14220@posteo.de>
 <CO1PR11MB492970504D18B3045CA24974D2B19@CO1PR11MB4929.namprd11.prod.outlook.com>
 <438B4D66-2CFB-45E3-AF75-42342F0B1E67@apple.com>
 <e6010420-ae82-942f-e4c7-03f129f56b5d@posteo.de>
 <AB3E469F-C0D5-47DF-98FF-80D6042E86C2@apple.com>
 <CO1PR11MB49293E3C6AE64B5C02BB4963D2929@CO1PR11MB4929.namprd11.prod.outlook.com>
 <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org>
From: "Michael Brown" <mcb30@ipxe.org>
Message-ID: <abcf20e8-aca4-78db-af6e-b482ae450768@ipxe.org>
Date: Tue, 9 Nov 2021 11:56:22 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org>
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
	autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	blyat.fensystems.co.uk
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 09/11/2021 08:40, Gerd Hoffmann wrote:
>>    3.  Require use of uncrustify tool before submitting patch review emails or PRs.
>>       *   The required version would be a formally released version  from the fork maintained by Michael Kubacki until the changes can be upstreamed.
>>       *   https://dev.azure.com/projectmu/Uncrustify
> 
> Can we please *first* get the changes merged to upstream uncrustify?
> 
> That'll make the whole process much less painful because the usual
> software repositories (linux distro packages, macos homebrew, ...)
> can be used to install uncrustify then, and it's also less confusing if
> developers don't have to juggle with different uncrustify variants
> (upstream vs. edk2).

I very strongly agree with this.  It's always a bad sign when a project 
requires installation of a custom version of a widely used tool.

Michael