Re: [PATCH 01/14] DynamicTablesPkg: Use correct print formatter

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Pierre,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> In C, the 'long long' types are 64-bits. The 'll' printf length
> specifier should be used to pring these values. Just '%x' allows to
> print values that are on 16-bits or more. Use that instead.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   .../ConfigurationManagerObjectParser.c             | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> index 08b4f60dfbae..13e6c0e321c4 100644
> --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> @@ -1,7 +1,7 @@
>   /** @file
>     Configuration Manager Object parser.
>   
> -  Copyright (c) 2021, ARM Limited. All rights reserved.<BR>
> +  Copyright (c) 2021 - 2022, ARM Limited. All rights reserved.<BR>
>     SPDX-License-Identifier: BSD-2-Clause-Patent
>   
>   **/
> @@ -384,12 +384,12 @@ STATIC CONST CM_OBJ_PARSER  AcpiGenericAddressParser[] = {
>   /** A parser for EArmObjLpiInfo.
>   */
>   STATIC CONST CM_OBJ_PARSER  CmArmLpiInfoParser[] = {
> -  { "MinResidency",             4,                                               "0x%llx", NULL },
> -  { "WorstCaseWakeLatency",     4,                                               "0x%llx", NULL },
> -  { "Flags",                    4,                                               "0x%llx", NULL },
> -  { "ArchFlags",                4,                                               "0x%llx", NULL },
> -  { "ResCntFreq",               4,                                               "0x%llx", NULL },
> -  { "EnableParentState",        4,                                               "0x%llx", NULL },
> +  { "MinResidency",             4,                                               "0x%x",   NULL },
> +  { "WorstCaseWakeLatency",     4,                                               "0x%x",   NULL },
> +  { "Flags",                    4,                                               "0x%x",   NULL },
> +  { "ArchFlags",                4,                                               "0x%x",   NULL },
> +  { "ResCntFreq",               4,                                               "0x%x",   NULL },
> +  { "EnableParentState",        4,                                               "0x%x",   NULL },
>     { "IsInteger",                1,                                               "%d",     NULL },
>     { "IntegerEntryMethod",       8,                                               "0x%llx", NULL },
>     { "RegisterEntryMethod",      sizeof (EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE),