From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.85]) by mx.groups.io with SMTP id smtpd.web10.6952.1666787796282122755 for ; Wed, 26 Oct 2022 05:36:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=H6fgzjTg; spf=pass (domain: arm.com, ip: 40.107.21.85, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nNVDEq51qscBSHPN/su4R+TyIY4b2Y9wOKy4Tp94bIwqBkxXo+mVGGswij2QjEJCl+YmachlanGvsDRBhINDRrnWLvYuWelbpCcTGq06PjM/EyJ4G4iVVEbNl9b0JNT9AnS13Ext0vGhruFk/Jq1T1VJYlw/2f35Ajl2b6bETB3vtQzVwGvUoA+bPgR5KAAai3nvtOc5RlbNokxf6xU2N/Q17YK3bPbeSQxm8qIBi8BQJXgsGwJMacK4bP5DfEfRCgfq79H3SYKwk8uPyzAQh0tJihGlwihrfkJQzq41wo+AJOB0uHqm8XV3KQ2bXgtiG2/GcTgzz+m9CkSzTkrQaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=46iNK6dME9kxdvCo8SemsYqTq/hR7VhBHmhZHF28zKA=; b=jTePBhqU5dSRd/tnE8yYwO8QfJpE8NiLJrzTycoiny35eW7NPT79Dg41JBq1L6lTQby6oslvTQn3/s7/lEm92FYrd0mJv2xXtPfzwdKjRYo5jLcP+OCFbgqYuJD1c4fL33QglgdW0UVGD4Jy4PQsV11gnGqZS9UrlgUUxaMx7WMbMMGjdyBZitHRAhfJWjVRZwEna4QJjLdk4y2cFbjxQURn9uuEkFlyW7w9I/ZFZCOd5R3mnStIk5qt7pnI5omXNkJityKMKrwPPQGs23CCoV6p51Fs0xru7uHRP5pf+gBkP7zQFinXtySoXTx+SIqLipybFst+lIwCwtsx6Pl/Ng== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46iNK6dME9kxdvCo8SemsYqTq/hR7VhBHmhZHF28zKA=; b=H6fgzjTgF/5Z9CANM2cpLPbZGjuowlKfN1KRCYtugCzpW+bSDYh7KBcDqKEV+7wSQOY/sbCtdOkz/IuKc9RHdiQr9yMYWR6HSJKuevu98IuV1LvYgkBxkdeNquqXNIP5RyQg2t9yQ58ZqyA1ofPA5ZFT6hcoiI/peocNP5aVa2s= Received: from DUZPR01CA0037.eurprd01.prod.exchangelabs.com (2603:10a6:10:468::15) by GV1PR08MB8473.eurprd08.prod.outlook.com (2603:10a6:150:81::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct 2022 12:36:28 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:468:cafe::77) by DUZPR01CA0037.outlook.office365.com (2603:10a6:10:468::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend Transport; Wed, 26 Oct 2022 12:36:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.20 via Frontend Transport; Wed, 26 Oct 2022 12:36:28 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 26 Oct 2022 12:36:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0edecac12ebf6fec X-CR-MTA-TID: 64aa7808 Received: from 10cc8c25ed02.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0270F45E-E681-4CB5-B625-AD90D8BA6CB2.1; Wed, 26 Oct 2022 12:36:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 10cc8c25ed02.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:36:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KOdCjUxth3VHojcJ1wk6GEz1OyM37apgp2f14vUL377TJNWicMJjSxPKf954IrxE2IDIqTeGmKvL6HZdeTfHc3QdxQVYjGcnKzREqu8xnpYIGvqdsPJYaBmZnM2ChRt7wx4lkXyBfL4/w25SyQtLJEafWo3QH7PeDjGbd4im8luBo1px4QIsQS1ecJeoptKme/Flueq6UcC6k6Aj7XijYcL9rrkB16cJzMIr0j0SZZCYgfK+B4BcHybTDQ89i7W7ie7w5ywfBsfxY/yWL/GSrFKdXS2QUqTYFbooWjugJ4dfwCgaEcjN2pMZINMEsEzwH26QG90i8oYWGkdJuUFuqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=46iNK6dME9kxdvCo8SemsYqTq/hR7VhBHmhZHF28zKA=; b=ilXzY6h+Zi6JHqbXgohJXuDI2ONF28473WVVRuxTFdOaSvYnpd62N1CRqcc/Y9ta1y93LvGogKTdeoEtnQ6uoOxm+eRGcynoLnFnd520Kcp+HX3wXSdz3jwfXN3CNI4QWUUMo4gSzbbRVDgaVqB8DBm4o8o9WtMkRv94xOutHm564CLGJKxf3bCZhbMrhxQYRnso/w9f8KqCjaDxz7KFEmtzpqNckfw5ifh3oIUMXHb6J+vxs2h/gZbawFlHtWFYlkV9xF7urBZUE+bvXEUAxaNf4IfpJluL4zIRH2W2LcsAp3oNK3P78wAbfSigOib325KN1cUcJXqTUNHEmB31FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46iNK6dME9kxdvCo8SemsYqTq/hR7VhBHmhZHF28zKA=; b=H6fgzjTgF/5Z9CANM2cpLPbZGjuowlKfN1KRCYtugCzpW+bSDYh7KBcDqKEV+7wSQOY/sbCtdOkz/IuKc9RHdiQr9yMYWR6HSJKuevu98IuV1LvYgkBxkdeNquqXNIP5RyQg2t9yQ58ZqyA1ofPA5ZFT6hcoiI/peocNP5aVa2s= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB6398.eurprd08.prod.outlook.com (2603:10a6:102:12d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:36:17 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:36:17 +0000 Message-ID: Date: Wed, 26 Oct 2022 13:36:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 01/14] DynamicTablesPkg: Use correct print formatter To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-2-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-2-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P265CA0276.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::24) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAXPR08MB6398:EE_|DBAEUR03FT046:EE_|GV1PR08MB8473:EE_ X-MS-Office365-Filtering-Correlation-Id: 8610c7a3-a497-48b6-7cc5-08dab74eb42f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TOTmGKHN+W6XLfJBurScnPAJr7phRXewTOPdbNv1nhFMcMJ/GV1ycBjIGcGoWzphoJE9KgkF00d084iznNuaWbvV6vdfqL4ULuvUv4kHv9DW+OrNetsLS06Xftbde2QfHhnKLD7+AyNNwVVZYEjZS6nOWhJRvMDn3kUD4e4k0gTnmtyTtfGeG8krExRGLGXqCSXyoz2NB2PqZCU4uqW8rf6+QOyjxoe5rC3lh9e/itrakzsUwB1+mZdwh4t5Nu+ciTiVkMZ67OuinCxrckPN5JoAr5Bj0lAF/rLhRVzzg8bAc8BiWemt8SqKCtDwEwnCU/4rdBTNw+8JYcWGuUoDswLjQaEQTjsMM/PdSWlHhF/O4u8g/qaheEw6ed1t9uPfgF0lNksmgzx5pb6TrA48rX3X60Q+/LUw3GIOdbej3VJ/4ddoqX6zoxKD8Jp9RRqBzfKrOkJDvaRm/cdDwXJqwToS43jRxq/GuVnBTfewvH7BPApamZpbADqZor3uCJChGCe62IM4fSPcpbkQmf71JhUdl4gMzEXPr3IxfHODNbESodW4sP9fHAE4OJ/Ym8n1RT/+P9ug47pbI6gd0P4hHl4+RM6kHA0SrKztehqiTX/VKAulG3m6H9aereD5uwvUiHRvYiS2HhcTl2KLCVWLRudKKUdacN5SRl9rp88MaFQ9QjYIjfsf+PdzGTvpkiOyXgkbSceILVSA1pwH7lMlVw9H+lB2wi4muePU9HwWdg3YfG6yJ9sNDb8hF0gRHJm/P2N8jJ0Xlb1n0PggFdiEbt1/HJbp53mxRfL13DYHN4E= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(83380400001)(66556008)(86362001)(38100700002)(31696002)(66476007)(8936002)(66946007)(5660300002)(44832011)(8676002)(6506007)(4326008)(41300700001)(2906002)(53546011)(6486002)(36756003)(26005)(2616005)(6512007)(54906003)(316002)(478600001)(31686004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6398 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5bfede33-b49a-4f13-6630-08dab74eadad X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2pQ8PduCKuJ0Di/A6vOnpb+QSzG+qCcw5uJBoii5zvxpV8/BC+n2tsc9ZY1u6jeAzIZlpghdDABRRnu2HwvYUun2iQdZFC3MpM+f2h++NDyYJrAoHX315eO8aMijoFKfkeY1gvWrzGO0knUgK4kHyadQtZGOTZamffe2AEkSrW0Re5HSxu8RCDKJfdC9gW/n8dzhJxAudMm1NMT+jl5CW5judUSIdd5xFqjnLyhJ0zna3j+d3CtsToZTMzQ2jyxkuOyRCW8xdddLbsATDaHF/5vJOS4Iwsd5pYPbBXgf/2l8ehd9ZHP+wDS+u+ZLnxwfB/t7tMOCJusUBlEyeCRGeZvl4xq2DC1xhfhToyHjtXGQ24MOEVwnI9eaUF7Q+bXNkY5AZkBqZSz6VWAtwOn/EcMpoyv/YrwoMAmY8Zmu5yq4zbmcF4UIGgSMwX5bF7VFgFBhpxWj1mfCwG9snHpmmPn3fPq3y1EJD6mBv8p3/ml0DBJ3eIH9RH6sEXgSYkHVz3TIlnCKRU9LHCa1gA9joNWJecDSgKfNblvh7wxLLbzCdakNhS9pxSRD2VKooaEjgLmkOGfxF2NpLFgfb9OhgLCO9pMBdHo1YEtgNHZQ4gGoF7PXBWsbavuyMdg9jIeEq0wFwCoj5RG5EOpTMUCx80RWOVwUYN2O83q1KHV+i09Br7UOlwY96IeU/AzcUSzlJXDD3bSxhyP25wdaWSuQ0EkB/83ktH5y6zV8AbMdNeGdc66LjvI6tbf/86oa3OA0pqRNi570mXccYxC1R/kn2ow4qeo6paiFnqZ+r2+azg0AQtCO7aaTZShH4+XAVvvw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(396003)(376002)(451199015)(36840700001)(46966006)(40470700004)(40480700001)(316002)(5660300002)(356005)(54906003)(82740400003)(53546011)(8676002)(6506007)(70206006)(70586007)(4326008)(8936002)(81166007)(26005)(6512007)(86362001)(47076005)(31696002)(186003)(41300700001)(2616005)(83380400001)(336012)(478600001)(36860700001)(40460700003)(6486002)(82310400005)(36756003)(44832011)(2906002)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:36:28.4533 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8610c7a3-a497-48b6-7cc5-08dab74eb42f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8473 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > In C, the 'long long' types are 64-bits. The 'll' printf length > specifier should be used to pring these values. Just '%x' allows to > print values that are on 16-bits or more. Use that instead. > > Signed-off-by: Pierre Gondois > --- > .../ConfigurationManagerObjectParser.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > index 08b4f60dfbae..13e6c0e321c4 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > @@ -1,7 +1,7 @@ > /** @file > Configuration Manager Object parser. > > - Copyright (c) 2021, ARM Limited. All rights reserved.
> + Copyright (c) 2021 - 2022, ARM Limited. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -384,12 +384,12 @@ STATIC CONST CM_OBJ_PARSER AcpiGenericAddressParser[] = { > /** A parser for EArmObjLpiInfo. > */ > STATIC CONST CM_OBJ_PARSER CmArmLpiInfoParser[] = { > - { "MinResidency", 4, "0x%llx", NULL }, > - { "WorstCaseWakeLatency", 4, "0x%llx", NULL }, > - { "Flags", 4, "0x%llx", NULL }, > - { "ArchFlags", 4, "0x%llx", NULL }, > - { "ResCntFreq", 4, "0x%llx", NULL }, > - { "EnableParentState", 4, "0x%llx", NULL }, > + { "MinResidency", 4, "0x%x", NULL }, > + { "WorstCaseWakeLatency", 4, "0x%x", NULL }, > + { "Flags", 4, "0x%x", NULL }, > + { "ArchFlags", 4, "0x%x", NULL }, > + { "ResCntFreq", 4, "0x%x", NULL }, > + { "EnableParentState", 4, "0x%x", NULL }, > { "IsInteger", 1, "%d", NULL }, > { "IntegerEntryMethod", 8, "0x%llx", NULL }, > { "RegisterEntryMethod", sizeof (EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE),