From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.1205.1588113582622819384 for ; Tue, 28 Apr 2020 15:39:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DJvF7aSF; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588113581; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FRN/dD5ZeDLKho5NFNybRtDrUVyddTrg4CGmhBUCH4U=; b=DJvF7aSFPVMPSKpFKtAudCz2RMkYFxUQwyz9nES/LpMM7I4W6JZzE8mlaVORTKjr/I8fPp Eamtm6vbsZ1FYXgcrpC6xoY9gDlzJLLPbFWyYy3zxpmgjrELFy4ZHHWr6mdXMt/n3M1+GD /9xFoWn7WkJNqlzDVKMFBzJWqYzKbpA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-ELdCYpUGOZyoQsNDPq-iAA-1; Tue, 28 Apr 2020 18:39:34 -0400 X-MC-Unique: ELdCYpUGOZyoQsNDPq-iAA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29AA2872FEC; Tue, 28 Apr 2020 22:39:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-33.ams2.redhat.com [10.36.113.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F52A1002395; Tue, 28 Apr 2020 22:39:31 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/7] OvmfPkg, ArmVirtPkg: control PXE v4/v6 boot support from the QEMU cmdline From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Jordan Justen , Leif Lindholm , Per Sundstrom , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20200424075353.8489-1-lersek@redhat.com> Message-ID: Date: Wed, 29 Apr 2020 00:39:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200424075353.8489-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/24/20 09:53, Laszlo Ersek wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2681 > Repo: https://pagure.io/lersek/edk2.git > Branch: pxe_fw_cfg >=20 > With this series applied, the QEMU command line options listed below > control whether the guest firmware supports PXEv4 / PXEv6 boot. And > correspondingly, whether UefiBootManagerLib generates *new* PXEv4 / > PXEv6 boot options automatically. (Existent boot options are never > deleted in response to just the flags below.) >=20 > -fw_cfg name=3Dopt/org.tianocore/IPv4PXESupport,string=3D[yn] >=20 > -fw_cfg name=3Dopt/org.tianocore/IPv6PXESupport,string=3D[yn] Merged as commit range 64ab457d1f21..cdc3fa54184a, via . I thank everyone for the feedback. Phil, regarding your comment under patch#5: the PCD "get" interfaces do not have "deprecated" vs. "current" variants. Only the "set" interfaces do. "Get" is always supposed to succeed. "Set" may fail. See commit 9a3558419509 ("MdePkg: Add a set of PcdSetXXS APIs into PcdLib and remove the ASSERT in original PcdSetXX APIs.", 2015-04-10). See also EFI_PCD_PROTOCOL in the Platform Init spec: . Thanks! Laszlo >=20 > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Per Sundstrom > Cc: Philippe Mathieu-Daud=C3=A9 >=20 > Thanks > Laszlo >=20 > Laszlo Ersek (7): > OvmfPkg: introduce QemuFwCfgSimpleParserLib > OvmfPkg/PlatformPei: parse "X-PciMmio64Mb" with > QemuFwCfgSimpleParserLib > OvmfPkg/PlatformPei: use QemuFwCfgParseBool in > UPDATE_BOOLEAN_PCD_FROM_... > OvmfPkg/QemuFwCfgDxeLib: allow UEFI_DRIVER modules > OvmfPkg: control PXEv4 / PXEv6 boot support from the QEMU command line > ArmVirtPkg/QemuFwCfgLib: allow UEFI_DRIVER modules > ArmVirtPkg: control PXEv4 / PXEv6 boot support from the QEMU command > line >=20 > ArmVirtPkg/ArmVirtQemu.dsc | = 13 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | = 13 + > ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf | = 2 +- > OvmfPkg/Include/Library/QemuFwCfgSimpleParserLib.h | = 128 +++++++ > OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcd.c | = 39 ++ > OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf | = 33 ++ > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf | = 2 +- > OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParser.c | = 398 ++++++++++++++++++++ > OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf | = 27 ++ > OvmfPkg/OvmfPkg.dec | = 4 + > OvmfPkg/OvmfPkgIa32.dsc | = 10 + > OvmfPkg/OvmfPkgIa32X64.dsc | = 11 + > OvmfPkg/OvmfPkgX64.dsc | = 10 + > OvmfPkg/PlatformPei/MemDetect.c | = 36 +- > OvmfPkg/PlatformPei/Platform.c | = 47 +-- > OvmfPkg/PlatformPei/PlatformPei.inf | = 1 + > 16 files changed, 712 insertions(+), 62 deletions(-) > create mode 100644 OvmfPkg/Include/Library/QemuFwCfgSimpleParserLib.h > create mode 100644 OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcd.c > create mode 100644 OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerL= ib.inf > create mode 100644 OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSim= pleParser.c > create mode 100644 OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSim= pleParserLib.inf >=20