From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1A5F4941D7D for ; Mon, 18 Dec 2023 15:16:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wz8kU+/VB93TICLFd/KxNSj1V/zG1zJBYFs0MCdUFDE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702912598; v=1; b=VIBDHsnONmzzlIddKqWfxPv2FOrH+cXTvbHVUcUcBtcxPpCjmNGy5q8wVZS+dHQj5/UtcQDi X3UQdvfEmdixCZS34Cg7iDdNygR3z6USjmbDUzuAGJtMKoblaaZ4172w9DntAs18XC9bsYVFler AH0MBDrDlxQKShJ+5HQZqb/k= X-Received: by 127.0.0.2 with SMTP id UWHoYY7687511xhP5xSJBVzT; Mon, 18 Dec 2023 07:16:38 -0800 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.79]) by mx.groups.io with SMTP id smtpd.web10.45841.1702912597760809425 for ; Mon, 18 Dec 2023 07:16:38 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=g7QKCaVvVCXQvApjYpubjxBKAEJpysjQ/JRRR5xHcEY2NLH+sjbK6tPl5ZZooH123DXY/GzbST1Z+kV6TPuDtQBUFUxeQl5Q6eyRm0o0WIRAyODpreStBGeTVaXBPGpnsUWSbN7DbGXfRiO8UfvlxJOJdPL0TQnyctTEDgbM839d657pc4GeeUFhMygZAqNGwNgDxkAvAM/8qvZpb9WTI+OL3pd1n+WuhvsAjVD9JzY31kgeI3Ud1btiHKYYJfDdL/TKUVC6c6ODROu+Th3p1FiJVPk+bmVNxLXLgvAgs9rP87TAUdM5Ud8zZ8d1S9RkWnghuf/pyuqQ0ygmuEoN8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEg8O1ie2hfPt3TAIQ4UOwp041+A0gfuP6jMxH4h6Wc=; b=TEwl4gnUgCEDNLat73ejCWU9lJIB1Ll5eHpXTUsgWrMqJij+H1jRmg2PtYN4B+nWbzY6wRKfxlR5GKbRgviGobZn/kHOrZpSBXuvqdi7hR7nyHe8JT9l29xeHYi/7np5dkwfjJF8lz9uGkQ5TKboI/kpSRRxLithuQ0LfKOpSrMTTsAwssd4H4CQpSf4pes2aejbUQm6q4MG02oXCIeZ8PFQRv0WU9suquqMZX+ScwEFuYdRZAv5ehGojJRXN4RscI5r6zIisyxDfODEbX4LNWIRILFmUYeIFNdWMccaY88/exLjBqJ/9/H6KUhkHHncfA2iFtX/6yPpPBcoMFpqNg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DU2PR04CA0085.eurprd04.prod.outlook.com (2603:10a6:10:232::30) by PAVPR08MB9844.eurprd08.prod.outlook.com (2603:10a6:102:2f8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 15:16:30 +0000 X-Received: from DU6PEPF0000A7DE.eurprd02.prod.outlook.com (2603:10a6:10:232:cafe::1e) by DU2PR04CA0085.outlook.office365.com (2603:10a6:10:232::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 15:16:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF0000A7DE.mail.protection.outlook.com (10.167.8.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 15:16:28 +0000 X-Received: ("Tessian outbound 8289ea11ec17:v228"); Mon, 18 Dec 2023 15:16:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 14a91b228ab8cf10 X-CR-MTA-TID: 64aa7808 X-Received: from 6d87ea74e599.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E1DA7EC4-77CD-4B13-9EF6-99827B7AFE5E.1; Mon, 18 Dec 2023 15:16:21 +0000 X-Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6d87ea74e599.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Dec 2023 15:16:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBMZqGgjiUqYHExMJ6XRDaT3ipxPqSQUio/pz//8iEFcnQRyZLvBB6TdgtQz1r4qy9r8s42zfq4yJs1mKumERF6GIlJj2mGW5XIylh0q6JFnQybGvwtM5Ymvq0ywquKpNH7lMk2LjlBozgPQXRObtdnHPihWvckOcLc9P3tQi5YmAzk8ziJ0A19qv6X6kmkrj7uV6BDlfXno4jqGlSGerfA5pqut2L4yeWk2XU5NiLUkkCVil5EbQtaOp9HzU4nVXjrQrRRSHW8f5GCNiDqhHFiLfnB7EmVXqgU5tq1IbxH4WBgvLummaVhdc9jRLFY8KhpaEzcUg71090haxZk1VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEg8O1ie2hfPt3TAIQ4UOwp041+A0gfuP6jMxH4h6Wc=; b=M2af8MmzTY6pQHKZgwNucIIZOCIXlUkZ32PYCjjJfz2on1igpLKLN23156YCcuEAzpYuAvoBv++tEDEWVv3zkHRUCnfHIN4fdtnCZFuRufATx9aIOGNGMdL7TV6Ytc3BLjt+ZcDy7i5b5RYedU2uODvo/SAtLWvfhq2j5/xeCoeWFvwFqP+MeiPVT9moR7u7+XQR21GlsBT5RGf8KcyRDMn0UfO68xKz36ai2Z/FhVgqm6/kG4BR4Gv0lt7EQP2ALahT1YrS7LobZBEbDBAUfUhJY+IwBZ+U2Ztkso8Jmhro2nN2A3+WMpxuQIxFtYZEfa0sMo4T2TifiRctcrOO/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB9001.eurprd08.prod.outlook.com (2603:10a6:10:466::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 15:16:18 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 15:16:18 +0000 Message-ID: Date: Mon, 18 Dec 2023 15:16:14 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 5/5] Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp To: sahil , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , "nd@arm.com" References: <20231116114554.4055517-1-sahil@arm.com> <20231116114554.4055517-6-sahil@arm.com> From: "Sami Mujawar" In-Reply-To: <20231116114554.4055517-6-sahil@arm.com> X-ClientProxiedBy: LO4P265CA0311.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:391::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB9001:EE_|DU6PEPF0000A7DE:EE_|PAVPR08MB9844:EE_ X-MS-Office365-Filtering-Correlation-Id: 311642ef-f7ab-4c06-b38d-08dbffdc4ee8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pdj9/8jN+h94LHBKB7D/MkvbopuT35YbGDj9Y8M6/sK3r7/iGPxzsTDANWVMWPtnS0tP8U2eMcVnymRh7PWqYd4x+d4718PAymoBJcmRe3MwmG52MPPBAAyL3Qt0af4SgumeegKkzzLVlh/6VOohijTk7rMo8e2J1uRUigWCasJhh+4//IgpsT3cCDVg8OtBxuNlvUCAlflYqSU8SVRZmmdzODJAYbaqVjkC1BcHtjmwcEcy04BwAwS3XCVBlUlGhR2cloZCDOrOrOOvUJJXJphhS7rg5M399HDiF8ngPBbaDaPjOr53D22ADQ/ek5tdRR2eV1U9XUffv02qr5sxgvo7o3R+/t7loivx0AumJVJ2vUMd8UXwpzHBeZsavzGD2bnIRhz6InsYwVq/Bbe50zJFSOH2L+XGlb2ZVRs9RgEr7uWvqDfYyuUgad++Ne0HVG4a1suT6T1la22mvJL7MiQDi7HRnwjCleYou+8fGpFb28iwqEVAwLYs03tcAHVQvZNJh9R93UPIGim5/PNwIs4s6/C+FaV063clMBZ8YijBuAg7fHtVANj4WGLDXwaV/dZcqYVevSg8wDgBKMpWygRED/Fr3drMEBfi06dbKTtfBunwF8M/cw5CPVkWERDzxzUV4rOVeX+M5Naj5C3ZuZ/EYCaDV5i08S7OlWbcuXg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(376002)(366004)(39860400002)(136003)(230922051799003)(186009)(1800799012)(451199024)(64100799003)(36756003)(316002)(83380400001)(66946007)(54906003)(66476007)(66556008)(2906002)(38100700002)(4326008)(8676002)(8936002)(5660300002)(44832011)(53546011)(6506007)(6512007)(6666004)(19627235002)(26005)(31686004)(6486002)(478600001)(2616005)(31696002)(86362001)(41300700001)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9001 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF0000A7DE.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8b5ef7cb-c8b8-48d3-9710-08dbffdc48d1 X-Microsoft-Antispam-Message-Info: hyIyTjWX/A6okQRuYhTN5re6Lk8rOfy9Ap4LtCCsezHx+QWXZxVGODw6C4mA38AIxfXgB03YWq7LqUG3f+oZsVTHJ67RP2JqfhwLl8M17JdG/TkXNeJ8gCfb7NXfvEvAyNiRsgO2xut0TrGp729U55PRe+iGpsd/vebCozaIHYVw5xOgQmvGKeEirfD+KMXJ4zPgIN1SuCjMbeWBQyTkHC8xki24EB8pYOQXvyZ+y1PSG8slOOLp4RbLpoTjT1W1gr/krhmJsTWcqbTU6LBt1jrqDESSc6uKgvbOuBClAJTwHZhZtp0Z3F0L/XdiEBMkrxlmWc/LhZ10424H3TlR6X6nX6WEHHi0HI7AkXhhxWzhz3VoZIEM9szEWZLb072dnYkmza0IzlR6EUNhKY+LXoJM1vi+1ldedq95PKLhsB1DpkYh9h2ZMIs9ZvA3CD6B1gX6ZLfp5pXLg7XE6eOrirt4j5IOoYo1xA6IJStEZTHJbigqJeRlhA/TGIDS+kaRtJc47wazqfwOyUjR2QqSSCxqjKcHbawJftaEWejJap7CMuH+EsLvutrWMiBoDVWo+FZ1533pnhm4wvIWLiLK846j/P7G0ERD5bTHHUmdTr/XI5Arg13Z0QlUtknb9v0hEbEsaNDUKRbyQ5WYanVagTtK7lF2Xm1a8IjY86abXwJynit79vOgON0pFf1aLrr2qsr2zyJidjD/S0SFR3S+BiTgQpKtG+hvIUWeAZnQkTyx5I/5EKKj7b/V0ieIIlBVxBgJqu+3+9UkYqYLZE8XeKu0AA4objyKojpQ851jmec= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 15:16:28.4662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 311642ef-f7ab-4c06-b38d-08dbffdc4ee8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000A7DE.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9844 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8HriQQQSqnGGYg2UGhY8Y4uwx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VIBDHsnO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sahil, As such these changes look good to me. But, we would need to revisit=20 this based on my response for Patch 3/5. Regards, Sami Mujawar On 16/11/2023 11:45 am, sahil wrote: > Signed-off-by: sahil > --- > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +++++ > Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1= SdpPlatform.dsc > index 10fe2db9e1b1..703829bbac99 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > @@ -165,6 +165,10 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 > > =20 > > # NOR flash support > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x18F4000= 0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x0002000= 0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0x18F20= 000 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x00020= 000 > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|0x18F000= 00 > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x000200= 00 > > =20 > > @@ -227,6 +231,7 @@ > NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormatt= edLib.inf > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > } > > + MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > > =20 > > # ACPI Support > > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf b/Platform/ARM/N1Sdp/N1= SdpPlatform.fdf > index 4329f892f7c5..17d370a371cf 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > @@ -90,6 +90,7 @@ READ_LOCK_STATUS =3D TRUE > INF MdeModulePkg/Universal/Metronome/Metronome.inf > > INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDx= e.inf > > INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > + INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe= .inf > > INF MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounte= rRuntimeDxe.inf > > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > > INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112646): https://edk2.groups.io/g/devel/message/112646 Mute This Topic: https://groups.io/mt/102625038/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-