From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9501B74004E for ; Wed, 18 Oct 2023 17:03:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oUdHCfYt8Raru937kBjtoQUcSLZ1EUXxVcC4Tl5R7/w=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697648598; v=1; b=plXor74wZ5u2vEKJru/mRSkwYwaOEVDiuo2pmWoO9MIt/7TK5CtIab/3ItlC/6sYlrz36W8D kkRXihLM0FBGHVuJWoyDYGcn6yho1I+sefT7ze8Jyb206EtT2HIkAhlKWWAlmZiBfLvPlUI42TC Fxb/SvXC0X7vazcw5gHke1PA= X-Received: by 127.0.0.2 with SMTP id tdQDYY7687511x9oo8PquV43; Wed, 18 Oct 2023 10:03:18 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.286805.1697648597575755403 for ; Wed, 18 Oct 2023 10:03:17 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-182-B8t8Ka38PlGIeRMT_qIniQ-1; Wed, 18 Oct 2023 13:03:10 -0400 X-MC-Unique: B8t8Ka38PlGIeRMT_qIniQ-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5816C88B770; Wed, 18 Oct 2023 17:03:10 +0000 (UTC) X-Received: from [10.39.192.202] (unknown [10.39.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D64877412; Wed, 18 Oct 2023 17:03:05 +0000 (UTC) Message-ID: Date: Wed, 18 Oct 2023 19:03:04 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class To: devel@edk2.groups.io, ardb@kernel.org Cc: Abner Chang , Ard Biesheuvel , Daniel Schaefer , Leif Lindholm , Ray Ni References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OU2DCdHgnTHBoIKF9cNHKdiix7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=plXor74w; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/18/23 15:44, Ard Biesheuvel wrote: > On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek wrote: >> >> On 10/12/23 11:10, Laszlo Ersek wrote: >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 >>> >>> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly >>> declares a function called LibRtcVirtualNotifyEvent(). No component eve= r >>> calls this function across module boundaries; all RealTimeClockLib >>> instances in edk2 and edk2-platforms are supposed to register -- and do >>> register -- their SetVirtualAddressMap() notification functions. >>> >>> After the edk2-platforms and edk2-non-osi changes, we can repeat the >>> procedure form the edk2-platforms series in edk2. In those >>> RealTimeClockLib instances that define LibRtcVirtualNotifyEvent(), >>> demonstrate that either (a) the usage is module-internal, or (b) there >>> is no usage. In case (a), rename LibRtcVirtualNotifyEvent() to >>> VirtualNotifyEvent(), and make it static. In case (b), remove the >>> function definition. >>> >>> There is a superficial name match in >>> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe. Note that that module is a >>> *driver*, not a library instance; what's more, >>> PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all= . >>> Treat that module too as case (a), right at the front of the series. >>> >>> Finally, drop the LibRtcVirtualNotifyEvent() API declaration. >>> >>> Cc: Abner Chang >>> Cc: Ard Biesheuvel >>> Cc: Daniel Schaefer >>> Cc: Leif Lindholm >>> Cc: Ray Ni >> >> Can I get an ACK for the last three (EmbeddedPkg) patches? >> >=20 > For the series, >=20 > Reviewed-by: Ard Biesheuvel Merged via ; commit range 747a08eae26b..7fe49887c4d2. Thank you! Laszlo >=20 >>> >>> Laszlo Ersek (5): >>> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename >>> LibRtcVirtualNotifyEvent >>> ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent >>> EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent >>> EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent >>> EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib >>> class >>> >>> ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c = | 5 ++-- >>> EmbeddedPkg/Include/Library/RealTimeClockLib.h = | 15 ------------ >>> EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c = | 24 -------------------- >>> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c = | 18 --------------- >>> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c = | 5 ++-- >>> 5 files changed, 6 insertions(+), 61 deletions(-) >>> >>> >>> base-commit: 95c9f470ca6eab23bfd016bd438f932d7263d395 >>> >>> >>> >>> >>> >> >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109765): https://edk2.groups.io/g/devel/message/109765 Mute This Topic: https://groups.io/mt/101914677/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-