Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

["Jeremy Linton" <jeremy.linton@arm.com>]

Hi,

On 8/2/24 06:44, Rebecca Cran wrote:
> On 8/1/24 12:50, Jeremy Linton wrote:
>> On 8/1/24 10:50, Rebecca Cran wrote:
>>> On 8/1/24 9:43 AM, Ard Biesheuvel wrote:
>>>
>>>> Haven't noticed this one myself. The only issue I hit once in a while
>>>> (but only with DEBUG builds as far as I am aware) is an ASSERT() on
>>>> some XhciDxe control register read (or perhaps a timeout?)
>>>
>>> This might be the XHCI bug where there's missing error handling 
>>> around a controller reset failure. I have a patch to send to fix it.
>>>
>>>
>>
>> I would second the please send the patch request. I've got a USB raid 
>> enclosure I carried a patch for a few years similar to the one in this 
>> discussion:  https://edk2.groups.io/g/devel/message/58193
> 
> I've created a PR with the patch: 
> https://github.com/tianocore/edk2/pull/6033
> 


Hi, so that patch doesn't fix the USB/XHCI error I posted last week, and 
that's largely because its not fixing the out of resources issues which 
happen when the controller is repeatedly reset. Which itself is in 
error, because the returned check condition is valid, but indicating the 
device doesn't support the requested command. So the usb subsystem 
should _NOT_ be repeatedly resetting, rather it should be trying to use 
a different command, or simply ignoring the device since reset implies 
there is something wrong with the device/communications channel. Which 
isn't the case, the device is perfectly happy, its simply refusing the 
requested command.


Also, I hit the MMC error again on the rpi, it seems to be a block size 
overflow that isn't being handled correctly. The request is for more 
data than a single write the SD card I have seems to support. So, then 
it should be sending the remaining block, but its getting stuck sending 
MMC_CMD13, presumably waiting for the previous write to complete, which 
never happens.




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120236): https://edk2.groups.io/g/devel/message/120236
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-