Re: [edk2-devel] [PATCH edk2-platforms v2 1/2] Platform/ARM/VExpressPkg: incorporate PL180 driver

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 4/30/20 12:06 PM, Philippe Mathieu-Daudé wrote:
> Hi Ard,
> 
> On 4/30/20 10:25 AM, Ard Biesheuvel wrote:
>> The PL180 SD host controller driver is only used on emulated ARM
>> platforms, uses an obsolete version of the MMC host protocol and
>> does not adhere to the UEFI driver model.
>>
>> Given the above, let's just move it into VExpressPkg where it
>> belongs.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> ---
>>   Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc            |   6 +-
>>   Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf            |   2 +-
>>   Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc         |   6 +-
>>   Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf         |   2 +-
>>   Platform/ARM/VExpressPkg/ArmVExpressPkg.dec                  |   4 +
>>   Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c      | 570 
>> ++++++++++++++++++++
>>   Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.h      | 169 
>> ++++++
>>   Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180MciDxe.inf |  53 ++
>>   8 files changed, 804 insertions(+), 8 deletions(-)
>>
> [...]
>> diff --git a/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c 
>> b/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c
>> new file mode 100644
>> index 000000000000..8526bb41600e
>> --- /dev/null
>> +++ b/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c
>> @@ -0,0 +1,570 @@
>> +/** @file
>> +  This file implement the MMC Host Protocol for the ARM PrimeCell PL180.
>> +
>> +  WARNING:
>> +  This driver fails to follow the UEFI driver model without a good
>> +  reason, and only remains in the tree because it is still used by
>> +  a small number of platforms. It will removed when no longer used.
> 
> I suppose "It will [be] removed"? (2 other occurrences in this patch).
> 

Ah yes thanks for spotting that.

> Otherwise:
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> 
>> +  New platforms should not use it, and no one should use this as
>> +  reference code for developing new drivers.
>> +
>> +  Copyright (c) 2011-2020, ARM Limited. All rights reserved.
>> +
>> +  SPDX-License-Identifier: BSD-2-Clause-Patent
>> +
>> +**/
> [...]
>