From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4519.1588243631801493316 for ; Thu, 30 Apr 2020 03:47:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0CCB51063; Thu, 30 Apr 2020 03:47:10 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 736853F305; Thu, 30 Apr 2020 03:47:09 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 1/2] Platform/ARM/VExpressPkg: incorporate PL180 driver To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io Cc: leif@nuviainc.com References: <20200430082518.26219-1-ard.biesheuvel@arm.com> <20200430082518.26219-2-ard.biesheuvel@arm.com> <9835345a-54a8-debe-dcb3-67be80f45df5@redhat.com> From: "Ard Biesheuvel" Message-ID: Date: Thu, 30 Apr 2020 12:47:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9835345a-54a8-debe-dcb3-67be80f45df5@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/30/20 12:06 PM, Philippe Mathieu-Daud=E9 wrote: > Hi Ard, >=20 > On 4/30/20 10:25 AM, Ard Biesheuvel wrote: >> The PL180 SD host controller driver is only used on emulated ARM >> platforms, uses an obsolete version of the MMC host protocol and >> does not adhere to the UEFI driver model. >> >> Given the above, let's just move it into VExpressPkg where it >> belongs. >> >> Signed-off-by: Ard Biesheuvel >> --- >> =A0 Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 |=A0=A0 6 +- >> =A0 Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 |=A0=A0 2 +- >> =A0 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0=A0 6 +- >> =A0 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0=A0 2 +- >> =A0 Platform/ARM/VExpressPkg/ArmVExpressPkg.dec=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 |=A0=A0 4 + >> =A0 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c=A0=A0=A0=A0= =A0 | 570=20 >> ++++++++++++++++++++ >> =A0 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.h=A0=A0=A0=A0= =A0 | 169=20 >> ++++++ >> =A0 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180MciDxe.inf |=A0 = 53 ++ >> =A0 8 files changed, 804 insertions(+), 8 deletions(-) >> > [...] >> diff --git a/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c=20 >> b/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c >> new file mode 100644 >> index 000000000000..8526bb41600e >> --- /dev/null >> +++ b/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c >> @@ -0,0 +1,570 @@ >> +/** @file >> +=A0 This file implement the MMC Host Protocol for the ARM PrimeCell P= L180. >> + >> +=A0 WARNING: >> +=A0 This driver fails to follow the UEFI driver model without a good >> +=A0 reason, and only remains in the tree because it is still used by >> +=A0 a small number of platforms. It will removed when no longer used. >=20 > I suppose "It will [be] removed"? (2 other occurrences in this patch). >=20 Ah yes thanks for spotting that. > Otherwise: > Reviewed-by: Philippe Mathieu-Daude >=20 >> +=A0 New platforms should not use it, and no one should use this as >> +=A0 reference code for developing new drivers. >> + >> +=A0 Copyright (c) 2011-2020, ARM Limited. All rights reserved. >> + >> +=A0 SPDX-License-Identifier: BSD-2-Clause-Patent >> + >> +**/ > [...] >=20