Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

["Abdul Lateef Attar via groups.io" <AbdulLateef.Attar=amd.com@groups.io>]

Hi Sami Mujawar,

     Looks like current edk2 CI handles the X64, IA32 for both GCC and 
VS2019 to build DynamicTablesPkg.

I can see that TARGET_FMP_FAT_TEST is failed for VS2019 for below 
PR(which is expected).

https://github.com/tianocore/edk2/pull/5215

Thanks

AbduL


On 04-01-2024 07:41, Abdul Lateef Attar via groups.io wrote:
> Caution: This message originated from an External Source. Use proper 
> caution when opening attachments, clicking links, or responding.
>
>
> Hi Sami Mujawar,
>
>     Thanks for quick response, update and merge of the patch.
>
> Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain
> VS2019) and also using GCC 11.4 (tool-chain GCC).
>
> I'll take a look at edk2 CI.
>
> Thanks
>
> AbduL
>
>
> I'll take a look at edk2 CI and
>
> On 03-01-2024 20:24, Sami Mujawar wrote:
>> Caution: This message originated from an External Source. Use proper
>> caution when opening attachments, clicking links, or responding.
>>
>>
>> Hi Abdul,
>>
>> I have merged this series as d7d4f09ff815..2576cbafec98.
>>
>> Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it
>> would be good to enable that in the edk2 CI. That way we do not
>> accidently break the builds.
>>
>> To enable edk2 CI for AARCH64 using GCC, I had made the change at
>> https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L50 
>>
>>
>>
>> I am not sure what is required to support X64 and IA32 builds using
>> VS2019. Can you provide a patch for that, please?
>>
>> Also, by any chance have you tried building DynamicTablesPkg with GCC
>> for X64 and IA32?
>>
>> Regards,
>>
>> Sami Mujawar
>>
>> On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote:
>>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>>>
>>> PR: https://github.com/tianocore/edk2/pull/5209
>>> v2: Fix the IA32 compilation errors.
>>> v1: Fix the X64 compilation errors.
>>>
>>> Cc: Pierre Gondois pierre.gondois@arm.com
>>> Cc: Sami Mujawar sami.mujawar@arm.com
>>> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>>>
>>> Abdul Lateef Attar (2):
>>>    DynamicTablesPkg: Fix X64 compilation errors
>>>    DynamicTablesPkg: Fix IA32 compilation errors
>>>
>>>   DynamicTablesPkg/DynamicTables.dsc.inc          | 17 
>>> ++++++++++++-----
>>>   DynamicTablesPkg/DynamicTablesPkg.dsc           |  7 +++++--
>>>   .../Library/Common/AmlLib/AmlLib.inf            |  2 ++
>>>   .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c  |  4 ++--
>>>   .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c |  7 ++++---
>>>   .../ConfigurationManagerObjectParser.c          |  2 +-
>>>   .../Library/Common/TableHelperLib/TableHelper.c |  6 ++++--
>>>   .../Common/TableHelperLib/TableHelperLib.inf    |  2 ++
>>>   8 files changed, 32 insertions(+), 15 deletions(-)
>>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are
>> confidential and may also be privileged. If you are not the intended
>> recipient, please notify the sender immediately and do not disclose
>> the contents to any other person, use it for any purpose, or store or
>> copy the information in any medium. Thank you.
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113130): https://edk2.groups.io/g/devel/message/113130
Mute This Topic: https://groups.io/mt/103499168/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-