From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 359B3941023 for ; Thu, 4 Jan 2024 04:05:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9fnUFs+clJQ061Wt2gLTzjRUvKhLeesiEu97J9aORN4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704341104; v=1; b=oBgoSGnwHPZRql2vROTZzFYlI7mjnVTw3jfZnk8o6W4V51PcZX58RU/bXe4Cy1LT/Vws8NQL tgQZogaWz48H9RW4uN9+Evfn/uwenP5SS9lyoFC96XDRv4xbiMgBPe5f7OS642lv/4fyMQXgN+P h5TQCkpH37JksVQfnqHRHxfQ= X-Received: by 127.0.0.2 with SMTP id oxOcYY7687511xoy5CuCLLZU; Wed, 03 Jan 2024 20:05:04 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.45]) by mx.groups.io with SMTP id smtpd.web10.47337.1704341104014085303 for ; Wed, 03 Jan 2024 20:05:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P3DknnILf59UyhE6Z6A7rac0BuCZGAo63mlh58ZpMjtHTVq44ffUyvXEULDcSC6Ud46EHIBGEWZ8UlugoB8xC1xrMu8N0myQVedKA2D8f20zMRgd2Ks2bNTAtCgVaW2nlXQPi9WOUhUHb4lYsAnqRqSsc87OZbFyTl8jA6Fjn0HqtGJYOWI6xat1HlhtXXfcFYEBRHY+KSXzrklOcfTdCq4KrWVJRZEFVu04JcyS92wd75MFLojogXSayt+TCpZUO0qyGYxXnngZNsNx6fVXdK1xunuPLGENuxJBjfa3y9JeU+6e4XNdnAM9Qxh6JIsaIbQDaSunIKzwXMac82I0rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=be1NffuNEHlkXlVFkQKs4JTjo+QIkJbMBMkQO7NQ6dI=; b=IU7RCgDTARXuKLw77Ycliv7KkTYACL1Tr77df2Vrat8L+i+bhQuzi5GmeOJSvP7r5QjUyUzWmuikOcoi8HK/yR4+v9IKRr2C1GvkY0kIIrkTwAIDDzt+1QM5nhLaFojb8sImKkokYZCaF250GwVli+Vp8xB6S6oMNsXSBbzfGEzJeOCS2jt6oh+iGJM0Pv77cK0GLEaqctMGFou3hF7+FuLxy6MrDDoPlj6v14bgH+0hCnnWdRxXpPuj9zrWXIltWcpcyP7jO+8Ka2Ev1z7cpU64Mcyi1yie8tG65PMeJXH8NuVvvjmlZyc9Tz7wJ9dL7U8UVlKTuUBcHyxjvrijeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by IA0PR12MB8648.namprd12.prod.outlook.com (2603:10b6:208:486::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.14; Thu, 4 Jan 2024 04:05:00 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::c436:397e:a940:5e6d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::c436:397e:a940:5e6d%4]) with mapi id 15.20.7135.023; Thu, 4 Jan 2024 04:05:00 +0000 Message-ID: Date: Thu, 4 Jan 2024 09:34:54 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors To: devel@edk2.groups.io, Sami Mujawar , "nd@arm.com" , Pierre Gondois References: <17A702FE941215EA.10454@groups.io> From: "Abdul Lateef Attar via groups.io" In-Reply-To: <17A702FE941215EA.10454@groups.io> X-ClientProxiedBy: PN3PR01CA0037.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:98::16) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|IA0PR12MB8648:EE_ X-MS-Office365-Filtering-Correlation-Id: e120e8b0-a51f-431d-711b-08dc0cda523c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: umZ+RlZAmBoRSfJAJlO58U7XJpm+fo/RuZcSjmKF+zWwuEXoaJGwUtew/jhjf4zJ3CeIPVh/iXm1xOfXSEw2y+tk+JQHuMkfkVEsGPJfr1vrlle5Rma6ZaoIED++f3AoR24k642/gtZfJvNcERaB8Mn3/NzmtBEGT3bNkIp7WfgiwlHAj1FXqKkQRZOkm9HgQEWqEVJRLolhuExMJWS1dBx5/UU3Lqs42hJs3PtrUdUWxocUVnREIRB1IgzE+5KIM1F+v2/3CbLgA2y/ynw1gSMryVC5iEv0/TUTJ0Z4qn74fOADTsWhEFhFR0hpzS+sNFwFoFAXi5mffmt+lCCCh8B+gnCKDTWBiPyoAlK+ecw1fkFT14+EylCcZ7KCyxAoJpCWDvxdRjUM8bbNEc1q9isfRe5rblbWlaqKPADb/E8yOR7jkNPwkg6IwQUY8vGrl2mhIxP0p6e74TwQHnkMT4KCVw42t9PTjOEHyU1jJCNyRqMPJQh8NFUimiZoukM4Wv7D2HZ7Y0zRlbG+Un8HSx6PofQgzV7i6dQ+/ln88/zGfrNz2z/62CBMzN4v8H2ZbXhS0jRM1PWxlaMwJCfhnk1a3NtexWU0KeDO09wzYsDARE3zTeXJgfIQ3aZAvp/Jhf8P5/MDFZJkjjKvdsmwWUCKrWs/nv780mbikbtvRPP/G8drz56OZII8PajtN657lcI2rB9zVgUla+BoFIu0cQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gHGw2vJtXUwoLbAxt7uaXMbbUFGGvrfaTGzmPHKUBwxphF2F7vldwabZYBHa?= =?us-ascii?Q?MaZffosVqrhohNcWVoyhzXEHPEKvkJJxl12Ibg1GCY3/5OzRY7ccJNMLtTgK?= =?us-ascii?Q?x5nznsISochDPJnu/uClFhibmQ32zKBWtVPz0aAxtXB2Z2cD7ZS5UeMflWbs?= =?us-ascii?Q?QZA5KPj1QwmUFvKTyRzOnOFRYHBy8HrojRj/PGdI1jBDMzVPiVLBi1fe7yTU?= =?us-ascii?Q?/TJ/32RPjv/O88iMs/yVgFT7WsyEAoCcbG/VXRADVr+Dcxe8SAwB6AUdw/PW?= =?us-ascii?Q?DrD/1nD6NI9lzHJ+ZhM6QjOKHWQ+rUR5LSHP56NXahKdcQ78NxCdNsaf09DE?= =?us-ascii?Q?f6CiJLAd+VGPGDJYSilGIr+5gH6dQyvLPrGpQMc10Vjrp2NhMbKv9i9EvBbg?= =?us-ascii?Q?W8IVsQt9d1apQ+z/FILzprwY8QkHUxiVoWWl36UeqbmmMeu+IQ9FX+kLVmDc?= =?us-ascii?Q?zxl97WSmdGrinnjYx1ZCd9G/y22y2pCs3Uj6eX52gr+OEGIoRJxqZmxf8fCE?= =?us-ascii?Q?EhFmeBZD6MnwW9JdZCKcDx79hFnl4eu/7p6pxA+nNdRsI8Hhcedj7I/GDlPV?= =?us-ascii?Q?KVv2HOWwdHhsN7WkmmOw3UPCOMymKGtrosO0HDaNZd4alsuyplQft7gahV22?= =?us-ascii?Q?utj4LJ3mfA+bRzDoo0IE7ekCibPRlEwjzSqU14XUDqgXNPDCXBEMyVyBD77Y?= =?us-ascii?Q?Q4TpFklMfHmln8Mi/X03Kc38d5KEAMLQcSQkO/aJf2XegyXRaLqf0Sw+lF6q?= =?us-ascii?Q?Q0Cr/X2kx3G5C7hu+IUFZW1hT7KsR8p4RzF1mYC7xsErqiqbNuRppexAwDNK?= =?us-ascii?Q?AYOuxmjvI6NU2REuXvtM2+D0WBdkHi3FcTOcIWFrEoRvSkRAm/RAdZAgXCD+?= =?us-ascii?Q?/9uQXaR2sdpBg/WoxC4vf8wl8ED8YfzplsPFj1giY7plFKqgkCc2QD49ihxC?= =?us-ascii?Q?epW41SK17b4btZG8pzOfZ7zWX+oE3r/G/abHGlk7bS9uNzSPMfDgB8wB2yNs?= =?us-ascii?Q?ENv961Yxm1pKQLGnTWO4XpPUPNWq3Rd7ViuGUR3Je3ge1eHgzt77IYxXCfD6?= =?us-ascii?Q?mj0SjgkgWBL1SxgIzseXGKECnJmleuSM1OGp5MxWU7tPQulmFLk3l6BB9Yb5?= =?us-ascii?Q?CQHqGLeqimB9NquzyHjSQVMRHXEbX+VHCDu6fhzvFjpf/cGuqwzVOYxSYZPu?= =?us-ascii?Q?/TW0SgQtdtuvYr78gnkNKWU552x+Jn2NU4KV7QFcol6087n9vt3VYQ4OPGFR?= =?us-ascii?Q?+Q8V9Xm+AL3FSTatBVOSiFk3yHOdfezWoANKHbhfjvvr9VJtZF5UGIUXQXjQ?= =?us-ascii?Q?Qii5W1CDUqSNdBFbHg97wwQ4o8od0+3/7cwH7vhK7Yq4VzOfdvNYqZ1KyYDm?= =?us-ascii?Q?49vxUllllyV3fK09sLKNWuNgNJZxHyds8BrwBbB12a55bcJxZf2ZRkpzyTLt?= =?us-ascii?Q?cQrGEH6HXnd0YQZKGrpIpCRJ+TSN/TmkG9TLmmuZKx8+rrgleedRYv/qaG2n?= =?us-ascii?Q?Sc1uSteXGzXEgEmY/HYhp5pZqrq9CZu/7KivLfrf6Y6LJdxnJT/ftcSj/OyK?= =?us-ascii?Q?3gf/vxZHrqUIiY4FYIehKzXDdlO6Mp8mr6SlNSBS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e120e8b0-a51f-431d-711b-08dc0cda523c X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 04:05:00.5227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F/FWGxUOtNX1lsAVDQVm7EtkZSn3Enn/hKK5F8Ymw1MY/ZDxWZ7/VdSMbWREwv9vQp2rQqhRKfE/0pEeEvInAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8648 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: adVYO8i5bYp86ygHf44Lk4mlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oBgoSGnw; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sami Mujawar, =C2=A0=C2=A0=C2=A0 Looks like current edk2 CI handles the X64, IA32 for bo= th GCC and=20 VS2019 to build DynamicTablesPkg. I can see that TARGET_FMP_FAT_TEST is failed for VS2019 for below=20 PR(which is expected). https://github.com/tianocore/edk2/pull/5215 Thanks AbduL On 04-01-2024 07:41, Abdul Lateef Attar via groups.io wrote: > Caution: This message originated from an External Source. Use proper=20 > caution when opening attachments, clicking links, or responding. > > > Hi Sami Mujawar, > > =C2=A0=C2=A0=C2=A0 Thanks for quick response, update and merge of the pat= ch. > > Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain > VS2019) and also using GCC 11.4 (tool-chain GCC). > > I'll take a look at edk2 CI. > > Thanks > > AbduL > > > I'll take a look at edk2 CI and > > On 03-01-2024 20:24, Sami Mujawar wrote: >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Hi Abdul, >> >> I have merged this series as d7d4f09ff815..2576cbafec98. >> >> Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it >> would be good to enable that in the edk2 CI. That way we do not >> accidently break the builds. >> >> To enable edk2 CI for AARCH64 using GCC, I had made the change at >> https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/= pr-gate-build-job.yml#L50=20 >> >> >> >> I am not sure what is required to support X64 and IA32 builds using >> VS2019. Can you provide a patch for that, please? >> >> Also, by any chance have you tried building DynamicTablesPkg with GCC >> for X64 and IA32? >> >> Regards, >> >> Sami Mujawar >> >> On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote: >>> From: Abdul Lateef Attar >>> >>> PR: https://github.com/tianocore/edk2/pull/5209 >>> v2: Fix the IA32 compilation errors. >>> v1: Fix the X64 compilation errors. >>> >>> Cc: Pierre Gondois pierre.gondois@arm.com >>> Cc: Sami Mujawar sami.mujawar@arm.com >>> Cc: Abdul Lateef Attar >>> >>> Abdul Lateef Attar (2): >>> =C2=A0=C2=A0 DynamicTablesPkg: Fix X64 compilation errors >>> =C2=A0=C2=A0 DynamicTablesPkg: Fix IA32 compilation errors >>> >>> =C2=A0 DynamicTablesPkg/DynamicTables.dsc.inc=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 17=20 >>> ++++++++++++----- >>> =C2=A0 DynamicTablesPkg/DynamicTablesPkg.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 7 +++++-- >>> =C2=A0 .../Library/Common/AmlLib/AmlLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 ++ >>> =C2=A0 .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c=C2=A0 |=C2=A0 4 += +-- >>> =C2=A0 .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c |=C2=A0 7 ++++--= - >>> =C2=A0 .../ConfigurationManagerObjectParser.c=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >>> =C2=A0 .../Library/Common/TableHelperLib/TableHelper.c |=C2=A0 6 ++++-- >>> =C2=A0 .../Common/TableHelperLib/TableHelperLib.inf=C2=A0=C2=A0=C2=A0 |= =C2=A0 2 ++ >>> =C2=A0 8 files changed, 32 insertions(+), 15 deletions(-) >>> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose >> the contents to any other person, use it for any purpose, or store or >> copy the information in any medium. Thank you. > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113130): https://edk2.groups.io/g/devel/message/113130 Mute This Topic: https://groups.io/mt/103499168/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-