From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mx.groups.io with SMTP id smtpd.web11.19401.1683730188672795966 for ; Wed, 10 May 2023 07:49:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=gFNJveoC; spf=pass (domain: bsdio.com, ip: 64.147.123.24, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 78B6332009A3; Wed, 10 May 2023 10:49:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 10 May 2023 10:49:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683730187; x=1683816587; bh=L+guUfo2g01jxwbcM4x3fU0qPBQPM8huiJ8 bhmw9aM8=; b=gFNJveoC4Imak6am8sfSyhoadfQkF9/Mxa2j4rdtCg3a5bkRxcI ezwAUmQQsArDJBgj80HR3UUH16jQ6PZ2w5RYDPv5nZo4IDAYczDSkPNGomG9Roj+ tVV1crvRdFXihbNzJXQPX6RrGfW51Cotrh7ZlKONdUwiO4ADyIuIc6FJzqwivb/Y mCbFquDUGmzMw67krXc9qsc9u09qYNeCDy1O6DfT7CVt5yFPuIZkc9WiQx3uhzGt zyZ1NBbZ+DCRP9092TG5uRH9tsrf9L8gMAfmeYKUrnnnNnfbmSap0tWXkedsqgFk nWAlLZVeE3nnPCwXHsH44R+NjxCpgNlafYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683730187; x=1683816587; bh=L+guUfo2g01jxwbcM4x3fU0qPBQPM8huiJ8 bhmw9aM8=; b=KxLlJAILaBu+BP8t437xQ1PQZbtU/YluyTASJQTBD3d7xom3xDz 9SfDfiaCcfpjPF1krAGnBV0Eju32yKNqJSA5FnpwUwApwee4h6XQ2910NJF4hzbx VkVZGHvoJ8whuhAYvhr/m1xW36kcDa2JooAJDpnjJ+HQyv9a6OID/TGjIGfChHqG eLfVeihnyDaOzWSwNRV1uRlv+CfOGd39MGMhfZy2FS7+Of3I0c8dYKYovft1I3Ag 2mwMWlqMMvXV4CLovDY4dnOw2JeAfWssWsSWAD4915crgFgrEY45s01GTDfC6nDN HcnpC0fKAropyn09PhlTGILdjsV47+B57RQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegiedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeugeffudehtdffieelgeelvdehudehgfekueevvdeuudelffdtheehieeg jeeileenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtgho mh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 May 2023 10:49:45 -0400 (EDT) Message-ID: Date: Wed, 10 May 2023 08:49:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-stable202305 PATCH 1/1] BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template To: Ard Biesheuvel Cc: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen , Michael D Kinney , Liming Gao References: <20230510123141.1880782-1-rebecca@bsdio.com> <3173f4a8-5079-ac73-7ce2-1802152a14f1@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mike/Liming: GitHub PR with R-B added: https://github.com/tianocore/edk2/pull/4384 -- Rebecca Cran On 5/10/23 07:51, Ard Biesheuvel wrote: > On Wed, 10 May 2023 at 14:46, Rebecca Cran wrote: >> On 5/10/23 06:37, Ard Biesheuvel wrote: >>> On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote: >>>> This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00. >>>> >>>> While GCC uses objcopy for the OBJCOPY command, it's not needed for the >>>> CLANGDWARF toolchain and can be left as echo. >>>> >>> Are you sure you want to change this for IA32 and X86 as well? I'm not >>> sure what the significance is, I suppose it sets the debuglink on the >>> copies of the dll files? >> Looking back to the tools_def.template from edk2-stable202302, we set >> OBJCOPY_PATH for CLANG38 IA32 and X64, but not for CLANGPDB or CLANGDWARF. >> >> I was thinking it's safer to keep existing behavior for now. >> > Existing behavior of CLANGDWARF for X86 and IA32, right? Yeah that makes sense. > > Reviewed-by: Ard BIesheuvel