Re: [PATCH v2 6/9] OvmfPkg/PlatformBds: Dispatch deferred images after EndOfDxe

[Laszlo Ersek <lersek@redhat.com>]

Ray,

On 11/08/16 14:04, Laszlo Ersek wrote:
> On 11/08/16 13:29, Ruiyu Ni wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
>> index 66ee590..cc35630 100644
>> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
>> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
>> @@ -389,6 +389,11 @@ Returns:
>>                    NULL);
>>    ASSERT_EFI_ERROR (Status);
>>  
>> +  //
>> +  // Dispatch deferred images after EndOfDxe event and ReadyToLock installation.
>> +  //
>> +  EfiBootManagerDispatchDeferredImages ();
>> +
>>    PlatformInitializeConsole (gPlatformConsole);
>>    PcdStatus = PcdSet16S (PcdPlatformBootTimeOut,
>>                  GetFrontPageTimeoutFromQemu ());
>>
> 
> Can you please add a note to the commit message that, if the platform
> installs EfiDxeSmmReadyToLockProtocol, then the deferred images must not
> be dispatched prior to that either, not just prior to EndOfDxe?
> 
> Simultaneously, I propose the following subject (72 chars):
> 
> OvmfPkg/PlatformBds: Dispatch deferred images after EndOfDxe/ReadyToLock
> 
> No need to repost just because of this; the commit message can be
> updated before you commit the series.
> 
> With the commit message update:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

I see that you added my R-b to the commit message.

9789894e3ba3dae87bfc384e97f946caeab389e0

But, you didn't update the patch like I requested. :(

Please pay more attention. Otherwise next time I'll have to ask for a
full repost, to make sure that my request is addressed.

Laszlo