From: rebecca@bsdio.com
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
devel@edk2.groups.io, jordan.l.justen@intel.com,
lersek@redhat.com, ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.
Date: Wed, 24 Jul 2019 08:29:38 -0600 [thread overview]
Message-ID: <ac6c9805-7d95-44af-d16f-05c4148d7df1@bsdio.com> (raw)
In-Reply-To: <eb557723-a5db-07a5-082a-1e14611929bf@redhat.com>
On 2019-07-24 06:30, Philippe Mathieu-Daudé wrote:
>
>> -elif [[ ( -f `which build` || -f `which GenFv` ) && ! -d $EDK_TOOLS_PATH/Source/C/bin ]];
>> +elif [[ ( $(command -v build) || $(command -v GenFv) ) && ! -d $EDK_TOOLS_PATH/Source/C/bin ]];
> Why add $() ?
They're needed when used in a test ([...] or [[...]]) statement. $()
replaces the older `` syntax.
--
Rebecca Cran
next prev parent reply other threads:[~2019-07-24 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 0:49 [PATCH] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which' rebecca
2019-07-24 12:30 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-24 14:29 ` rebecca [this message]
2019-07-24 21:50 ` rebecca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac6c9805-7d95-44af-d16f-05c4148d7df1@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox