From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 30D9E2265A335 for ; Wed, 11 Apr 2018 02:02:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D341F406E897; Wed, 11 Apr 2018 09:02:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-97.rdu2.redhat.com [10.10.120.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45B3A10B2B5B; Wed, 11 Apr 2018 09:02:11 +0000 (UTC) From: Laszlo Ersek To: "Feng, YunhuaX" , "edk2-devel@lists.01.org" Cc: "Gao, Liming" References: <47C64442C08CCD4089DC43B6B5E46BC484BA94@shsmsx102.ccr.corp.intel.com> Message-ID: Date: Wed, 11 Apr 2018 11:02:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 11 Apr 2018 09:02:11 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 11 Apr 2018 09:02:11 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 09:02:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/11/18 09:57, Laszlo Ersek wrote: > Hello Yunhua, > > On 04/10/18 03:09, Feng, YunhuaX wrote: >> Free DummyFileBuffer and set DummyFileBuffer to NULL. >> >> Cc: Liming Gao >> Cc: Yonghong Zhu >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Yunhua Feng >> --- >> BaseTools/Source/C/GenSec/GenSec.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > can you please post patch sets with a cover letter, and with shallow > threading enabled? > > The following three commands [1] should configure shallow threading > permanently: > > git config format.coverletter true > git config sendemail.chainreplyto false > git config sendemail.thread true A related request: please run the following two commands: git config user.name 'Yunhua Feng' git config user.email yunhuax.feng@intel.com The reason I'm asking for this is that your authorship information is currently recorded in git like this (please see commit 6ecab5ad077e): Author: Feng, YunhuaX That "thing" in the <> brackets is not an email address. I suggest that your authorship information (which is used for new commits you create) be identical to the name and email address that you use in your Signed-off-by line. The above two git-config commands will do that. Thanks! Laszlo