From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D8E13211799DD for ; Thu, 25 Oct 2018 18:15:22 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 18:15:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,426,1534834800"; d="scan'208";a="85675044" Received: from shzintpr02.sh.intel.com (HELO [10.7.209.51]) ([10.239.4.160]) by orsmga006.jf.intel.com with ESMTP; 25 Oct 2018 18:15:21 -0700 To: Jian J Wang , edk2-devel@lists.01.org References: <20181025071805.6692-1-jian.j.wang@intel.com> Cc: star.zeng@intel.com From: "Zeng, Star" Message-ID: Date: Fri, 26 Oct 2018 09:14:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181025071805.6692-1-jian.j.wang@intel.com> Subject: Re: [PATCH v4 0/6] Introduce freed-memory guard feature X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 01:15:23 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2018/10/25 15:17, Jian J Wang wrote: >> v4 changes: >> Updated per comments from Star. Please refer to individual patch >> file for details (#2/5/6) Minor comments to patch 5 and 6, please see the individual feedback. With them addressed, Reviewed-by: Star Zeng to patch 1, 2, 5 and 6. And remember to add RB from Laszlo, I think at least you can add RB from Laszlo for patch 1, maybe patch 2 about MdeModulePkg change. Thanks, Star > > Freed-memory guard is a new feauture used to detect UAF (Use-After-Free) > memory issue. > > Tests: > a. Feature basic unit/functionality test > b. OVMF regression test > > Jian J Wang (6): > MdeModulePkg: cleanup Heap Guard pool/page type PCD documentation > MdeModulePkg: introduce UEFI freed-memory guard bit in HeapGuard PCD > UefiCpuPkg/CpuDxe: consider freed-memory guard in non-stop mode > UefiCpuPkg/CpuDxe: prevent recursive calling of > InitializePageTablePool > MdeModulePkg/Core: prevent re-acquire GCD memory lock > MdeModulePkg/Core: add freed-memory guard feature > > MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 87 ++++-- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 409 +++++++++++++++++++++++++- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 65 +++- > MdeModulePkg/Core/Dxe/Mem/Page.c | 42 ++- > MdeModulePkg/Core/Dxe/Mem/Pool.c | 23 +- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 2 +- > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 18 +- > MdeModulePkg/MdeModulePkg.dec | 20 +- > MdeModulePkg/MdeModulePkg.uni | 16 +- > UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 23 +- > 11 files changed, 637 insertions(+), 70 deletions(-) >