From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.89.1662564771378405691 for ; Wed, 07 Sep 2022 08:32:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=FP8jbwDY; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 93BF5204A593; Wed, 7 Sep 2022 08:32:49 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 93BF5204A593 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1662564770; bh=O2SegXZmWsXCWpWTNFGB4hnZbefXe5SxileO6Qb9+Zg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FP8jbwDYk55VAH8VJ7ile+Rqx+B7y++zyLIjLaNBEpk6zK/zk1VMBr94tmshy9Ggt SjqUap0rVRoia72rHrvhVGedeHIpywuzKR7RI4ARMI0m6AVWIeTtyVN1sy4OpFZ5nI mKKwKNdpQOaddJALgcmuWdwNrfp9RGUsAjCegLIw= Message-ID: Date: Wed, 7 Sep 2022 11:32:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls To: Ard Biesheuvel , devel@edk2.groups.io Cc: quic_rcran@quicinc.com, quic_llindhol@quicinc.com, Michael Kinney , Andrew Fish , Sami Mujawar , Jian J Wang , Liming Gao References: <20220907040326.388003-1-rebecca@quicinc.com> <20220907040326.388003-2-rebecca@quicinc.com> <1712796FB27A1CB6.17907@groups.io> <817ece1b-ab1d-7639-093d-de40867ea1b8@quicinc.com> <628d9f35-4b7a-2b12-71c1-9bcd5920ca76@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Please note that I already turned AuditOnly mode on for the EmbeddedPkg patch series. On 9/7/2022 11:21 AM, Ard Biesheuvel wrote: > On Wed, 7 Sept 2022 at 17:11, Michael Kubacki > wrote: >> >> Maintainers have two options for Spell Check as described in the Spell >> Check CI Plugin readme - >> https://github.com/tianocore/edk2/tree/master/.pytool/Plugin/SpellCheck >> >> 1. Set AuditOnly to "true" - Disables all spelling errors in the package >> from the failing the build entirely. >> >> 2. Extend the dictionary - Add specific words that are allowed. Many >> packages already do this. >> >> 3. IgnoreStandardPaths - Do not check files by path pattern. >> >> As a maintainer, you can either opt out of Spell Check from the failing >> the build entirely by enabling AuditOnly or choose a different level of >> granularity by simply updating your package CI YAML file. >> > > Thanks for the explanation - patch coming up. > > >> On 9/7/2022 3:35 AM, Ard Biesheuvel wrote: >>> On Wed, 7 Sept 2022 at 06:35, Rebecca Cran wrote: >>>> >>>> Also, CI is failing in the SpellCheck test because of the >>>> "-mstrict-align" in >>>> ArmPsciMpServicesDxe.inf. >>>> >>>> /home/vsts/work/1/s/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf:55:25 >>>> - Unknown word (mstrict) >>>> >>>> Should I add "mstrict" to pytool/Plugin/SpellCheck/cspell.base.yaml ? >>>> >>> >>> This is getting ridiculous. >>> >>> I'm all for code quality and automation, but if t we cannot use >>> compiler command line options that it supported since the dawn of time >>> without bending over backwards to placate the CI machine, we are >>> throwing out the baby with the bath water. >>> >>> At the very least, maintainers should be able to override the CI - I >>> spent 2 hours yesterday preparing a submission that ultimately got >>> rejected because MPIDR is not in the permitted word list (suggestion: >>> use 'mpidr') >>> >>> In the Linux kernel, we have patch check and sparse (which is somewhat >>> similar to ECC in a sense). Some maintainers run it, some don't, but >>> in the end, the discretion lies with the person not the machine. This >>> is the only way that makes sense. >>> >>> As the co-maintainer of ArmPkg, ArmVirtPkg, ArmPlatformPkg, OvmfPkg >>> and EmbeddedPkg, I hereby request that the Ci restrictions are either >>> lifted entirely for these packages, or relaxed so that a PR can be >>> merged at my discretion, even if the CI thinks there are unresolved >>> issues. >>> >>> >>> >>>> On 9/6/22 22:25, Rebecca Cran wrote: >>>>> On 9/6/22 22:03, Rebecca Cran wrote: >>>>>> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc >>>>>> index 59fd8f295d4f..4716789402fc 100644 >>>>>> --- a/ArmPkg/ArmPkg.dsc >>>>>> +++ b/ArmPkg/ArmPkg.dsc >>>>>> @@ -125,6 +125,7 @@ [Components.common] >>>>>> ArmPkg/Drivers/CpuPei/CpuPei.inf >>>>>> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >>>>>> ArmPkg/Drivers/ArmGic/ArmGicLib.inf >>>>>> + ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf >>>>>> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf >>>>>> ArmPkg/Drivers/TimerDxe/TimerDxe.inf >>>>> This won't work, since there's no support for 32-bit ARM code. >>>>> I'll move it into the AARCH64 section. >>>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >> >> >> >> >>