From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.1005.1623972650380597225 for ; Thu, 17 Jun 2021 16:30:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=AMYx9DT6; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.124.238.202] (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id C09D120B6C50; Thu, 17 Jun 2021 16:30:49 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C09D120B6C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1623972649; bh=wrRzhdZ1e2x5lEJil2SBPTNKOPmaxA1gOs/3vVF3BKc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=AMYx9DT6jAWMVPeZUFl+le89ukrOdXUjFFYcPeQfdJF4UzsQ1dQnKOPQgV/UEZ4LW YH7maYKG9nh8uJmKCOHJjwpsEyoge3acKS4JYOcx0M6gZZIqF2tU9UKWiNKkkP0a09 9AkDKYNqgYFJ2JYRq+6R8i+pIysR/o1uxkhgStbs= Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] MinPlatformPkg: Add TPM platform hier disable support To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: "Chiu, Chasel" , "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" , Jeremiah Cox References: <1686586931DF02F0.1698@groups.io> <57e1ea1f-cdb3-2860-b99c-2867cfe512ae@linux.microsoft.com> From: "Michael Kubacki" Message-ID: Date: Thu, 17 Jun 2021 19:30:49 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit MinPlatformPkg maintainers, can we please get this in soon if there's no concern? Thanks, Michael On 6/15/2021 8:41 PM, Yao, Jiewen wrote: > Thank you, Michael. > > Acked-by: Jiewen Yao > > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Michael >> Kubacki >> Sent: Wednesday, June 16, 2021 4:57 AM >> To: devel@edk2.groups.io >> Cc: Chiu, Chasel ; Desimone, Nathaniel L >> ; Liming Gao ; >> Dong, Eric ; Yao, Jiewen ; >> Jeremiah Cox >> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] MinPlatformPkg: Add >> TPM platform hier disable support >> >> It's been a week and I haven't seen any feedback. Please review when >> possible. >> >> Thanks, >> Michael >> >> On 6/7/2021 12:05 PM, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3411 >>> >>> This patch series adds support in TpmPlatformHierarchyLib to either >>> randomize the platform auth (current behavior) or disable the >>> platform auth (new behavior) based on a new PCD introduced to >>> MinPlatformPkg: PcdRandomizePlatformHierarchy. >>> >>> Some platforms that would like to adopt MinPlatformPkg prefer to >>> disable the platform hierarchy as opposed to the randomization >>> approach. >>> >>> Minor changes are included to eliminate code duplication in impacted >>> code. >>> >>> V2 changes: >>> 1. Update code that randomizes the platform auth in Tcg2PlatformPei >>> to use the TpmPlatformHierarchyLib interface for platform >>> hierarchy configuration. >>> 2. Remove pre-existing redundant code in Tcg2PlatformPei. >>> 3. Add a PCD to allow the platform integrator to choose how to >>> configure the TPM platform hierarchy. >>> >>> Cc: Chasel Chiu >>> Cc: Nate DeSimone >>> Cc: Liming Gao >>> Cc: Eric Dong >>> Cc: Jiewen Yao >>> Cc: Jeremiah Cox >>> Signed-off-by: Michael Kubacki >>> >>> Michael Kubacki (4): >>> MinPlatformPkg: Add TpmPlatformHierarchyLib to Components in DSC >>> MinPlatformPkg/TpmPlatformHierarchyLib: Add PEI support >>> MinPlatformPkg/Tcg2PlatformPei: Use TpmPlatformHierarchyLib >>> MinPlatformPkg/TpmPlatformHierarchyLib: Add disable support >>> >>> >> Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat >> formHierarchyLib.c => >> PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c} | 72 >> +++++++++-- >>> Platform/Intel/MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.c >> | 130 +------------------- >>> Platform/Intel/MinPlatformPkg/Include/Library/TpmPlatformHierarchyLib.h >> | 4 +- >>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec >> | 1 + >>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >> | 4 +- >>> >> Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat >> formHierarchyLib.inf => >> PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf} | 22 ++-- >>> Platform/Intel/MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf >> | 2 + >>> 7 files changed, 85 insertions(+), 150 deletions(-) >>> rename >> Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat >> formHierarchyLib.c => >> PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c} (70%) >>> rename >> Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat >> formHierarchyLib.inf => >> PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf} (66%) >>> >> >> >> >> > > > > > >