From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.164.1571665043567125905 for ; Mon, 21 Oct 2019 06:37:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=rzdkudJd; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.65, mailfrom: pete@akeo.ie) Received: by mail-wm1-f65.google.com with SMTP id c22so3731321wmd.1 for ; Mon, 21 Oct 2019 06:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7K8i/9VNJ5hgN44mRrCrp0DzgY26BPZPPrUAEHy6XEk=; b=rzdkudJdWiAU4P9jrWyjfRXsHrUXi2S9YQvD14ejxqfebg05VrCe72Y+YKdcHzdWTV tFOfHG2n7RouckKr/rETNADciENhuFZYcLVKQ62ppcEHfQ/C40hAUbndHx5WAZCKqrRw WrK+QJZ5K8VCt2gHqJQ4EYsOwao4KvQ3Rr6jZqJjPz7KeGSuY18gz5F0EiiOEYI5KO57 15lbiCEiz9TgEePhsOP0330LZOj9TSClHvjbsEt94Tq2PPNCfaZ1Pz8i36dhbXnNVQw9 BVwa1MQeSsy9GMlHjt5Aoze9sjfLD707Aun3pmtX9B5SNgZnckqd1qHNdTNE/5X83KAi vmyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7K8i/9VNJ5hgN44mRrCrp0DzgY26BPZPPrUAEHy6XEk=; b=nu/pSjPGvZDvPFBkktVVMsxq373Sx3KSRqhe07I9EdiiD6gDe6Uz2kLRvNEFoIetIz 60e3lqSMRs28rjbsdEBkCuYgUqVEdaKEEswFqv/JBTYj03zU6YEBJ8s0hxOVPD25Gt9q VCeERn79LyqqS1n9zRiX4EiRCMxtaNN7r/I6HhiGmjwMsXUXUcwDwHldTn2ZpZByFZuc xVnEATeF7tWH3F+91mnxHUmaLurR3cNOZ7OkRF86MEWhKRMZqyNQWwJqLo6mztq6n8cy vn6cwDN1LUu0UHNtrqwYp5TYQW7eaYVhklwj1UICbTC5quhKy+b4wqDoN73U0TuwxTsx d/0A== X-Gm-Message-State: APjAAAVugLNL5cDmw4dynDDdTeXB1hR6p2gsirU1xSl/U1veYbhlhExu wfn43yv6upkbijww/K4Bml0cUg== X-Google-Smtp-Source: APXvYqxB43R9fmpij1m3VKEagZE3jB2GjZ1tdoRR3tNC/z0sejJ1eYOWxmmG/WTOmGihJ3qE9SkOSQ== X-Received: by 2002:a05:600c:1:: with SMTP id g1mr20234647wmc.8.1571665042000; Mon, 21 Oct 2019 06:37:22 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.44.122]) by smtp.googlemail.com with ESMTPSA id a189sm1931590wma.2.2019.10.21.06.37.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Oct 2019 06:37:21 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4 To: Ard Biesheuvel , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: edk2-devel-groups-io , Leif Lindholm References: <20191021112506.1456-1-pete@akeo.ie> <6baf8d74-3639-593c-419a-c4e8d4e6b7d0@redhat.com> <1a295e8f-a679-0a03-283a-850e93c97bab@akeo.ie> From: "Pete Batard" Message-ID: Date: Mon, 21 Oct 2019 14:37:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Ard, On 2019.10.21 14:24, Ard Biesheuvel wrote: > On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote: >> >> On 10/21/19 2:52 PM, Pete Batard wrote: >>> Hi Philippe, >>> >>> On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote: >>>> Hi Pete, >>>> >>>> On 10/21/19 1:25 PM, Pete Batard wrote: >>>>> In preparation for adding Raspberry Pi 4 support, the Pi 3 platform >>>>> is restructured by factorizing all the drivers and libraries that are >>>>> going to be commonly used by the two platforms. >>>>> >>>>> Because much of the Pi 4 SoC is an extension of the Pi 3 one this >>>>> means that almost everything, except the ACPI tables, is moved up >>>>> into a new common RaspberryPi/ subdirectory that will serve both >>>>> platforms. The .dec is also moved to this directory, under a new >>>>> RaspberryPi.dec name, and existing references to it are updated. >>>>> > ... >>>> >>>> This change seems not related to the rest of your refactor. >>> >>> It is. See https://edk2.groups.io/g/devel/message/49288 >>> >>> The problem is we have no choice but to break the patch in two sections, >>> one that applies to edk2-platforms and the other to edk2-non-osi, since >>> these are separate repos, and the LogoDxe changes belong to non-osi. >>> >>> We need to have part of the non-osi patch that is applied to >>> edk2-platforms, and it would make little sense to break it down into the >>> non-osi related and platforms related, since it still relies on the >>> non-osi changes having been applied. >> >> I see. >> >>> >>> If anything, I guess we could consider that the non-osi patch should >>> come first. Still, whatever we do here, as long as only one of non-osi >>> and platform is applied, builds are going to be broken, and there is no >>> way to fix that unless you do consider the set of platforms + non-osi as >>> a single patch. >> >> Agreed, this is a egg/chicken problem. >> > > I dealt with this in the past by just making sure the non-osi and > platform changes are applied at the same time. So it is good to make > note of this in the cover letter, That is good advice. I'll make sure to follow that next time I have a non-osi + platforms dual patchset to submit, as it should indeed ease the review process. Regards, /Pete > but other than that, there is no way > we can apply interdependent changes to two separate repositories at > the same time without either breaking bisect for one of them, or > making a huge effort to add temporary code, defines etc that will be > removed again right after the changes have landed. >