Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

["PierreGondois" <pierre.gondois@arm.com>]

Hello Michael,

On 3/12/24 17:53, Kinney, Michael D wrote:
> The MdePkg does have a standard location for CPU specific register
> related includes.
> 
> Did you consider moving some of the content into
> 
> * MdePkg/Include/Register/Arm
> * MdePkg/Include/Register/AArch64

Yes right, this should be a better location,

Regards,
Pierre

> 
> Thanks,
> 
> Mike
> 
>> -----Original Message-----
>> From: Leif Lindholm <quic_llindhol@quicinc.com>
>> Sent: Tuesday, March 12, 2024 9:47 AM
>> To: Pierre Gondois <pierre.gondois@arm.com>; devel@edk2.groups.io
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann
>> <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Liming Gao
>> <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>;
>> Sami Mujawar <sami.mujawar@arm.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
>> Subject: Re: [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg
>>
>> On 2024-03-12 02:18, Pierre Gondois wrote:
>>> This patch relies on [1].
>>>
>>> Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
>>> move the Chipset/* files to the MdePkg as the Armlib.h relies on
>>> them.
>>>
>>> These patches span over multiple packages as these Chipset/* files
>>> are relocated to a new directory and include paths must be updated.
>>
>> I like this!
>> Traveling this week, so unable to test until Wednesday next week at the
>> earliest, which I would like to do for something this core before giving
>> a Reviewed-by. So for now, for the series:
>> Acked-by: Leif Lindholm <quic_llindhol@quicinc.com>
>>
>>> [1] https://edk2.groups.io/g/devel/message/111566
>>>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>>
>>> Pierre Gondois (2):
>>>     ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
>>>     ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg
>>>
>>>    ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c     | 2 +-
>>>    ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S     | 2 +-
>>>    ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c             | 2 +-
>>>    ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                    | 2 +-
>>>    ArmPkg/Library/ArmLib/AArch64/AArch64Support.S                | 2 +-
>>>    ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c                          | 2 +-
>>>    ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c              | 2 +-
>>>    ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c               | 2 +-
>>>    ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c                  | 2 +-
>>>    ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c                | 2 +-
>>>    ArmPlatformPkg/PrePeiCore/AArch64/Exception.S                 | 2 +-
>>>    ArmPlatformPkg/PrePeiCore/AArch64/Helper.S                    | 2 +-
>>>    ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c                      | 2 +-
>>>    ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S                   | 2 +-
>>>    ArmVirtPkg/PrePi/AArch64/ArchPrePi.c                          | 2 +-
>>>    {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h  | 2 +-
>>>    .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h   | 0
>>>    .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h   | 2 +-
>>>    .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h     | 0
>>>    MdePkg/Include/Library/ArmLib.h                               | 4 ++--
>>>    20 files changed, 19 insertions(+), 19 deletions(-)
>>>    rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h
>> (94%)
>>>    rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h
>> (100%)
>>>    rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h
>> (95%)
>>>    rename ArmPkg/Include/Chipset/ArmV7Mmu.h =>
>> MdePkg/Include/Arm/AArch32Mmu.h (100%)
>>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116714): https://edk2.groups.io/g/devel/message/116714
Mute This Topic: https://groups.io/mt/104881290/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-