From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0F0F07803D7 for ; Wed, 13 Mar 2024 10:26:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6Edg7hcWJc8yatBiz6O6pWm12kg1MI4bw8ZIShONhNc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710325566; v=1; b=zsqCorsgL3jNM/C+peBrzpq2OHjp2VfHPSXdwwO7hv2JP3iQRrNFRe4UFHSjSI0/quur1x6D ZKYve++23Q8QFVUxlQu5ulMw0uhIUCuHa4AAVgQEZwh7ltsNNtontRChIyNIGsukYQjBO1jBvBj jb2GdUH6xOXAdX75O730y8DxAAte7RQR0KBLAHLYW0TAY/sCYBjk4yE16tfBcyDSKfT/tI73ZQL pLysr2H1Sfi3DPoRRqpyXOhyDiQNyFCDy5ZGbGiaFAqn5PhkZdmSRbVnQuu/lT8qhA1qHvbDHLM qjwOcQSBuXQ7VqVu+SBGnUSIic+JIQviiZJsz7E9h/NUw== X-Received: by 127.0.0.2 with SMTP id wOB9YY7687511xwoqSZ5ehOj; Wed, 13 Mar 2024 03:26:06 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.13118.1710325565932011675 for ; Wed, 13 Mar 2024 03:26:06 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 792A31007; Wed, 13 Mar 2024 03:26:42 -0700 (PDT) X-Received: from [10.34.100.133] (e126645.nice.arm.com [10.34.100.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2EE393F73F; Wed, 13 Mar 2024 03:26:04 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 11:26:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg To: "Kinney, Michael D" , Leif Lindholm , "devel@edk2.groups.io" Cc: Ard Biesheuvel , Gerd Hoffmann , "Yao, Jiewen" , Liming Gao , Sami Mujawar , "Liu, Zhiguang" References: <20240312091850.2320650-1-pierre.gondois@arm.com> <120c7c23-a25e-41ce-a6e6-f43761f696be@quicinc.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 13 Mar 2024 03:26:06 -0700 Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OVYZeit9o76ecCHbSyDVgaDNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=zsqCorsg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Michael, On 3/12/24 17:53, Kinney, Michael D wrote: > The MdePkg does have a standard location for CPU specific register > related includes. >=20 > Did you consider moving some of the content into >=20 > * MdePkg/Include/Register/Arm > * MdePkg/Include/Register/AArch64 Yes right, this should be a better location, Regards, Pierre >=20 > Thanks, >=20 > Mike >=20 >> -----Original Message----- >> From: Leif Lindholm >> Sent: Tuesday, March 12, 2024 9:47 AM >> To: Pierre Gondois ; devel@edk2.groups.io >> Cc: Ard Biesheuvel ; Gerd Hoffmann >> ; Yao, Jiewen ; Liming Gao >> ; Kinney, Michael D ; >> Sami Mujawar ; Liu, Zhiguang >> Subject: Re: [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg >> >> On 2024-03-12 02:18, Pierre Gondois wrote: >>> This patch relies on [1]. >>> >>> Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1], >>> move the Chipset/* files to the MdePkg as the Armlib.h relies on >>> them. >>> >>> These patches span over multiple packages as these Chipset/* files >>> are relocated to a new directory and include paths must be updated. >> >> I like this! >> Traveling this week, so unable to test until Wednesday next week at the >> earliest, which I would like to do for something this core before giving >> a Reviewed-by. So for now, for the series: >> Acked-by: Leif Lindholm >> >>> [1] https://edk2.groups.io/g/devel/message/111566 >>> >>> Cc: Ard Biesheuvel >>> Cc: Gerd Hoffmann >>> Cc: Jiewen Yao >>> Cc: Leif Lindholm >>> Cc: Liming Gao >>> Cc: Michael D Kinney >>> Cc: Pierre Gondois >>> Cc: Sami Mujawar >>> Cc: Zhiguang Liu >>> >>> Pierre Gondois (2): >>> ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg >>> ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg >>> >>> ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +- >>> ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +- >>> ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +- >>> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 2 +- >>> ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 2 +- >>> ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 2 +- >>> ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +- >>> ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c | 2 +- >>> ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c | 2 +- >>> ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 2 +- >>> ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +- >>> ArmPlatformPkg/PrePeiCore/AArch64/Helper.S | 2 +- >>> ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c | 2 +- >>> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +- >>> ArmVirtPkg/PrePi/AArch64/ArchPrePi.c | 2 +- >>> {ArmPkg/Include/Chipset =3D> MdePkg/Include/AArch64}/AArch64.h | 2 = +- >>> .../Include/Chipset =3D> MdePkg/Include/AArch64}/AArch64Mmu.h | 0 >>> .../Include/Chipset/ArmV7.h =3D> MdePkg/Include/Arm/AArch32.h | 2 = +- >>> .../Chipset/ArmV7Mmu.h =3D> MdePkg/Include/Arm/AArch32Mmu.h | 0 >>> MdePkg/Include/Library/ArmLib.h | 4 ++= -- >>> 20 files changed, 19 insertions(+), 19 deletions(-) >>> rename {ArmPkg/Include/Chipset =3D> MdePkg/Include/AArch64}/AArch64.= h >> (94%) >>> rename {ArmPkg/Include/Chipset =3D> MdePkg/Include/AArch64}/AArch64M= mu.h >> (100%) >>> rename ArmPkg/Include/Chipset/ArmV7.h =3D> MdePkg/Include/Arm/AArch3= 2.h >> (95%) >>> rename ArmPkg/Include/Chipset/ArmV7Mmu.h =3D> >> MdePkg/Include/Arm/AArch32Mmu.h (100%) >>> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116714): https://edk2.groups.io/g/devel/message/116714 Mute This Topic: https://groups.io/mt/104881290/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-