From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 231442095C693 for ; Tue, 25 Apr 2017 08:21:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8290846D093; Tue, 25 Apr 2017 15:21:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8290846D093 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8290846D093 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-19.phx2.redhat.com [10.3.116.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 746AC7F59B; Tue, 25 Apr 2017 15:21:40 +0000 (UTC) To: Michael Kinney , edk2-devel@lists.01.org References: <1493082606-9348-1-git-send-email-michael.d.kinney@intel.com> Cc: Kevin W Shaw , Liming Gao From: Laszlo Ersek Message-ID: Date: Tue, 25 Apr 2017 17:21:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1493082606-9348-1-git-send-email-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 25 Apr 2017 15:21:41 +0000 (UTC) Subject: Re: [ edk2-DecSpecification PATCH 0/4] Add support for Private declarations in a package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 15:21:42 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/25/17 03:10, Michael Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=465 > https://bugzilla.tianocore.org/show_bug.cgi?id=482 > > GitHub word diff view of the patches in this series > > * [1/4] https://github.com/mdkinney/edk2-DecSpecification/commit/24a07ae89ef0467c9009633d19d24bb1ba2e115a?w=1 > * [2/4] https://github.com/mdkinney/edk2-DecSpecification/commit/65f49d1d86439b6144ff82217349a5145ec42ef0?w=1 > * [3/4] https://github.com/mdkinney/edk2-DecSpecification/commit/a28fd82b07521fc7412be75b159a44a0dd3bf1b1?w=1 > * [4/4] https://github.com/mdkinney/edk2-DecSpecification/commit/c04e668af9e1aa8c8e49d73fede6df7287b7d454?w=1 > > Remove trailing spaces from README.md > > Update DEC_SPECIFCATION to 0x0001001A / 1.26 > > Add new syntax to the DEC file for specifying > information that can only be used by modules > within the package. When modules outside the > packages attempt to use this content, the EDK > II build system must break with an error > regarding content not found. > > The four sections, Includes, Ppis, Guids and > Protocols headers will be modified with a keyword, > Private following the architecture modifier. If > Private is not present, then the content is usable > by modules outside the package. > > Clarify restriction that an element is not allowed > to be declared with and without Private modifier. > > Cc: Liming Gao > Cc: Yonghong Zhu > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael Kinney > > > Michael Kinney (4): > Remove trailing spaces from README.MD > Update version from 1.25 to 1.26 > Add support for Private declarations in a package > Declarations not allowed to be both public and private > > 2_dec_file_overview/24_[defines]_usage.md | 2 +- > 2_dec_file_overview/25_[includes]_usage.md | 24 ++- > 2_dec_file_overview/26_[guids]_usage.md | 22 ++- > 2_dec_file_overview/27_[protocols]_usage.md | 24 ++- > 2_dec_file_overview/28_[ppis]_usage.md | 24 ++- > 3_edk_ii_dec_file_format/34_[defines]_section.md | 28 ++- > 3_edk_ii_dec_file_format/35_[includes]_sections.md | 30 ++- > 3_edk_ii_dec_file_format/36_[guids]_sections.md | 29 ++- > .../37_[protocols]_sections.md | 29 ++- > 3_edk_ii_dec_file_format/38_[ppis]_sections.md | 29 ++- > README.md | 211 +++++++++++---------- > 11 files changed, 329 insertions(+), 123 deletions(-) > Reviewed-by: Laszlo Ersek Thanks! Laszlo