From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.66; helo=mail-wr1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8F4A2211575F2 for ; Tue, 6 Nov 2018 12:40:57 -0800 (PST) Received: by mail-wr1-f66.google.com with SMTP id y3-v6so14755591wrh.10 for ; Tue, 06 Nov 2018 12:40:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Al5/rjLjJ3w4NZ5RH3PLws6oz0tia5qcxT/QllvZuXY=; b=YtS1wgtwZDvMYBGvkMaJAF+8ViAq2yI3UjVGfZKsQoZwok4bu3CKy7AeaGDlks8sWY SeIoKualezcgXwxC9j0pEKnPdI1q/nezns2PlmQXz7SFxq2whp0R4d6ilaOG18awHu5T MMPy1n3BOROS9MaMKDx5eNQnyRsvJFpcCFtA4NIO5Lg7rcLMBI43v9f4WWZmHGA187uA QkdDc8Qvra+k9yxXtCbwNsMGouuqhbXMRK6b3+rWmfBqMexpMAxqMh28++QGPlueHCtY yxZ7GxGyn93KxOmlO+RFYmmN2xdbtKDqZEupeLXPyOS+zUq0amS5KFou1GwFr0BDtLJZ aYWA== X-Gm-Message-State: AGRZ1gLt4iSpFFMkpKNb0l7LQQKKJVFxmZsTeW8X3zx8yn3VCG4s/dxO trsyzIBy4qgu0li9HiPgUlY1ONQiu6U= X-Google-Smtp-Source: AJdET5cahwuKAkrz05m0P9pBH+jay9ukM3cxxwQCu9ekdy2/1k6CYBJXWGZHHII7vIUocud++TWW0A== X-Received: by 2002:adf:d246:: with SMTP id o6-v6mr23202357wri.66.1541536856153; Tue, 06 Nov 2018 12:40:56 -0800 (PST) Received: from [192.168.1.74] (67.23.27.109.rev.sfr.net. [109.27.23.67]) by smtp.gmail.com with ESMTPSA id 8-v6sm3164279wmd.26.2018.11.06.12.40.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 12:40:55 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-16-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 6 Nov 2018 21:40:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-16-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 20:40:57 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/11/18 18:58, Ard Biesheuvel wrote: > Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which > is never defined anywhere in the code. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé (Not tested with Visual Studio) > --- > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > index 7669630a5c03..e9fc5394ab28 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c > @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw); > STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw); > -#if !defined(NO_ULP_IN_S5_SUPPORT) > -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force); > -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */ > STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw); > STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw, > u16 *speed, u16 *duplex); >