From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mx.groups.io with SMTP id smtpd.web12.15375.1662053905456685453 for ; Thu, 01 Sep 2022 10:38:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QrrN5yME; spf=pass (domain: gmail.com, ip: 209.85.216.51, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f51.google.com with SMTP id n8-20020a17090a73c800b001fd832b54f6so3425564pjk.0 for ; Thu, 01 Sep 2022 10:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=wtCnnsmFAM/UT0UAMmjh0BJKelzWmF8srsnnKX7zLgg=; b=QrrN5yMEnuGJh1SDcKFUr2OA6k56FHZ+JKUW5PO544qwHTD7UhuJve4AKgr8AA6mBk q8a6kJCOSzNA7OAp5xBaCEb9oSlkZt2yaXXo6CqJfmEJwxPcHmEGlNowMozAvrQ9qV9Z HPVngmoOpXAnSzNBr1Ze0HeXM0NvDvTZjxccM1mxN6oqVgQQZw8OxLfW8CHNf/T6wPbc obKeaTDAEXd0MyLqm5rPZ5eH6UZ3j2116OZX3hEuz2uS3q3DZQrwpcSHVlJ3VAoIxCOW mWFQG9Rq8+m7R4wvKFFKx0jutlhjwPjwtMWuFvkSq6SPZLwnYmRX42fLN8P2oqPmOAuO rF2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=wtCnnsmFAM/UT0UAMmjh0BJKelzWmF8srsnnKX7zLgg=; b=LxK18rwScQ37qDebyyBxXLplRM79jUsWQMYew40fqm7Ll6j22srrf+VQ5wMzY8aFJJ 4CXUSbf2zdE+VwoN/r8JPMo+1jo3U21UlMmqo+vx46+8YOquUmlZ3Ih3W6sDGLfRjAv7 VDT6fAHoJEHyi2TReLmd4SHCeDTPlgJC1FAUI/OdA6UaDEzGbHqzEFbSBJ49yJJVRKPJ c80tYORsuBAKCbs50pOlFlfzqjaRSS+Fx6G4p4NkwLpM4+Kc6Wn9QzICTdQKsKrPTTPC DaNHozhsIvtoc/yJIlTNLvNlDGCZm2+3hIxpFqiFbQXSt51Y1NEJM8QqNIU+Ti/QDqy7 KYsQ== X-Gm-Message-State: ACgBeo3r3e/7dDOA9wGbLm1HrSXWLwITMg0+4AJAUgul/kdzLx+yvIda ymlNMbotYlKNdmoTlQAOVkQ= X-Google-Smtp-Source: AA6agR781r8f9kO00nmC9NFQ731g5u/onltEbj5567xIORmk95XLsk9upQaGgwMk010MeeJ3qCnWQw== X-Received: by 2002:a17:90a:150f:b0:1fb:aee:cd2a with SMTP id l15-20020a17090a150f00b001fb0aeecd2amr254362pja.47.1662053904900; Thu, 01 Sep 2022 10:38:24 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:d46b:1f35:ef35:9f92? ([2001:4898:80e8:f:547f:1f35:ef35:9f92]) by smtp.gmail.com with ESMTPSA id s6-20020a625e06000000b0052d87b76d12sm13684718pfb.68.2022.09.01.10.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 10:38:24 -0700 (PDT) Message-ID: Date: Thu, 1 Sep 2022 10:38:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v4 0/6] Enhance DynamicTablesPkg modules To: Sami Mujawar , devel@edk2.groups.io Cc: Joe Lopez , Alexei Fedorov , Pierre Gondois , "nd@arm.com" References: <20220810222853.1916-1-kuqin12@gmail.com> From: "Kun Qin" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Sami, Thank you so much the test and help! Regards, Kun On 9/1/2022 3:17 AM, Sami Mujawar wrote: > Dropped last patch in this series as discussed at > https://edk2.groups.io/g/devel/topic/92947269#92984 and tested using > guest firmware for Kvmtool. > > For this series. > > Tested-by: Sami Mujawar > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > > On 10/08/2022 11:28 pm, Kun Qin wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997 >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 >> >> This patch series is a follow-up of previous submission: >> https://edk2.groups.io/g/devel/message/91995 >> >> The main changes between v3 and v4 patches are: >>    - Added reviewed-by collected from previous iteration >>    - Fixed an error where the ACPI verification will fail incorrectly >>    - Updated ECAM reservation routine with config space based look-up >> >> Current DynamicTablesPkg provide great support for creating dynamic ACPI >> tables during boot time. >> >> However, there are some modules needs minor tweaks to expand support and >> compatibility for OS requirements and platform needs. >> >> This patch series proposes a few fixes to resolve minor issues >> discovered >> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe. >> >> Patch v4 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v4 >> >> Cc: Joe Lopez >> Cc: Sami Mujawar >> Cc: Alexei Fedorov >> Cc: Pierre Gondois >> >> Kun Qin (6): >>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to >> inf >>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing >>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers >>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed >>      tables >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM >>      space >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI >>      config >> >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c >> | 216 ++++++++++++-------- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c >> | 140 +++++++++++++ >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c >> |  80 +++++++- >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf >> |   4 + >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf >> |   1 + >>   5 files changed, 357 insertions(+), 84 deletions(-) >>