From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9C80D740034 for ; Thu, 8 Aug 2024 03:06:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1y1a9Qogb4X+WCUQDeqTttPoPP9e54KagrNz20VGpNk=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-ID:Content-Transfer-Encoding; s=20240206; t=1723086374; v=1; b=ia//YX/ROpsfcZ5dU5bZE1PeP3HRM0alHwCS0MmhPHYZ5rW03vNgrghmLmr6G5m0SnTAOpey INHa5LxCEP1HFhrweseTgPyNwpYbvWXTubbR14RzuMuBfCE3M/mcUBIRq1abzHyWNMbUl4Zxtbd eK7k3Dal8GO/Is/iuQUq1Wt38BMd0k124a/9m2Bu+/4NgBiHs6W1eQsFcFZzqwtCAcMXAg28/tj aS4scim8hLwkGYaahEoYpAvfgnkjMgLC7Vb7euUmN6aly8jDNg/NoId9nX3e7CNAnzhvOfgrv/F zB9861JQTt2zOhARoqSxMjI+z7qKqTJgccBBzUFFndZsA== X-Received: by 127.0.0.2 with SMTP id yiNZYY7687511xj3ALGpKj7J; Wed, 07 Aug 2024 20:06:12 -0700 X-Received: from BYAPR05CU005.outbound.protection.outlook.com (BYAPR05CU005.outbound.protection.outlook.com [52.101.85.120]) by mx.groups.io with SMTP id smtpd.web10.51442.1723086372159772368 for ; Wed, 07 Aug 2024 20:06:12 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by BL1PR01MB7649.prod.exchangelabs.com (2603:10b6:208:394::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.27; Thu, 8 Aug 2024 03:06:09 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%3]) with mapi id 15.20.7807.026; Thu, 8 Aug 2024 03:06:09 +0000 From: "Nhi Pham via groups.io" To: "quic_llindhol@quicinc.com" CC: "devel@edk2.groups.io" , Chuong Tran OS , "Rebecca Cran OS" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Thread-Topic: [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Thread-Index: AQHa6JYQg6/ydp2dV0CDOBDP/GYMJrIdI8wA Date: Thu, 8 Aug 2024 03:06:09 +0000 Message-ID: References: <20240807064731.4049764-1-nhi@os.amperecomputing.com> In-Reply-To: <20240807064731.4049764-1-nhi@os.amperecomputing.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Enabled=True;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SiteId=3bc2b170-fd94-476d-b0ce-4229bdc904a7;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SetDate=2024-08-08T03:06:07.409Z;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Name=Confidential;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ContentBits=0;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Method=Standard; x-ms-exchange-imapappendstamp: PH0PR01MB7287.prod.exchangelabs.com (15.20.7807.009) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR01MB7287:EE_|BL1PR01MB7649:EE_ x-ms-office365-filtering-correlation-id: 843df0b2-b864-4492-4900-08dcb7570d3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?4hU+neKN9b4pFZrq5pH3IGJiCQ8G+6LMTe3GcAZYld8tTepA1bsbriGwqI?= =?iso-8859-1?Q?nEfmkVRjCMWM2zvAGCuilnXD6Z9g7GRVdX9xR8DT2NYItpi6JF0whWoCzp?= =?iso-8859-1?Q?dFAPhPSZ1mJj7LJ/zzmkKzCQmAC2sP528E5Eg7iavh216NqrT2eJvygvf7?= =?iso-8859-1?Q?bAyMvbso6SQ1OYJBJ9LkAGrDZIXWdPGbfG9kHMtx1hhoKm+AeERBx/gzru?= =?iso-8859-1?Q?DvD1rDZXxFChKm0hHp/6ZacaK5fzect39oJL/pnnAxNYEMxfKZeFpAYxA1?= =?iso-8859-1?Q?4fH7FH6XOePCBqI+CGFpnmXDGaB+hMu7+F7R9WVS1SDtieMK+LmRrZS9qj?= =?iso-8859-1?Q?NhCxzLosynZTTpGTGXfAll+9BIHGhqB8l98fDJWMrl04hAWBb/DxXlpi+J?= =?iso-8859-1?Q?8vG1qNidI/TeXZRbw8aH1nZhoDIi3InfdWMu3jrLF9rOwQOCYxtMkqI6Cb?= =?iso-8859-1?Q?ZwiI1m3o6DhYRwnlr0c05M8iJtsXRS0KiuXE65y53LzIy2g6IGidKpyDmH?= =?iso-8859-1?Q?L3YmPQcRElm56d/6f8h2LNVXdy63umLiVBjmoP0YOVJ/V5oY4QD31/O/3l?= =?iso-8859-1?Q?l368029QUXa4uhlchzhFz/BuCzvnqcZn39njK6laTx7aAVhOr7PcRjvnqT?= =?iso-8859-1?Q?G7scHv/ab7NQB7YOH6cc2DyOynlHF4z+kdzAOH9KPBSiHvzWU7/MQIBQ2z?= =?iso-8859-1?Q?hybnyMGi89n/0zpajYZQHwTW5n8vAPS3m1k9HdMvfq6rAqs9JYglEDcSnd?= =?iso-8859-1?Q?jHxNuYntn/N2Km59xgeRLuoiUxJz9kssBd2jS3q1NmgChhBOsDuNksNj9z?= =?iso-8859-1?Q?c6Am4cHQM8mFgM9/OKd+nywRvH0fZzwVSjH9ks3zBaUK6hiAMYUmaWdIYP?= =?iso-8859-1?Q?kJyYIYlxaov0pQbRT/6Jxt/mxM/0N+yyuVfln+8j4yxHBmNfC+o/+1J7FZ?= =?iso-8859-1?Q?0AKi3LQVlk04H65ZlU+CqICkS9P4qtdj03BzpZN9YOr/3eAaDp7NREcgp+?= =?iso-8859-1?Q?EThdVyY5i6fRTUGMyGROwj0q7MumF3uWxgA1IZaJUAXnPOzvDaAD2TjnML?= =?iso-8859-1?Q?aqZJs0daH7DrAWuwXynyL1bAGET6k8TOUY4xvLbcf6mVOjKU8KARM5oxHM?= =?iso-8859-1?Q?VBSpTCkS5ZITrA6JzUGRB2jvklLJv1bX3DU8KJNVKEH80fbnrC2+gsR6ih?= =?iso-8859-1?Q?PoouiUDuwyw+tM2ELg3Mt+fUvFC5uCb0tXirxEvDATVJ+REhO2+1dS4Xds?= =?iso-8859-1?Q?+qghUvA/p3QMKVIV1J7pwDHD99b5/2Z55G1VouYQq2Bq9epVWt9bUcXmnn?= =?iso-8859-1?Q?3OEQRYmrW1JNxzWtVbBh5nrHQai13D4i8xWSbNuGJ/yZZsWxyFrpl7ooIc?= =?iso-8859-1?Q?RqjVPZ6MaF9xKtHr/0DysIiMx3Y/Nae5GVStAMhkiM4I1f1hvdarygSRn0?= =?iso-8859-1?Q?cNQqTRZ5JJhmnfzcQu/1hrPc1G+mrcZcbyIthg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?jMDYOV9ZWp6S5KN1Dvgb1ENgphMztjqHXuVELgQrG6iZXdWV2q754P4dXn?= =?iso-8859-1?Q?NRPauaGH5j1V1IG+VoyjRVbx9B3VWS9/ocqnjCWWw+tP9rwmAaAvirJfEn?= =?iso-8859-1?Q?dzeECTrFbxTfoN1JOqYWScw7da10B4afAWme/yQ6toMpUD3lmY8FffeZb+?= =?iso-8859-1?Q?H7ayn4FYjYOJudjVUgRfLt66RrEjxJdgdvUxAW2HNxrmQCkMbe0M5scvnY?= =?iso-8859-1?Q?p4qaChMKygAQfl1V4lc3SVaHYgUHywnzy8T9ZomyLPNNZWonTSawnk6Nwy?= =?iso-8859-1?Q?13cJJLqxo5T4HzRpdm7emf1COFSyV6INW7rcxrKfFFfSBUas6AwKot6Z/Y?= =?iso-8859-1?Q?0tVZrdrqglnwxMTULvKNG/BV4FGCjjbqqS43aFpa+3nQSDlUvoc/p97/Tv?= =?iso-8859-1?Q?dt9MKnb/V2qYalDU0vOStLAs+VtCwieDGr8L1Lz5oG0xCJEL2ZJlyz+Tdw?= =?iso-8859-1?Q?tDxE/yah+fNel2G4dtiKKKYWWIw5MFzCWMNsGSGllzB/g+6CFyU38J6M9p?= =?iso-8859-1?Q?nEiuoEZ0wjcmQLWdjA65hZFMoMQ0yCfDBubSZVQfkGusCYM9RP8wS8Aaz/?= =?iso-8859-1?Q?gTEXY9lQr7KL2hlvQow4nXwsVJF1jNDqo2ZuXdJGwJiyYewF2esGySI6bf?= =?iso-8859-1?Q?oCXDWK0lK2W+nqW7sNmFe9xXiX7LnLKGKbcdijobXwibEyP2Kz7zRgaDCP?= =?iso-8859-1?Q?IlzcYkpY/iFGp3lyQe4UmVLrBzQPVZmo6M1+AL88dinfHtrrcG5nRZRu0A?= =?iso-8859-1?Q?03ZRskRBQHsNILl+xD+sV1V1mrCakm2/HR5Vr2gSG/NVRD4Tk+c3mx0z1D?= =?iso-8859-1?Q?F+8y4E8V1TD8qdiE31Q/1i6dJSWuEz+0r7eWRodOGBitdnDxjzkOWaohVX?= =?iso-8859-1?Q?MFlx5r6zzjJLfgFQGIX+zK8hjmJ7jd0ySdDZGaI68e+ByiPY7/NqSuyTlj?= =?iso-8859-1?Q?b5E09fxzXzwf2sbQl+Tsq9S5eS59TLarbZPUvx2W1yxQxnS66ldT3FhHfh?= =?iso-8859-1?Q?1JbTAAra4pcQl7FF26skgsycoEs8NelnreexKsTH3RdOj/gH/V8jrOgFch?= =?iso-8859-1?Q?EemQTyyiGJZbCrwxWNVzDcecRYw8y6CK8XPC7Fx0UyVA6Wl4kKWXB0Dbcy?= =?iso-8859-1?Q?wI0vrOJRkym3jgRI/B+tqW6ev22HU+XKndRzu6iR9CrV0Lfh+TOk1ncOaV?= =?iso-8859-1?Q?FlnK5aIbeHAZxUVE7aWnU4a8TdrX3usA2ughlf7wSV2M4/eCsqACMHRY6r?= =?iso-8859-1?Q?a0TXUBsj4IUYyDwBn3zLphdOoD5jtNLdOOvvGLszCOdesiqxbDvMHgcNtS?= =?iso-8859-1?Q?HbsfygOvEnDfa5p57gUQcQXYnukzDYimYxbF8GhJffgrZelDgwl1O7RziD?= =?iso-8859-1?Q?2AzlO05CxTMUyCv7dHpRiRFU/DB5a7X/yGx/KmZKoMTw8eM+JPymgVQS20?= =?iso-8859-1?Q?IOTLFnm0Oyw+nIUM+UvNegGgD/EcuH5TAeZtggDHExyPzL1HZ9ZWLuswgz?= =?iso-8859-1?Q?npkaAqilMqTI2aJ7HMm0wPvPCbU2xv8zMP2AvRx1B0fuIA+Sa/Wu15iPeB?= =?iso-8859-1?Q?RrTefYN7CjXovC8X87Sxt4NdW9z9C4Y/TVvoKHXF9IIaH6dpc7UxbUXlxm?= =?iso-8859-1?Q?jAg70Vta9kXzP7stKt+aWoO0ppvC/WBXq378keRZZpwz0fUZPacm55jQ?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 843df0b2-b864-4492-4900-08dcb7570d3b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2024 03:06:09.1452 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 31lsm8ygHgtFoxgVsmdiY/qRRdlwLnChKcGWXvGVH9aQa5XHeIITOUkxj4SgtV2ryvi9gr/w7QFHwv3iQIPB9fXujf283MO8Zza1k1LA6+4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR01MB7649 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 07 Aug 2024 20:06:12 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oISv02IhzZ3hxZ46Pf76KwoKx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: <1C59B50A1F237F4C81303E97F8D8DE80@amperemail.onmicrosoft.com> Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="ia//YX/R"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Leif, I saw a comment from you in the Pull Request and I resolved it. Do you=20 prefer to review in the Github PR? Should I send v3 to the mailing list? Regards, Nhi On 8/7/2024 1:47 PM, Nhi Pham wrote: > This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF in the Mt. Jade platform. >=20 > v2: > - Refine the changes of the DwI2cLib per Leif's comments and update the > commit message accordingly. > - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. >=20 > NOTE: Regarding the controller/target terminology, the function > prototype and comment are derived from edk2/MdePkg. In this patch set, I > am trying to avoid misusing the terms in the implementation instead of > altering the function prototype and comment with the PPI and Protocol. >=20 > Nhi Pham (5): > AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation > AmpereSiliconPkg: Define PCDs for SMBUS and BMC > AmpereAltraPkg: Add SmbusHc PEI and DXE drivers > JadePkg: Add PlatformBmcReadyLib to support BMC ready check > Ampere/Jade: Enable IPMI SSIF >=20 > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec = | 15 +- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc = | 23 ++ > Platform/Ampere/JadePkg/Jade.dsc = | 2 + > Platform/Ampere/JadePkg/Jade.fdf = | 17 ++ > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib= .inf | 29 ++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf = | 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf = | 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h = | 95 +++++++ > Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h = | 11 +- > Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c = | 6 +- > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib= .c | 30 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c = | 261 ++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c = | 277 ++++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c = | 263 +++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c = | 129 ++++++++- > 15 files changed, 1227 insertions(+), 17 deletions(-) > create mode 100755 Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/= PlatformBmcReadyLib.inf > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cDxe.inf > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cPei.inf > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cCommon.h > create mode 100644 Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/= PlatformBmcReadyLib.c > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cCommon.c > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cDxe.c > create mode 100644 Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusH= cPei.c >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120288): https://edk2.groups.io/g/devel/message/120288 Mute This Topic: https://groups.io/mt/107765352/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-