Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

["Abdul Lateef Attar via groups.io" <AbdulLateef.Attar=amd.com@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 5799 bytes --]

Reviewed-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>

On 29-04-2024 10:31, abner.chang@amd.com wrote:
> From: Abner Chang<abner.chang@amd.com>
>
> BZ# 4695
>
> Signed-off-by: Abner Chang<abner.chang@amd.com>
> Cc: Abdul Lateef Attar<AbdulLateef.Attar@amd.com>
> Cc: Nickle Wang<nicklew@nvidia.com>
> ---
>   .../ManageabilityPkg/ManageabilityPkg.dsc     | 72 ++++++++++++++-----
>   1 file changed, 56 insertions(+), 16 deletions(-)
>
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> index 87b32f1182..8608450a3b 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> @@ -3,7 +3,7 @@
>   # This is the package provides edk2 drivers and libraries
>   # those are related to the platform management.
>   #
> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> +# Copyright (C) 2023-2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
>   ##
> @@ -18,15 +18,7 @@
>     BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>     SKUID_IDENTIFIER               = DEFAULT
>   
> -[Packages]
> -  MinPlatformPkg/MinPlatformPkg.dec
> -
>   [PcdsFeatureFlag]
> -  #
> -  # MinPlatform common include currently required PCD
> -  #
> -  gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable                   |FALSE
> -  gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable                      |FALSE
>   
>     #
>     # Manageability modules
> @@ -45,19 +37,67 @@
>     gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiFrb                 |TRUE
>     gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcAcpi             |TRUE
>   
> -#
> -# Include common libraries
> -#
> -!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> -!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
> -!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> -
>   [Components]
>     ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/DxeManageabilityTransportKcs.inf
>     ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/DxeManageabilityTransportMctp.inf
>     ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolLib.inf
>     ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLib.inf
>   
> +  #
> +  # Generic EDKII Lib
> +  #
> +
> +!include MdePkg/MdeLibs.dsc.inc
> +
> +[LibraryClasses.common]
> +
> +  #
> +  # Entry point
> +  #
> +  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> +  PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
> +  #
> +  # Basic
> +  #
> +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +  BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
> +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> +  IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
> +  #
> +  # UEFI & PI
> +  #
> +  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> +  UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
> +  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> +  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> +  PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
> +  PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> +  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> +  DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> +  #
> +  # Misc
> +  #
> +  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> +  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> +  DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
> +  OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
> +
> +[LibraryClasses.common.DXE_SMM_DRIVER]
> +  SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf
> +  MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmReportStatusCodeLib.inf
> +  MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf
> +
> +[LibraryClasses.common.SEC, LibraryClasses.common.PEI_CORE, LibraryClasses.common.PEIM]
> +  S3BootScriptLib|MdePkg/Library/BaseS3BootScriptLibNull/BaseS3BootScriptLibNull.inf
> +  PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
> +  HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> +  MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
> +  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> +
>   [LibraryClasses]
>     ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseManageabilityTransportNull.inf
>     IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118420): https://edk2.groups.io/g/devel/message/118420
Mute This Topic: https://groups.io/mt/105795618/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6857 bytes --]