From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6837D21A02937 for ; Wed, 28 Nov 2018 03:07:23 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 660E1C0587E5; Wed, 28 Nov 2018 11:07:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-170.rdu2.redhat.com [10.10.120.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC15C1054FD3; Wed, 28 Nov 2018 11:07:21 +0000 (UTC) To: "Brian J. Johnson" , Jeremiah Cox , stephano Cc: "edk2-devel@lists.01.org" References: <4330857f-4e27-632f-6f82-6fc6ec636b2e@linux.intel.com> <76cb4d25-7eff-b19b-0dd5-2fcc3a1e7d82@redhat.com> From: Laszlo Ersek Message-ID: Date: Wed, 28 Nov 2018 12:07:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 28 Nov 2018 11:07:23 +0000 (UTC) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [edk2-announce] Research Request X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 11:07:24 -0000 X-Groupsio-MsgNum: 33186 Content-Type: multipart/mixed; boundary="------------5D811AE27C0E954F6C901D75" Content-Language: en-US --------------5D811AE27C0E954F6C901D75 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 11/27/18 22:55, Brian J. Johnson wrote: > On 11/27/18 6:53 AM, Laszlo Ersek wrote: >> On 11/26/18 22:43, Jeremiah Cox via edk2-devel wrote: >>> Feedback on GitHub as follows… >>> >>> >>>> 1. No Lock-In - What automated data export is available? >>>> We want to be able to leave and take all our data with us. "Data" here >>>> includes: review comments, pull requests / patches (including >>>> metadata), >>>> old (rejected) pull requests and metadata, issue tracker entries and >>>> comments (if issue tracker included). This archiving should be >>>> automated, not something we do by hand. >>> Untested, but might these all be easily satisfied by subscribing a >>> mailing list to GitHub notifications? >>> https://help.github.com/articles/about-notifications/#watching-notifications  >>> https://help.github.com/articles/about-email-notifications/  >> No, they are insufficient. >> >> Following the last link above ("about-email-notifications"), one finds >> several other links; and one of those is: >> >> https://help.github.com/articles/about-notifications/ >> >> This article says, >> >>      GitHub sends participating notifications when you're directly >>      involved in activities or conversations within a repository or a >>      team you're a member of. You'll receive a notification when: >> >>      [...] >> >>      - You open, comment on, or close an issue or pull request. >> >>      [...] >> >> This is demonstrably false. I'm a member of the TianoCore organization, >> I have commented on, and closed (rejected): >> >>    https://github.com/tianocore/edk2/pull/133 >> >> and I *never*  received an email notification about my *own*  comment / >> action. I only received the initial email, about the pull request being >> opened (attached for reference). > > Try going to the "Settings" item under the menu in the top-right corner, > and clicking on the "Notifications" tab on the left.  Under "Email > notification preferences" there should be a checkbox for "Include your > own updates".  That may do what you need. That did the trick. I checked the box and then went on to close PR#134. I got two separate emails shortly after (attached), one about the closure and another about the comment. In my opinion, the default value for the setting in question is broken (it should be "on" by default). However, to me anyway, it's a big plus for GitHub that it actually supports this feature. If we are going to adopt GitHub, then we can highlight the knob in our docs. Regarding GitHub, what remains to be seen (for me) is if & how it preserves old (unmerged) topic branches, and review comments made for them, after the pull requestor rebases or deletes those branches in his/her repo. Can someone please send an artificial/test PR against my personal repo, at ? Just change some lines in OvmfPkg/README or something like that. Thank you! Laszlo --------------5D811AE27C0E954F6C901D75 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Attached Message" Return-Path: noreply@github.com Received: from zmta02.collab.prod.int.phx2.redhat.com (LHLO zmta02.collab.prod.int.phx2.redhat.com) (10.5.81.9) by zmail17.collab.prod.int.phx2.redhat.com with LMTP; Wed, 28 Nov 2018 05:41:17 -0500 (EST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by zmta02.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id 7466D1244F1 for ; Wed, 28 Nov 2018 05:41:17 -0500 (EST) Received: by smtp.corp.redhat.com (Postfix) id 6FFBF1019625; Wed, 28 Nov 2018 10:41:17 +0000 (UTC) Delivered-To: lersek@redhat.com Received: from mx1.redhat.com (ext-mx17.extmail.prod.ext.phx2.redhat.com [10.5.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 684D61001F50 for ; Wed, 28 Nov 2018 10:41:17 +0000 (UTC) Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39D4531256BE for ; Wed, 28 Nov 2018 10:41:16 +0000 (UTC) Date: Wed, 28 Nov 2018 02:41:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543401675; bh=3bbg/h7Ny9HtDHm2UJ3lrQlk703e2mUzxE0RU2ad53s=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FDo4VJMblyNdj+JORqIHHD9SdLS/JC8akCHrki6N1JU1PsydoG+JzBfN903vptliC 0zNAelv+GHIruoT1q2ny299L6J2nOXBbhH2bs2an2o2dPsfhVAEpRxsGL9fz667oZD 9INyu+NuaNSH5xHcWCm2zM86exDrfjpRYEOcsDdI= From: Laszlo Ersek Reply-To: tianocore/edk2 To: tianocore/edk2 Cc: Laszlo Ersek , Your activity Message-ID: In-Reply-To: References: Subject: Re: [tianocore/edk2] Compare to `None` using identity `is` operator (#134) Mime-Version: 1.0 Precedence: list X-GitHub-Sender: lersek X-GitHub-Recipient: lersek X-GitHub-Reason: your_activity List-ID: tianocore/edk2 List-Archive: https://github.com/tianocore/edk2 List-Post: List-Unsubscribe: , X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: lersek@redhat.com X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 216 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 28 Nov 2018 10:41:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 28 Nov 2018 10:41:16 +0000 (UTC) for IP:'192.30.252.197' DOMAIN:'out-6.smtp.github.com' HELO:'out-6.smtp.github.com' FROM:'noreply@github.com' RCPT:'' X-RedHat-Spam-Score: -7.558 (DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_IMAGE_ONLY_32,HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_PASS) 192.30.252.197 out-6.smtp.github.com 192.30.252.197 out-6.smtp.github.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.46 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Closed #134. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tianocore/edk2/pull/134#event-1992063250 --------------5D811AE27C0E954F6C901D75 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Attached Message" Return-Path: noreply@github.com Received: from zmta03.collab.prod.int.phx2.redhat.com (LHLO zmta03.collab.prod.int.phx2.redhat.com) (10.5.81.10) by zmail17.collab.prod.int.phx2.redhat.com with LMTP; Wed, 28 Nov 2018 05:41:17 -0500 (EST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by zmta03.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id A391146479 for ; Wed, 28 Nov 2018 05:41:17 -0500 (EST) Received: by smtp.corp.redhat.com (Postfix) id 9D08267C67; Wed, 28 Nov 2018 10:41:17 +0000 (UTC) Delivered-To: lersek@redhat.com Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FD396592A for ; Wed, 28 Nov 2018 10:41:17 +0000 (UTC) Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BF077654A for ; Wed, 28 Nov 2018 10:41:16 +0000 (UTC) Date: Wed, 28 Nov 2018 02:41:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543401675; bh=iHwo2tIb6zWfRDlcGSQh9UeIouh6Y3Y8J6hMZX6Lufk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MJB1g2L6C3gP4aw4SX/scBV7SCmcxfV+8NReVEDgIGxHLG0QiKp2MDddYyUlWOhz3 wQReOw++rs48MfgukJCfmoOLKX9Jq76jSfpIqYxWUsI+7TTXWrOCHwt2SqZcMW5+PV Sk5+6LD4xgvL6XEm4E5WhrDuBH5thjYFLpE+yluo= From: Laszlo Ersek Reply-To: tianocore/edk2 To: tianocore/edk2 Cc: Laszlo Ersek , Your activity Message-ID: In-Reply-To: References: Subject: Re: [tianocore/edk2] Compare to `None` using identity `is` operator (#134) Mime-Version: 1.0 Precedence: list X-GitHub-Sender: lersek X-GitHub-Recipient: lersek X-GitHub-Reason: your_activity List-ID: tianocore/edk2 List-Archive: https://github.com/tianocore/edk2 List-Post: List-Unsubscribe: , X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: lersek@redhat.com X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 216 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 28 Nov 2018 10:41:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 28 Nov 2018 10:41:16 +0000 (UTC) for IP:'192.30.252.198' DOMAIN:'out-7.smtp.github.com' HELO:'out-7.smtp.github.com' FROM:'noreply@github.com' RCPT:'' X-RedHat-Spam-Score: -7.559 (DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_PASS) 192.30.252.198 out-7.smtp.github.com 192.30.252.198 out-7.smtp.github.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sorry about the late followup. For now, please subscribe to the edk2-devel mailing list, and submit your patch as a normal git patch email, for review. https://lists.01.org/mailman/listinfo/edk2-devel For now, I'm going to have to close this PR, but this action is entirely independent of the topic & quality of your patch. I encourage you to submit your patch to the list please. The edk2 community is in the process of researching new methods to contribute, which many developers might find more convenient than the mailing list based workflow. Please refer to the wiki article at https://github.com/tianocore/tianocore.github.io/wiki/Community-Virtual-Meetings . Also, I recommend participating in the thread `[edk2] [edk2-announce] Research Request`. The archive is at https://lists.01.org/pipermail/edk2-devel/2018-November/032459.html . -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tianocore/edk2/pull/134#issuecomment-442401567 --------------5D811AE27C0E954F6C901D75--