From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8228B207E36D7 for ; Thu, 17 May 2018 07:58:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94D6079D36; Thu, 17 May 2018 14:58:27 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-28.rdu2.redhat.com [10.10.120.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 648962166BAD; Thu, 17 May 2018 14:58:26 +0000 (UTC) To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: edk2-devel@lists.01.org, qemu-devel , javierm@redhat.com, pjones@redhat.com, jiewen.yao@intel.com References: <20180515123007.10164-1-marcandre.lureau@redhat.com> <229d0059-2ab4-bf2d-cbf5-9dca4ff978bd@redhat.com> From: Laszlo Ersek Message-ID: Date: Thu, 17 May 2018 16:58:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 17 May 2018 14:58:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 17 May 2018 14:58:27 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 14:58:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 05/17/18 16:43, Marc-André Lureau wrote: > On Wed, May 16, 2018 at 11:29 AM, Laszlo Ersek wrote: >> - the "xfuncname"-related settings, so that git diff hunk headers @@ >> are useful for DSC and INF files too, >> > > This is already in my .git/config, I hope it takes it by default in > format-patch? You also need to classify files appropriately so that the xfuncname setting apply to them: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09 >> Not much of a review, I know; this is all I can offer right now. If you >> have the time to respin just with these superficial changes, that might >> make my life easier. If you prefer to delay them, that's 100% fine too. >> > > I am going to resend with the style fixes. I managed to review your v1 in full earlier today, so I'd prefer to review your v3, with my more in-depth comments addressed as well. Thanks! Laszlo