From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.79]) by mx.groups.io with SMTP id smtpd.web10.10580.1672998952906010430 for ; Fri, 06 Jan 2023 01:55:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=7ddR1Wjt; spf=pass (domain: arm.com, ip: 40.107.22.79, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RILR8nGbSUrb3yScNGw23dKB0+zbXfZapCcXu7kDtZ4=; b=7ddR1Wjt9seG5SAFYELueg3Ko1adertEe/VN5LxBHPgkl4Sr7Wuu4pzfMyMeuKFEOnkS6e9YwoOkKCcircjxY4omBrVm73DqKqT3EG6nX6HSTo5gfCwWvbuIYy0eHNKu4WNv0mhPxJ2wtqvj9U/3/fRbi3iPOJ6znCBmdoyYxF0= Received: from DB8PR04CA0012.eurprd04.prod.outlook.com (2603:10a6:10:110::22) by AS2PR08MB8880.eurprd08.prod.outlook.com (2603:10a6:20b:5f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14; Fri, 6 Jan 2023 09:55:40 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:110:cafe::90) by DB8PR04CA0012.outlook.office365.com (2603:10a6:10:110::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 09:55:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.17 via Frontend Transport; Fri, 6 Jan 2023 09:55:40 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Fri, 06 Jan 2023 09:55:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 660c0042f0649baf X-CR-MTA-TID: 64aa7808 Received: from 51b627206930.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FAF87DF5-7C8D-436F-9CE5-36C2815C45DC.1; Fri, 06 Jan 2023 09:55:33 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 51b627206930.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 09:55:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g3ykAW5ZaETi+HSQYj37t7QfHjOWYH0wjtUKYlFFqJbvuk0hPY9fKDKbfWQPSrT3+n7yZYB0D33bswhzhU2/TONlENlsTIMi5UvX45Ta38mcYHRwRgD03tpPdgVkR8Yo/A5ZL8PN4vlUIjy1hdZTT2Vn5SIM7LXoBc23azZfFisVBNukDhO2r/WhE0/jwkSF7It+iwTkfY6smkprqd6U6yKOLIAx/snsZOZyCJXiiHP405Gx2WKXp50JPaOczaZqCu78Ep+2TqDiPUiL8kO8traR8gyse0HPsJIWJQrCo7Skx6YeouRzIQnTIqnm3B0uBGqEbsiZxHb3iYLfsldjbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RILR8nGbSUrb3yScNGw23dKB0+zbXfZapCcXu7kDtZ4=; b=OPPYHIQAJBoGFeUtuxbEariyvTbHs2E913Dmc2d72pkiaLBp0h67b64fx+748uAjPExtYjlany9vX0GaFjWi8VItr9mkuCaE9vVJJvTb/I7+rvnDQ74vu0RH0iO5lQ5D+9EAa8de51SPuy+Uu1aoFfHRSErVGUHE8YGo+5OPNP3i0fzt0onFkkCrhm3PnS6q1tjybXH7zaJrLEcrUUu45ysuVlrMaAPt18rasDt6mClODDK4yrZsIZAmPyN8kShgqUeduStYKwOTYxBY8jS+La7GxZzgLB6T/m11I3kQSCN79loNLCt9Q73qcdFt5a8p4B9zZHLTA4bMDbS/1WKN/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RILR8nGbSUrb3yScNGw23dKB0+zbXfZapCcXu7kDtZ4=; b=7ddR1Wjt9seG5SAFYELueg3Ko1adertEe/VN5LxBHPgkl4Sr7Wuu4pzfMyMeuKFEOnkS6e9YwoOkKCcircjxY4omBrVm73DqKqT3EG6nX6HSTo5gfCwWvbuIYy0eHNKu4WNv0mhPxJ2wtqvj9U/3/fRbi3iPOJ6znCBmdoyYxF0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by VI1PR08MB9982.eurprd08.prod.outlook.com (2603:10a6:800:1c4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 09:55:31 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5899:7a52:822b:56e0]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5899:7a52:822b:56e0%9]) with mapi id 15.20.5986.009; Fri, 6 Jan 2023 09:55:31 +0000 Message-ID: Date: Fri, 6 Jan 2023 09:55:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string To: Ard Biesheuvel , devel@edk2.groups.io, moritzf@google.com References: <20230105230725.2401243-1-moritzf@google.com> From: "Sami Mujawar" Cc: "nd@arm.com" In-Reply-To: X-ClientProxiedBy: LO4P265CA0029.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|VI1PR08MB9982:EE_|DBAEUR03FT046:EE_|AS2PR08MB8880:EE_ X-MS-Office365-Filtering-Correlation-Id: dd3ab266-4951-4a6a-33b2-08daefcc2b39 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ac2hYkNBvEnW8YPrVwkoIcdqICewTrxf7cfAROxxyzKLxgfunnvR8DiXJQcxoxulngYcNajWii/5yujHV3dC4hkd5SuJ53nF5Fff3pBiwOq93yh1GLO6uNFmmm4hmJt/olX7EuibxPoJ5tljBan7zF90WAYCTNa6UORtFBfKY8TcVyCfc+WBIpz/dO/+aGpYVQpcgDXXwgrIzDYD28/eLd70ZUyLts3v/nxh56ZzhYLzn7XrhPoT0TVn7X22NUm3kra+ijrok7CUATWT4AnFjgQpGj1awsbPWf73yqNK/6dpLj0Z/2zCMKSm0aCTaPsMdkQQdeKo2o05vttIUHl9aN4FxykNZTF+Jm8i5cqjwciFP8pRdER8D42krVKfMHiydFIkGSs3ImBLNDI4IZKMUnWfelwKD9GKsoE4qmQqSnC1JcBf/9gbXRJOtAahYzfPTNT+2XJBKXzhh8z5ejV6fgyBt5D5lyo8hsoy4awtnw04r8N1MkwYKpGvFwYwQoQylBGwyjfO4Pjd3cn4/Qmhuc+co1AJKFbcviNSVGI0yrVg9Oq1qqrqFIFDDTy1V4E2gBHz/lKwcY3uRR4N9CBxAM8ZNMnnBtSq4h2vtvS+k6JkHvxYH8wpyVAdK3CM/Yq+x9Q7gQ2/BEceTmy29MDdNP/7EvOvwDv+c8Dukp6T8Z6dbK6BIL1mOnY16mQJpv60kGDCdrWqs45j9aTTcA+G1/HCuBPwy6irXfmfYsJwwwJ1Y5tu5MVXgvAyUkJT2JrYRCmHFN/IJSY9E6zyFpYb4RV9T1lQsMz9eGYr0oASaZ0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199015)(186003)(86362001)(36756003)(38100700002)(26005)(31696002)(316002)(6486002)(966005)(6512007)(2616005)(41300700001)(6506007)(66476007)(66946007)(8936002)(66556008)(8676002)(2906002)(44832011)(5660300002)(6666004)(53546011)(4326008)(478600001)(31686004)(83380400001)(66899015)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB9982 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8777b56c-11ee-42e6-091e-08daefcc2529 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hQa2sfunyf10AhHlIJMNoFOUWKXHlGYvp9MRi9NhX054iApWSXouu24Yy2HlFe9XSeZxcsSFmgErhsK9cvyQFvXHH03ulssr0vUA1YOO02/gxJgk8s3ctSnxn8QAV8R2axqO10w6v8j6z9ywRR5DtvjHK4eQdumUrCHrUvzEHViQBdSsHO8VZOEkIsMleQK2flHzOr6ZxBw5VC8sp0Nbj1Yv9JGEa+F1s4kZRH8KIMhF52BA6aN4xlaTvLUovysKG0/ioSVnQkN02+7h6bsWP/47P/299LkB8kLiJ7mJpFa30Nk7jnNadKVmwZbOoYRSfMLr3aVgR5WHipVGkwcx2jAzuAeRqJYBKp5tZMm9Dgjgz1jf7ANkgygd9Z0b4jWuwgk74f+8m9/TIIeHm8e5mX5aKN+JwnlK9xA6utcIGeEMBVpf3SHD9Qa0Oqg7fS4oddQKqmf2uw3VsUm3CyZUSqiSjj/XjRV1JYKJkp2ubhkyeR84KxdaB4WMMurBfFtIx/38q9Pdo1F/NhbQOVzPhp4O0WulNo7O+0s6fvBPET3uFR2XEaqFZG5T8gFNXOLv/+52du7qPM6riWcC/py7kIEpNEHpjsin8PjV40eLNacsfuCkxsZFV2xUqZ5bN43XEMFNdMQVCE4PbqDYQSi1168DZFcTHXmDh8Mwx1DguvzDGXmcT3nEQkpRznK0gMs0qKOUzIvQliEN4wij42ubCIhyFkEOXlGUXRYYV1O4hzCMuDBXMZPsoRhnVyXsx2PiUuV8eSN9In8HqTX/tNfkCgxzVrgjLy+1LNu2AUvLDlo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199015)(40470700004)(46966006)(36840700001)(31686004)(66899015)(36756003)(86362001)(53546011)(70586007)(4326008)(31696002)(8676002)(70206006)(6512007)(82740400003)(356005)(36860700001)(81166007)(41300700001)(966005)(6506007)(6486002)(186003)(26005)(6666004)(478600001)(2906002)(8936002)(316002)(5660300002)(40460700003)(40480700001)(82310400005)(44832011)(336012)(83380400001)(2616005)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 09:55:40.3882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd3ab266-4951-4a6a-33b2-08daefcc2b39 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8880 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ard, Mortiz, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 06/01/2023 09:15 am, Ard Biesheuvel wrote: > (cc Sami) > > On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel wrote: >> On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io >> wrote: >>> Linux' cpu DT bindings call out arm,armv8 while the code previously >>> used arm,arm-v8. >>> >>> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") >>> Signed-off-by: Moritz Fischer >>> --- >>> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c >>> index 2c72bd0c58..dc6e7a4d15 100644 >>> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c >>> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c >>> @@ -22,7 +22,7 @@ >>> */ >>> STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = { >>> { "arm,arm-v7" }, >>> - { "arm,arm-v8" }, >>> + { "arm,armv8" }, >> Thanks for the patch >> >> Should we keep both instead of removing the old one? [SAMI] I think we would need to keep both as the CPU nodes generated by Kvmtool have compatible string as "arm,arm-v8", see https://github.com/kvmtool/kvmtool/blob/master/arm/aarch64/arm-cpu.c#L31. Mortiz: Is it possible to share some information about your use case, please? [/SAMI] >> >>> { "arm,cortex-a15" }, >>> { "arm,cortex-a7" }, >>> { "arm,cortex-a57" } >>> -- >>> 2.39.0.314.g84b9a713c41-goog >>> >>> >>> >>> >>> >>>