From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.2936.1589364661713255085 for ; Wed, 13 May 2020 03:11:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S8mcQrgC; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589364660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p5kdqiNqkuv4MNV3RXWMr0f5jEEaJG5sqWWVB3iywjs=; b=S8mcQrgC6qUtTkqkPCglr4yzEc6IocwvsifuDBndCVCpnBCYVw28ncZEato0UXhXjgzVY/ wRIqvVDZ0uuDQ4xwoEg3KgYxbSPNvgO/biMLlZE5cDrY7nhwaYeNluWNERs7Uogn6w8RNu qQY08slL8XvKRNdGZ08y7kkoe3KsbuA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-ud9C9zoNOaCwzIS5bk7QPg-1; Wed, 13 May 2020 06:10:59 -0400 X-MC-Unique: ud9C9zoNOaCwzIS5bk7QPg-1 Received: by mail-wr1-f70.google.com with SMTP id r11so8422610wrx.21 for ; Wed, 13 May 2020 03:10:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p5kdqiNqkuv4MNV3RXWMr0f5jEEaJG5sqWWVB3iywjs=; b=licQUPcYUqMutpDZk2kZo56zOdtye5i6eVKl3NYbt7zpeXXMh7H3aGsBS5UrRuqWB9 QRjgTRTuSN0/64J/oxG9T/nTx7HecsMlKmrPMUeQwFRUMWEfFCwyFGeBESAHqkBALFKd TS57FxRzzTOtMYluAbCUOoc4/sPn1BM11Bh2RWy57SaHnkacfWOy12wvZiMn6or5lG3e EtHWuoVoYReDoxhW0YqJEAHcsBR3zvD9iuAEKhiE5O8+Tll/s7e+abYhaCsss6D/dszr 8aa5uQQZEEv8VIjldWBIjs4eTS4hO4rApyQt4qWkPzy+0rb/M9KiGUNipGeAl6x6kAYw vLnA== X-Gm-Message-State: AGi0PuYya8TF57oX4kyDLUNuUauxYI84hcm3R7LJerptOH50uTSX5jIO 62fWqB1bdLqKr19H+lI0QQWCV3KTJX7O9box0thiXwtilzMLLdxdey2S+FtXh8MaeWQ5+pFhlGP Q9Pm/WG7MDem/yA== X-Received: by 2002:adf:d849:: with SMTP id k9mr30245867wrl.304.1589364658016; Wed, 13 May 2020 03:10:58 -0700 (PDT) X-Google-Smtp-Source: APiQypIHADkKeNO+c4eZIdM5ywwhRL3uXsmzZ5bdEwnIi14O9alvN0ybfzIU1eAZnTYGb2oeW6HvSQ== X-Received: by 2002:adf:d849:: with SMTP id k9mr30245845wrl.304.1589364657693; Wed, 13 May 2020 03:10:57 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id o26sm25429236wro.83.2020.05.13.03.10.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2020 03:10:57 -0700 (PDT) Subject: Re: [PATCH] OvmfPkg: Skip initrd command on Xcode toolchain To: LAHAYE Olivier , Roman Bolshakov References: <20200512205832.17032-1-r.bolshakov@yadro.com> <0800D7A1-34BB-4DCF-ACCB-AA81490BFCD7@cea.fr> Cc: "devel@edk2.groups.io" From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 13 May 2020 12:10:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <0800D7A1-34BB-4DCF-ACCB-AA81490BFCD7@cea.fr> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Olivier, Adding the EDK2 list back, so other developers can answer to help you too. On 5/13/20 10:24 AM, LAHAYE Olivier wrote: > Hi, > > Hi, > > I've tested it (built with the patch) and I can now reach the EFI Shell (with and without HVF) on my MacBook Pro. Thanks for testing it, this is an implicit "Tested-by: LAHAYE Olivier " tag to this patch. > Exiting the shell, I can reach a basic setup menu where I was able to setup screen resolution and language. > The only cherry on the cake I miss is the ability to setup keyboard as fr-mac... Any solution? It might be worth starting a new thread on the list to ask about this. Regards, Phil. > > Cheers, > > Olivier. > > Le 13/05/2020 10:19, « Philippe Mathieu-Daudé » a écrit : > > On 5/12/20 10:58 PM, Roman Bolshakov wrote: > > OVMF booting stops with the assert if built with Xcode on macOS: > > > > Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249 LinuxInitrdDynamicShellCommand.efi > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 1F218398 > > ProtectUefiImageCommon - 0x1F218140 > > - 0x000000001FAB8000 - 0x0000000000008A60 > > > > ASSERT_EFI_ERROR (Status = Unsupported) > > ASSERT LinuxInitrdDynamicShellCommand.c(378): !EFI_ERROR (Status) > > > > The assert comes from InitializeHiiPackage() after an attempt to > > retrieve HII package list from ImageHandle. > > > > Xcode still doesn't support HII resource section and > > LinuxInitrdDynamicShellCommand depends on it. Likewise 277a3958d93a > > ("OvmfPkg: Don't include TftpDynamicCommand in XCODE5 tool chain"), > > disable initrd command if built with Xcode toolchain > > > > Fixes: 2632178bc683 ("OvmfPkg: add 'initrd' shell command to expose Linux initrd via device path") > > Cc: Ard Biesheuvel > > Cc: Liming Gao > > Cc: Andrew Fish > > Cc: Laszlo Ersek > > Signed-off-by: Roman Bolshakov > > --- > > OvmfPkg/OvmfPkgIa32.fdf | 2 +- > > OvmfPkg/OvmfPkgX64.fdf | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > > index fd81b6fa8b..e2b759aa8d 100644 > > --- a/OvmfPkg/OvmfPkgIa32.fdf > > +++ b/OvmfPkg/OvmfPkgIa32.fdf > > @@ -290,8 +290,8 @@ INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > -!endif > > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > > +!endif > > INF ShellPkg/Application/Shell/Shell.inf > > > > INF MdeModulePkg/Logo/LogoDxe.inf > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > > index f71134a659..bfca1eff9e 100644 > > --- a/OvmfPkg/OvmfPkgX64.fdf > > +++ b/OvmfPkg/OvmfPkgX64.fdf > > @@ -291,8 +291,8 @@ INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > -!endif > > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > > It looks reasonable. > > Acked-by: Philippe Mathieu-Daude > > > +!endif > > INF ShellPkg/Application/Shell/Shell.inf > > > > INF MdeModulePkg/Logo/LogoDxe.inf > > > > >