From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.57]) by mx.groups.io with SMTP id smtpd.web10.89.1652479960374067211 for ; Fri, 13 May 2022 15:12:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Ihfxiuke; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.57, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OrUJKvO/egNEgrXYw9rxT0DweNY9aZmTjFibkry9Qyjb6ZsuHM0aWPpp0gtGQqHn444EQdvQxdKL4QiqyK+EW63P4cAyEdp+HJtEVjZo1oJYoQ0hb+9ngXvaeHwrocYe+NhrS1O2xEGiu0LLepOpBTDNI2cafx3acz5wmaYZpVaPHQ31q9cX17RV++ffQDomnOkw0GOKLfFUTXTm29tuglswYwYFoqKH7exVJtDpwlsNT7yVjeWTckDnKutsgaC6vjU+gMyeuiC4RDIdAB/J9af3bauhv19I7y1jckO1sQs7vFcocCxnajrg2hS3JSeEj3RfTbafo8dsFEj+SAECwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wt1fwAAxlplII2uhH6/LKMx4A16WpYu4uW7QyS++OY8=; b=OxEwe0rHE12gDo2IDQbPURHaOZWbvvpfsVsaDRCMiNEPVG3QEX8KnAn2FJGe41QORJ8gtAnRIyNtyjxOC0O8tD4GVQOUPJbqIsHu36y1Fb0Lciqujq5FULpS5kAKNmfYfuz+eafH11iXOHEqMl+K1iWrwaQ/2lYY5H+BUDu4dMzwzwfJw9iKHcSgH1WuzlFdY9sOpDSbax5denPg0OZQaqWVxriqn8Y5Eo0+WICu2xfGVIK+PzKwGCl91qwGmiowD4yEl0R/fsUUazs1Aq+ISikkf/xgBsk3pWq94awoFOSq/bVZWXq5lWoUGzwIAxvFsVGa1fbDpTQbnPJfG0rPRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wt1fwAAxlplII2uhH6/LKMx4A16WpYu4uW7QyS++OY8=; b=Ihfxiukeykq/GiKGGCvufd+gjeVaqK9tJ3bT1RlLBDstv+K/E90VoImEddJEaZFcAeNnRs4/G+UIiikNvBqCYMRRIVj8fUk7p3ZxxvYNCCt43mepIjqumBTIWe3jot3fa5oT+q41CAu/l+P0V8AUtqJBfD0ZcdYNLwIOsxb1vYk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by SJ0PR12MB5471.namprd12.prod.outlook.com (2603:10b6:a03:300::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 22:12:36 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a%4]) with mapi id 15.20.5250.016; Fri, 13 May 2022 22:12:36 +0000 Message-ID: Date: Fri, 13 May 2022 17:12:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [edk2-devel] [PATCH V7 36/37] UefiCpuPkg: Setting initial-count register as the last step To: devel@edk2.groups.io, min.m.xu@intel.com, "Ni, Ray" Cc: "Yao, Jiewen" , Gerd Hoffmann , Anthony Perard , Julien Grall , "Dong, Eric" References: <2d6f5751-e7de-3c1d-3985-849a9ae16462@amd.com> <0389cf2a-e9ba-0ba2-ac90-73ae402f7a08@amd.com> From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: SN4PR0501CA0039.namprd05.prod.outlook.com (2603:10b6:803:41::16) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8314a34e-60f8-462d-67f4-08da352daf9e X-MS-TrafficTypeDiagnostic: SJ0PR12MB5471:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2uC8T+j/QLSr3ViPu25nGXBohMSM7bOxdfo8rXMcs2svh4K2N/MxWJjgXHqQIKCcs7HNn+Cb5iyFgaAP+BZKkgPkD55+eH9B85TwAyfU43VbSmXsSHzeYWczu3iAcO1RvayL/1e5S2EsbaG1S2OJMZbWCFBBIDmRQkbIif8XDawWWqWMKmfr3LzzXQw5BffO78xchXQ/Ngg6zYRaJCdcyf9h3Gn9JaDGRCWITRZKjT40DAvWIP+3tD/GG9z77jO7u3Ybauv4p7qjCGymmMr7Hr1GEu4irkfvBkE8DwpgD9k76xqO8uy+/1YBY6hML68cPbBXsDrZzThiIwBTiahaOGV5/Wvte/GdnbYrkbl8DoW6keUt2T9ag58FwXwk7/assJ7XX/6h5+hdp4wGYZF4js35erFhCcVhupZq/tErcpJsdtpvTd5cpXfN9wnuYUkk14a+jgRk8EYPDfEP0hXjwnbnxhbACmN5ks2nqV4E87l3rK+Drmq5z8cT/nks81lCcga9sgWz1JiOX0YFEWF9nO3JsdzgOX2ctfLhpo6MY1NXSNmNfHL8It0T9Hl/b/7F1yXwhJ6RO8U/qLVDW5/pcdTnRNZroIwb2benr72ehCg21Z2owY526dkkL6pKFPktZTRd55lJIzE9DOVRMcmBx503MKjJmng+wbtImmcktQiDsnAi4WyVfJc/PXt6UDPubSS6wnyldSw6sUNyqjfPVpYqampxzb3u/9P++qhrOIaJdK7J/GpCxPxnmfw68/itl85MQwl9UrELtk3k7Vo5G2SVAFq9GDJaEAfaqj/ICGAWKe+GC0+M9/+qnM/huzeQOvlY/9SCp5XjzxXrXu2sQgh/oXbJxPIoVAGmBIQbFq8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(31686004)(2906002)(36756003)(5660300002)(6916009)(31696002)(86362001)(186003)(83380400001)(38100700002)(6486002)(316002)(54906003)(66476007)(66556008)(53546011)(8676002)(66946007)(6512007)(4326008)(26005)(6506007)(2616005)(508600001)(966005)(3714002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkg2Nm51MnAyNU1Hc29ONlJxcWQ1ZUFSV0RrR05NOFNudFk1cXFlK3ZRTmpP?= =?utf-8?B?QjMwSC9hYk1UNldvakNVU1YwOVFzUXhVbjd1SFNTdWIwR0pJbnhsQ3dkTm55?= =?utf-8?B?dFNjdXVKY2lPekdYVktkOVFhS2I2OXE4aWVLU3B6aDlmSEpWRDIxcjZjWm5Y?= =?utf-8?B?T1ZReWF3aXB2dWJacllHMVJsQi93UE1pWCtoRDFOcUNUVi90UUJyZng2aW9R?= =?utf-8?B?cnJaKzR1UHJmOWt3VVIrSUlNakR5OGxRQmtTOUhMUFZad2tyYXgwSUViUi9N?= =?utf-8?B?SVRQZ3VWOWxmQUowbzQ0eis2dVJWekMzS2V1QkN6dGJDZzhQaTBVd2huM0hF?= =?utf-8?B?ZGZYV1FOV3hiZ3UyaWFwNExiV1EyRG5kRHBBOUx1cWJTc0pzbVQrRCtGc0Zz?= =?utf-8?B?SytjZ01LOVdNQ3VBbTcyRmtmaFBaR1M2S3Yza3dsTlh5VG9WN3VGYkd3RTc0?= =?utf-8?B?Sk1FcktoVkVRdzNza2gzeHRJMlJ3WE9HaTJ4NFBUVzFZSGxVOFhudWJtOUpr?= =?utf-8?B?U0ZQY2xSSjkrZWh4MGNNZlNDSW8xL3ZNZVphb3hZTmJNOFR6bzVNY01nMkxP?= =?utf-8?B?a0RhQmFSRG1WRHdIMXN1WjNMMG01VzlXaDlvZDI1YjV0OTJIWFBZNnpXWklj?= =?utf-8?B?ckM1U1ZYdmw3S00ybWt2V28rb3NXeVVYeHZ2NjUrNGdQS1hhR2hyWmlJa0pN?= =?utf-8?B?cURUVVVqbjdzWVU4cTJlNnlJZEl1RnlBQnhHQW91TDZueFEvckVUWlFtWFNQ?= =?utf-8?B?STRoYWlHc3BGRnRPeS9OaWRJS2JoOEdWb2FOSDUxTGdUQmxtTy9UQnNsbXVZ?= =?utf-8?B?bTdOdlhMK2tId2ZlV3N2SnkycFU1MDd4LzZod3hMQUoxUkxKcHpwcnRFWXo4?= =?utf-8?B?UlUyMy9LOG9aQ1BYdmwzYzhscDhmZXpLN0lsbUM1Q2JGQzduczV5NlNucmRN?= =?utf-8?B?b25xZjZGME5qZlhQMjBqOGQwTVZnV2RITjdpQ0kzc2JESkFsNGhaOVZKSFda?= =?utf-8?B?ZDg0dVFhV3FDZFYyYTF2MmtPRHZ2ZG5uV1FEZVNvSkV2TG1jK1ptRzRFUDJZ?= =?utf-8?B?NXM4SjBsQVB3dGp6N1pvL1NZOEw2alBFRUUvcURRaEhYREthcnI3WXNKaDAr?= =?utf-8?B?WG92VWt1VFd5Z0oyNVA4dWtmNGxwYWlQd0thYXpSS2FVclVGeW9JVzlyS29i?= =?utf-8?B?MDVOMXU5V0s1dzZ2TVA1ZnN3ZkRqb3ZZdFpkcFVVcjdleEFURGl2di9OYXhJ?= =?utf-8?B?dDNxU09rRzJKZkd5VmhETjNmREt5SzNvNzJlMnNFaHZiWDZvaFo4QmdKc0t2?= =?utf-8?B?TjNYVWt3eEcveGc4Y2dPajU5REhwOW9NMDIwMXAyZU80YzRQZkF3UFFuNFlJ?= =?utf-8?B?TkdUenRsak11cUx1TjBBNUtqUXpUTDRHL2UwYVIwZmxuaW1kdFFTUmlRQ08x?= =?utf-8?B?TWNBSklKdlJ0VjBpWVZXaGdIcWZNOXlocDhNUGF5bmRLRU00M3dxQ013dzc2?= =?utf-8?B?TldRR2wra2dVNGErN3pLTElVd1VuSzFzU3g1b2l4M2lTVDlRVG9ZOGdtT2Y5?= =?utf-8?B?V3MzK095ODFDdUp4WGZ4Q3FrZTVjV3RhQ0N5cTZPVE8weThMMkxGVXFhU1gv?= =?utf-8?B?b0FMZjZ4VnRWcWRNUW1VSnZNSW9qVnZia25EK3VyVkc5YWZsbmVBdDRiQ2xB?= =?utf-8?B?QkJRYm1MZGI0WUs1cVorYjhVOXZEemcyeVNETjNXSm8wMXRMY0ZPUHJnaUxt?= =?utf-8?B?VVJMbmxQdlZnOWxCOGc2RzNsMnRacUFCR3VJWXFCbGtlQU43b2ttdmV6aXVC?= =?utf-8?B?UXFjMDNiOFh4R3NOVlg3U3cxSkZWZXBWbmh4VzBhdnE2RGZhTWV1b2FDb2M4?= =?utf-8?B?K2FFY1hHSzBFKzJKb3QrWm1ydE8wcXJYQ1k4bUNwYkdMM3pOL2IrU1ZWaTVX?= =?utf-8?B?TGNuT2VYdUFxV1Z4bmUzeWFTOTFOY2xsTVFMNXpFM3JXMlZQN1o3NU10T2Qx?= =?utf-8?B?Z1BXK1ptaU1zV0ZSNHJETVhRR1lGZ0dVZDRqb1JvWUt1UDZHUFY0d3o3Vm0w?= =?utf-8?B?NzlmMHI5VjVXaE9xODlqc1lhZWgxTWp5R0RtaTVaNGNybC9uNytnVWhaSGgz?= =?utf-8?B?T2ZBVWF0OFVuS0lMSksrNVE3dWwydmVDbkVEb0NmNWFKWmRxSkFEMnFoeUNJ?= =?utf-8?B?QmhWOEtaaFV2bGpoa0ZoQ1F0REJTcnErTW1WM1lsZVEwSzVNemh1WEtPdWtU?= =?utf-8?B?UzRzV1ZKbjlQWEwrQWFtZjk2VmR3STMzYU5PTFE5MjdkSnc5Mzlud0Z4QUcx?= =?utf-8?B?ZEplZ0JyWXBaRmFBMFo5QTkrUUUxWkZFQ2VCTXJjc3VobHlIaXVLQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8314a34e-60f8-462d-67f4-08da352daf9e X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 22:12:36.5989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rVVXu43227Wv3nfcrDSwjoSZtjNVFP1+q77/EvcaGPSMtc3bN5w8JwbwjrC6E4b369JJmqg4JV5laEspz+Ss6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5471 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/11/22 19:52, Min Xu via groups.io wrote: > On May 11, 2022 10:06 PM, Lendacky, Thomas wrote: >> On 5/10/22 21:00, Xu, Min M wrote: >>> On May 11, 2022 4:30 AM, Tom Lendacky wrote: >>>> I'm replying to this patch since I can't find patch V12 46/47 >>>> anywhere in my email. >>>> >>>> I've bisected a regression in the Linux kernel to this patch when an >>>> SEV-SNP guest is booted. The following message is issued in the >>>> kernel for every AP being brought online: >>>> >>>> APIC: Stale IRR: >>>> >> 00000000,00000000,00000000,00000000,00000000,00000000,00000000,000 >>>> 00020 ISR: >>>> >> 00000000,00000000,00000000,00000000,00000000,00000000,00000000,000 >>>> 00000 >>>> >>>> Possibly a timing issue involving the mode switch with the interrupt >>>> unmasked. If I leave the interrupt masked and only un-mask it after >>>> the programming of the init-count, then the message goes away. >>> >>> Do you mean in InitializeApicTimer, it should follow below steps: >>> 1. mask LvtTimer. (set LvtTimer.Bits.Mask = 1) 2. Do other stuff, >>> including programing the init-count register. >>> 3. un-mask LvtTimer (set LvtTimer.Bit.Mask = 0) >> >> Yes, I believe so. I'm not an expert on the APIC timer, but that seems >> reasonable to me. > I tested this fix in Td guest and it has no side effect. > I check the Intel SDM (Vol.3A Chap 10.5 Handling Local Interrupts) but it doesn't describe the actual sequence of LvtTimer.Bits.Mask and programming of init-count register. > @ Ni, Ray, What's your thought about it? I guess you can theoretically miss an interrupt if your initial count is expires before you unmask the interrupt, so I think your fix is correct and no changes are needed. I need to double check whether I'm properly resetting the APIC when APs are booted multiple times. Since this only occurs with SNP, I think this is on my end. Thanks, Tom > > Thanks > Min > > > > >