From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 05 Jul 2019 06:53:46 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD3993091754; Fri, 5 Jul 2019 13:53:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-244.ams2.redhat.com [10.36.116.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A33468C79; Fri, 5 Jul 2019 13:53:43 +0000 (UTC) Subject: Re: [PATCH v3 04/35] OvmfPkg: Introduce XenPlatformPei To: Anthony PERARD , devel@edk2.groups.io Cc: xen-devel@lists.xenproject.org, Ard Biesheuvel , Jordan Justen , Julien Grall References: <20190704144233.27968-1-anthony.perard@citrix.com> <20190704144233.27968-5-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 5 Jul 2019 15:53:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190704144233.27968-5-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 05 Jul 2019 13:53:45 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Anthony, On 07/04/19 16:42, Anthony PERARD wrote: > Introduce XenPlatformPei, a copy of OvmfPkg/PlatformPei without some > of QEMU specific initialization, Xen does not support QemuFwCfg. > > This new module will be adjusted to accommodate Xen PVH. > > fw_cfg dependents that have been removed, which are dynamically skipped > when running PlatformPei on Xen: > - GetFirstNonAddress(): controlling the 64-bit PCI MMIO aperture via the > (experimental) "opt/ovmf/X-PciMmio64Mb" file > - GetFirstNonAddress(): honoring the hotplug DIMM area > ("etc/reserved-memory-end") in the placement of the 64-bit PCI MMIO > aperture > - NoexecDxeInitialization() is removed, so PcdPropertiesTableEnable and > PcdSetNxForStack are left constant FALSE (not set dynamically from > fw_cfg "opt/ovmf/PcdXxxx") > - MaxCpuCountInitialization(), PublishPeiMemory(): the max CPU count is > not taken from the QemuFwCfgItemSmpCpuCount fw_cfg key; > PcdCpuMaxLogicalProcessorNumber is used intact and > PcdCpuApInitTimeOutInMicroSeconds is never changed or used. > - InitializeXenPlatform(), S3Verification(): S3 is assumed disabled (not > consulting "etc/system-states" via QemuFwCfgS3Enabled()). > - InstallFeatureControlCallback(): the feature control MSR is not set > from "etc/msr_feature_control" > (also removed FeatureControl.c as there is nothing been executed) > > Also removed: > - SMRAM/TSEG-related low mem size adjusting (PcdSmmSmramRequire is > assumed FALSE) in PublishPeiMemory(), > - QemuInitializeRam() entirely, > > Xen related changes: > - Have removed the module variable mXen, as it should be always true. > - Have the platform PEI initialization fails if Xen has not been > detected. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v3: > - fix coding style in new code > (use DEBUG_xxx, add ASSERT before CpuDeadLoop) > - rebased, SPDX In my v2 review at , point (2), I meant that you should please replace *all* EFI_D_xxx macros with DEBUG_xxx macros, in new code. By "new code" I didn't mean code that you wrote afresh, but simply source code that appeared as new -- i.e., as an addition -- in the patch. That is, all the EFI_D_xxx macros that you inherit from PlatformPei by virtue of copying should be replaced as well. This v3 patch continues to add 12 instances of EFI_D_xxx, by my count. Please replace all of those, with DEBUG_xxx. The rest of the updates in v3 are good, and sufficient. Thanks Laszlo